| Message ID | 20170727193312.9849-3-dietmar.eggemann@arm.com (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
On 27-07-17, 20:33, Dietmar Eggemann wrote: > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 9bf97a366029..04e2f7e4964e 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -2404,6 +2404,17 @@ int cpufreq_boost_enabled(void) > EXPORT_SYMBOL_GPL(cpufreq_boost_enabled); > > /********************************************************************* > + * FREQUENCY INVARIANT ACCOUNTING SUPPORT * > + *********************************************************************/ We don't need another of these fancy headers :) Just add below routine somewhere at the top, maybe before cpufreq_generic_init(). > + > +__weak void arch_set_freq_scale(struct cpumask *cpus, > + unsigned long cur_freq, > + unsigned long max_freq) > +{ > +} > +EXPORT_SYMBOL_GPL(arch_set_freq_scale); > + > +/********************************************************************* > * REGISTER / UNREGISTER CPUFREQ DRIVER * > *********************************************************************/ > static enum cpuhp_state hp_online; > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index f10a9b3761cd..e38acc1a4d47 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -899,6 +899,9 @@ static inline bool policy_has_boost_freq(struct cpufreq_policy *policy) > > extern unsigned int arch_freq_get_on_cpu(int cpu); > > +extern void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq, > + unsigned long max_freq); > + > /* the following are really really optional */ > extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs; > extern struct freq_attr cpufreq_freq_attr_scaling_boost_freqs; > -- > 2.11.0
Hi Viresh, On 28/07/17 08:30, Viresh Kumar wrote: > On 27-07-17, 20:33, Dietmar Eggemann wrote: >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c >> index 9bf97a366029..04e2f7e4964e 100644 >> --- a/drivers/cpufreq/cpufreq.c >> +++ b/drivers/cpufreq/cpufreq.c >> @@ -2404,6 +2404,17 @@ int cpufreq_boost_enabled(void) >> EXPORT_SYMBOL_GPL(cpufreq_boost_enabled); >> >> /********************************************************************* >> + * FREQUENCY INVARIANT ACCOUNTING SUPPORT * >> + *********************************************************************/ > > We don't need another of these fancy headers :) > > Just add below routine somewhere at the top, maybe before > cpufreq_generic_init(). Yes, sure. Will address this in the upcoming v4. Thanks the review! -- Dietmar
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9bf97a366029..04e2f7e4964e 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2404,6 +2404,17 @@ int cpufreq_boost_enabled(void) EXPORT_SYMBOL_GPL(cpufreq_boost_enabled); /********************************************************************* + * FREQUENCY INVARIANT ACCOUNTING SUPPORT * + *********************************************************************/ + +__weak void arch_set_freq_scale(struct cpumask *cpus, + unsigned long cur_freq, + unsigned long max_freq) +{ +} +EXPORT_SYMBOL_GPL(arch_set_freq_scale); + +/********************************************************************* * REGISTER / UNREGISTER CPUFREQ DRIVER * *********************************************************************/ static enum cpuhp_state hp_online; diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index f10a9b3761cd..e38acc1a4d47 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -899,6 +899,9 @@ static inline bool policy_has_boost_freq(struct cpufreq_policy *policy) extern unsigned int arch_freq_get_on_cpu(int cpu); +extern void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq, + unsigned long max_freq); + /* the following are really really optional */ extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs; extern struct freq_attr cpufreq_freq_attr_scaling_boost_freqs;
Frequency-invariant accounting support based on the ratio of current frequency and maximum supported frequency is an optional feature an arch can implement. Since there are cpufreq drivers (e.g. cpufreq-dt) which can be build for different arch's a default implementation of the frequency-invariance setter function arch_set_freq_scale() is needed. This default implementation is an empty weak function which will be overwritten by a strong function in case the arch provides one. The setter function passes the cpumask of related (to the frequency change) cpus (online and offline cpus), the (new) current frequency and the maximum supported frequency. Cc: Rafael J. Wysocki <rjw@rjwysocki.net> Cc: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com> --- drivers/cpufreq/cpufreq.c | 11 +++++++++++ include/linux/cpufreq.h | 3 +++ 2 files changed, 14 insertions(+)