diff mbox

arm64: dts: hisi: add PCIe host controller node for hip07 SoC

Message ID 1500366820-58555-1-git-send-email-wangzhou1@hisilicon.com (mailing list archive)
State New, archived
Headers show

Commit Message

Zhou Wang July 18, 2017, 8:33 a.m. UTC
Add one PCIe host controller node for HiSilicon Hip07 SoC and enable it in
D05 board.

Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
---
 arch/arm64/boot/dts/hisilicon/hip07-d05.dts |  4 ++++
 arch/arm64/boot/dts/hisilicon/hip07.dtsi    | 21 +++++++++++++++++++++
 2 files changed, 25 insertions(+)

Comments

Wei Xu Aug. 4, 2017, 1:01 p.m. UTC | #1
Hi Zhou,

On 2017/7/18 9:33, Zhou Wang wrote:
> Add one PCIe host controller node for HiSilicon Hip07 SoC and enable it in
> D05 board.
> 
> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hip07-d05.dts |  4 ++++
>  arch/arm64/boot/dts/hisilicon/hip07.dtsi    | 21 +++++++++++++++++++++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hip07-d05.dts b/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
> index f5d7f08..fe7c16c 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
> @@ -84,3 +84,7 @@
>  &sas1 {
>  	status = "ok";
>  };
> +
> +&p0_pcie2_a {
> +	status = "ok";
> +};
> diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> index 283d7b5..077b2d7b 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> @@ -1534,5 +1534,26 @@
>  				     <637 1>,<638 1>,<639 1>;
>  			status = "disabled";
>  		};
> +
> +		p0_pcie2_a: pcie@a00a0000 {
> +			compatible = "hisilicon,pcie-almost-ecam";

The compatible string should be "hisilicon,hip07-pcie-ecam".

> +			reg = <0 0xa8000000 0 0x800000>,<0 0xa00a0000 0 0x10000>;
> +			bus-range = <0x80 0x87>;
> +			msi-map = <0x8000 &p0_its_dsa_a 0x8000 0x800>;
> +			msi-map-mask = <0xffff>;
> +			#address-cells = <3>;
> +			#size-cells = <2>;
> +			device_type = "pci";
> +			dma-coherent;
> +			ranges = <0x02000000 0 0xa8800000 0 0xa8800000 0 0x77f0000
> +				  0x01000000 0 0 0 0xafff0000 0 0x10000>;

Can you also check whether the ranges are working or not with current UEFI?
Thanks!

Best Regards,
Wei

> +			#interrupt-cells = <1>;
> +			interrupt-map-mask = <0xf800 0 0 7>;
> +			interrupt-map = <0x0 0 0 1 &mbigen_pcie2_a 671 4
> +					 0x0 0 0 2 &mbigen_pcie2_a 671 4
> +					 0x0 0 0 3 &mbigen_pcie2_a 671 4
> +					 0x0 0 0 4 &mbigen_pcie2_a 671 4>;
> +			status = "disabled";
> +		};
>  	};
>  };
>
Zhou Wang Aug. 7, 2017, 12:59 a.m. UTC | #2
On 2017/8/4 21:01, Wei Xu wrote:
> Hi Zhou,
> 
> On 2017/7/18 9:33, Zhou Wang wrote:
>> Add one PCIe host controller node for HiSilicon Hip07 SoC and enable it in
>> D05 board.
>>
>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hip07-d05.dts |  4 ++++
>>  arch/arm64/boot/dts/hisilicon/hip07.dtsi    | 21 +++++++++++++++++++++
>>  2 files changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hip07-d05.dts b/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
>> index f5d7f08..fe7c16c 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
>> @@ -84,3 +84,7 @@
>>  &sas1 {
>>  	status = "ok";
>>  };
>> +
>> +&p0_pcie2_a {
>> +	status = "ok";
>> +};
>> diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
>> index 283d7b5..077b2d7b 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
>> @@ -1534,5 +1534,26 @@
>>  				     <637 1>,<638 1>,<639 1>;
>>  			status = "disabled";
>>  		};
>> +
>> +		p0_pcie2_a: pcie@a00a0000 {
>> +			compatible = "hisilicon,pcie-almost-ecam";
> 
> The compatible string should be "hisilicon,hip07-pcie-ecam".

OK, I will modify this and resend it later.

> 
>> +			reg = <0 0xa8000000 0 0x800000>,<0 0xa00a0000 0 0x10000>;
>> +			bus-range = <0x80 0x87>;
>> +			msi-map = <0x8000 &p0_its_dsa_a 0x8000 0x800>;
>> +			msi-map-mask = <0xffff>;
>> +			#address-cells = <3>;
>> +			#size-cells = <2>;
>> +			device_type = "pci";
>> +			dma-coherent;
>> +			ranges = <0x02000000 0 0xa8800000 0 0xa8800000 0 0x77f0000
>> +				  0x01000000 0 0 0 0xafff0000 0 0x10000>;
> 
> Can you also check whether the ranges are working or not with current UEFI?
> Thanks!

Sure.

Thanks,
Zhou

> 
> Best Regards,
> Wei
> 
>> +			#interrupt-cells = <1>;
>> +			interrupt-map-mask = <0xf800 0 0 7>;
>> +			interrupt-map = <0x0 0 0 1 &mbigen_pcie2_a 671 4
>> +					 0x0 0 0 2 &mbigen_pcie2_a 671 4
>> +					 0x0 0 0 3 &mbigen_pcie2_a 671 4
>> +					 0x0 0 0 4 &mbigen_pcie2_a 671 4>;
>> +			status = "disabled";
>> +		};
>>  	};
>>  };
>>
> 
> 
> .
>
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/hisilicon/hip07-d05.dts b/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
index f5d7f08..fe7c16c 100644
--- a/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
+++ b/arch/arm64/boot/dts/hisilicon/hip07-d05.dts
@@ -84,3 +84,7 @@ 
 &sas1 {
 	status = "ok";
 };
+
+&p0_pcie2_a {
+	status = "ok";
+};
diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
index 283d7b5..077b2d7b 100644
--- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
@@ -1534,5 +1534,26 @@ 
 				     <637 1>,<638 1>,<639 1>;
 			status = "disabled";
 		};
+
+		p0_pcie2_a: pcie@a00a0000 {
+			compatible = "hisilicon,pcie-almost-ecam";
+			reg = <0 0xa8000000 0 0x800000>,<0 0xa00a0000 0 0x10000>;
+			bus-range = <0x80 0x87>;
+			msi-map = <0x8000 &p0_its_dsa_a 0x8000 0x800>;
+			msi-map-mask = <0xffff>;
+			#address-cells = <3>;
+			#size-cells = <2>;
+			device_type = "pci";
+			dma-coherent;
+			ranges = <0x02000000 0 0xa8800000 0 0xa8800000 0 0x77f0000
+				  0x01000000 0 0 0 0xafff0000 0 0x10000>;
+			#interrupt-cells = <1>;
+			interrupt-map-mask = <0xf800 0 0 7>;
+			interrupt-map = <0x0 0 0 1 &mbigen_pcie2_a 671 4
+					 0x0 0 0 2 &mbigen_pcie2_a 671 4
+					 0x0 0 0 3 &mbigen_pcie2_a 671 4
+					 0x0 0 0 4 &mbigen_pcie2_a 671 4>;
+			status = "disabled";
+		};
 	};
 };