diff mbox

arm64: allwinner: a64: pine64: Use dcdc1 regulator for mmc0

Message ID 1502516402-4661-1-git-send-email-jteki@openedev.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jagan Teki Aug. 12, 2017, 5:40 a.m. UTC 
From: Jagan Teki <jagan@amarulasolutions.com>

Since current tree support AXP803 regulators, replace
fixed regulator with AXP803 dcdc1 regulator.

Tested on pine64.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Chen-Yu Tsai Aug. 14, 2017, 10:09 a.m. UTC | #1 
Hi,

On Sat, Aug 12, 2017 at 1:40 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> Since current tree support AXP803 regulators, replace
> fixed regulator with AXP803 dcdc1 regulator.
>
> Tested on pine64.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

There was a lot of (heated) discussion [1] around this change. Maxime
stated he would merge a patch with this change but ended up picking
a later version without it. I'll leave this to him when he gets back.

ChenYu

[1] https://www.spinics.net/lists/arm-kernel/msg595419.html
Maxime Ripard Aug. 21, 2017, 9:48 a.m. UTC | #2 
On Sat, Aug 12, 2017 at 11:10:02AM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> Since current tree support AXP803 regulators, replace
> fixed regulator with AXP803 dcdc1 regulator.
> 
> Tested on pine64.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Applied, thanks!
Maxime
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
index 122b5d8..604cdae 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
@@ -62,13 +62,6 @@ 
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
-
-	reg_vcc3v3: vcc3v3 {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc3v3";
-		regulator-min-microvolt = <3300000>;
-		regulator-max-microvolt = <3300000>;
-	};
 };
 
 &ehci0 {
@@ -109,7 +102,7 @@ 
 &mmc0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins>;
-	vmmc-supply = <&reg_vcc3v3>;
+	vmmc-supply = <&reg_dcdc1>;
 	cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
 	cd-inverted;
 	disable-wp;