diff mbox

ARM: S3C24XX: Fix NAND ECC mode for mini2440 board

Message ID 1502915461-8625-1-git-send-email-snawrocki@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sylwester Nawrocki Aug. 16, 2017, 8:31 p.m. UTC 
From: Sylwester Nawrocki <snawrocki@kernel.org>

After commit e9f66ae23c "mtd: s3c2410: make ecc mode configurable
via platform data" booting of the mini2440 board is broken, since
for this board we have CONFIG_MTD_NAND_S3C2410_HWECC set. The console
gets flooded with errors reported by the mtd subsystem.
This patch changes ecc_mode to NAND_ECC_HW which restores proper
operation of the NAND flash memory.

Cc: Sergio Prado <sergio.prado@e-labworks.com>
Fixes: e9f66ae23c "mtd: s3c2410: make ecc mode configurable via platform data"
Signed-off-by: Sylwester Nawrocki <snawrocki@kernel.org>
---
 arch/arm/mach-s3c24xx/mach-mini2440.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Aug. 21, 2017, 5:52 p.m. UTC | #1 
On Wed, Aug 16, 2017 at 10:31:01PM +0200, snawrocki@kernel.org wrote:
> From: Sylwester Nawrocki <snawrocki@kernel.org>
> 
> After commit e9f66ae23c "mtd: s3c2410: make ecc mode configurable
> via platform data" booting of the mini2440 board is broken, since
> for this board we have CONFIG_MTD_NAND_S3C2410_HWECC set. The console
> gets flooded with errors reported by the mtd subsystem.
> This patch changes ecc_mode to NAND_ECC_HW which restores proper
> operation of the NAND flash memory.
> 
> Cc: Sergio Prado <sergio.prado@e-labworks.com>
> Fixes: e9f66ae23c "mtd: s3c2410: make ecc mode configurable via platform data"

Thanks, applied for next cycle. Please do not forget about checkpatch -
he would point about wrong format of commit SHA and fixes tag (too short
SHA and missing ()).

Best regards,
Krzysztof
diff mbox

Patch

diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c
index 98bff4b..3e75efd 100644
--- a/arch/arm/mach-s3c24xx/mach-mini2440.c
+++ b/arch/arm/mach-s3c24xx/mach-mini2440.c
@@ -289,7 +289,7 @@ 
 	.nr_sets	= ARRAY_SIZE(mini2440_nand_sets),
 	.sets		= mini2440_nand_sets,
 	.ignore_unset_ecc = 1,
-	.ecc_mode       = NAND_ECC_SOFT,
+	.ecc_mode       = NAND_ECC_HW,
 };
 
 /* DM9000AEP 10/100 ethernet controller */