| Message ID | 1503389282-17369-1-git-send-email-bhumirks@gmail.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hello! On 08/22/2017 11:08 AM, Bhumika Goyal wrote: > Make these const as they are only stored in a const field of a > mdiobb_ctrl structure. > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> > --- > drivers/net/ethernet/renesas/ravb_main.c | 2 +- > drivers/net/ethernet/renesas/sh_eth.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) If you're fixing both Renesas drivers at once, your subject should be "renesas: make mdiobb_ops const". With that fixed, you have my: Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> MBR, Sergei
On Tue, Aug 22, 2017 at 2:03 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 08/22/2017 11:08 AM, Bhumika Goyal wrote: >> Make these const as they are only stored in a const field of a >> mdiobb_ctrl structure. > >> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> >> --- >> drivers/net/ethernet/renesas/ravb_main.c | 2 +- >> drivers/net/ethernet/renesas/sh_eth.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) > > If you're fixing both Renesas drivers at once, your subject should be > "renesas: make mdiobb_ops const". With that fixed, you have my: "net: renesas: make mdiobb_ops const"? There are plenty of other Renesas-specific drivers spread all over the tree. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index fdf30bf..6ffd9e4 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -172,7 +172,7 @@ static int ravb_get_mdio_data(struct mdiobb_ctrl *ctrl) } /* MDIO bus control struct */ -static struct mdiobb_ops bb_ops = { +static const struct mdiobb_ops bb_ops = { .owner = THIS_MODULE, .set_mdc = ravb_set_mdc, .set_mdio_dir = ravb_set_mdio_dir, diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index d2e88a3..8af353f 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -1119,7 +1119,7 @@ static void sh_mdc_ctrl(struct mdiobb_ctrl *ctrl, int bit) } /* mdio bus control struct */ -static struct mdiobb_ops bb_ops = { +static const struct mdiobb_ops bb_ops = { .owner = THIS_MODULE, .set_mdc = sh_mdc_ctrl, .set_mdio_dir = sh_mmd_ctrl,
Make these const as they are only stored in a const field of a mdiobb_ctrl structure. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)