| Message ID | 20170801110101.mf2i5e2mes4ftmkj@mwanda (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote: > The code works as intended, but the indenting is confusing. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> You didn't include netdev on this patch, and I haven't seen a note from janitors that they took it, so I decided to send it on through. It's minor enough it shouldn't be an issue conflicting with Dave's tree I would think. I'll know I was wrong if I get yelled at. > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c > b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c > index 28d8472b36f1..c410360da58d 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c > @@ -113,7 +113,7 @@ static int mlx5_device_enable_sriov(struct > mlx5_core_dev *dev, int num_vfs) > mlx5_core_warn(dev, > "failed to restore VF > %d settings, err %d\n", > vf, err); > - continue; > + continue; > } > } > mlx5_core_dbg(dev, "successfully enabled VF* %d\n", > vf); > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 28, 2017 at 07:09:47PM -0400, Doug Ledford wrote: > On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote: > > The code works as intended, but the indenting is confusing. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > You didn't include netdev on this patch, and I haven't seen a note from > janitors that they took it, so I decided to send it on through. It's > minor enough it shouldn't be an issue conflicting with Dave's tree I > would think. I'll know I was wrong if I get yelled at. > Ooo... Wow. Don't do that. You're going to get me yelled at too. I guess I thought this went through the RDMA tree but looking at it now it's obvioulsy net. regards, dan carpetner -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2017-08-29 at 12:14 +0300, Dan Carpenter wrote: > On Mon, Aug 28, 2017 at 07:09:47PM -0400, Doug Ledford wrote: > > On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote: > > > The code works as intended, but the indenting is confusing. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > > > You didn't include netdev on this patch, and I haven't seen a note > > from > > janitors that they took it, so I decided to send it on > > through. It's > > minor enough it shouldn't be an issue conflicting with Dave's tree > > I > > would think. I'll know I was wrong if I get yelled at. > > > > Ooo... Wow. Don't do that. You're going to get me yelled at too. > > I guess I thought this went through the RDMA tree but looking at it > now > it's obvioulsy net. Fortunately for us, I only pushed this to github last night, so I can still drop this out of my branch before pushing to k.o. I'll let you submit it to the proper place :-) --- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c index 28d8472b36f1..c410360da58d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c @@ -113,7 +113,7 @@ static int mlx5_device_enable_sriov(struct mlx5_core_dev *dev, int num_vfs) mlx5_core_warn(dev, "failed to restore VF %d settings, err %d\n", vf, err); - continue; + continue; } } mlx5_core_dbg(dev, "successfully enabled VF* %d\n", vf);
The code works as intended, but the indenting is confusing. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html