| Message ID | 20170830082702.3011-4-Sergio.G.DelReal@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 30, 2017 at 03:26:52AM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds to target/i386/Makefile.objs the necessary rules so > that the new files for hvf are compiled by the build system. > It also adds handling of the -enable-hvf argument in the main function > in vl.c. > > Signed-off-by: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com> > --- > target/i386/Makefile.objs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/i386/Makefile.objs b/target/i386/Makefile.objs > index 6a26e9d9f0..0bef89c099 100644 > --- a/target/i386/Makefile.objs > +++ b/target/i386/Makefile.objs > @@ -12,4 +12,5 @@ obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-windows.o > endif > ifdef CONFIG_DARWIN > obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-darwin.o > +obj-$(CONFIG_HVF) += hvf-utils/ hvf-all.o > endif After this commit: make[1]: *** No rule to make target 'target/i386/hvf-all.o', needed by 'qemu-system-x86_64'. Stop. Please structure patch series so that each commit compiles and passes tests successfully. This is important so that git-bisect(1) can be used. If some commits break the build then it's hard to bisect because you need to diagnose each failure and decide how to bisect around it. This code change must be included in the same commit that adds hvf-all.o and hvf-utils/ files. Stefan
On Wed, Aug 30, 2017 at 03:26:52AM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds to target/i386/Makefile.objs the necessary rules so > that the new files for hvf are compiled by the build system. > It also adds handling of the -enable-hvf argument in the main function > in vl.c. > > Signed-off-by: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com> > --- > target/i386/Makefile.objs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/i386/Makefile.objs b/target/i386/Makefile.objs > index 6a26e9d9f0..0bef89c099 100644 > --- a/target/i386/Makefile.objs > +++ b/target/i386/Makefile.objs > @@ -12,4 +12,5 @@ obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-windows.o > endif > ifdef CONFIG_DARWIN > obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-darwin.o > +obj-$(CONFIG_HVF) += hvf-utils/ hvf-all.o > endif I just noticed that the entire patch series hasn't arrived in my inbox yet. Maybe Patch 2/13 adds the missing code. In that case you can ignore my reply :).
diff --git a/target/i386/Makefile.objs b/target/i386/Makefile.objs index 6a26e9d9f0..0bef89c099 100644 --- a/target/i386/Makefile.objs +++ b/target/i386/Makefile.objs @@ -12,4 +12,5 @@ obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-windows.o endif ifdef CONFIG_DARWIN obj-$(CONFIG_HAX) += hax-all.o hax-mem.o hax-darwin.o +obj-$(CONFIG_HVF) += hvf-utils/ hvf-all.o endif
This commit adds to target/i386/Makefile.objs the necessary rules so that the new files for hvf are compiled by the build system. It also adds handling of the -enable-hvf argument in the main function in vl.c. Signed-off-by: Sergio Andres Gomez Del Real <Sergio.G.DelReal@gmail.com> --- target/i386/Makefile.objs | 1 + 1 file changed, 1 insertion(+)