diff mbox

scsi: ufs: reqs and tasks were put in the wrong order

Message ID 20170824025715.98737-1-zangleigang@hisilicon.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Zang Leigang Aug. 24, 2017, 2:57 a.m. UTC 
Signed-off-by: Zang Leigang <zangleigang@hisilicon.com>

Comments

Martin K. Petersen Aug. 24, 2017, 3:29 a.m. UTC | #1 
Zang,

Applied to 4.14/scsi-queue. Thank you!
Avri Altman Aug. 30, 2017, 1:44 p.m. UTC | #2 
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> owner@vger.kernel.org] On Behalf Of Zang Leigang
> Sent: Thursday, August 24, 2017 5:57 AM
> To: vinholikatti@gmail.com; jejb@linux.vnet.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org
> Subject: [PATCH] scsi: ufs: reqs and tasks were put in the wrong order
> 
> Signed-off-by: Zang Leigang <zangleigang@hisilicon.com>
Acked-by: Avri Altman <avri.altman@sandisk.com>

> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> 5bc9dc14e075..794a4600e952 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -438,7 +438,7 @@ static void ufshcd_print_host_state(struct ufs_hba
> *hba)  {
>  	dev_err(hba->dev, "UFS Host state=%d\n", hba->ufshcd_state);
>  	dev_err(hba->dev, "lrb in use=0x%lx, outstanding reqs=0x%lx
> tasks=0x%lx\n",
> -		hba->lrb_in_use, hba->outstanding_tasks, hba-
> >outstanding_reqs);
> +		hba->lrb_in_use, hba->outstanding_reqs, hba-
> >outstanding_tasks);
>  	dev_err(hba->dev, "saved_err=0x%x, saved_uic_err=0x%x\n",
>  		hba->saved_err, hba->saved_uic_err);
>  	dev_err(hba->dev, "Device power mode=%d, UIC link state=%d\n",
> --
> 2.14.1
diff mbox

Patch

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 5bc9dc14e075..794a4600e952 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -438,7 +438,7 @@  static void ufshcd_print_host_state(struct ufs_hba *hba)
 {
 	dev_err(hba->dev, "UFS Host state=%d\n", hba->ufshcd_state);
 	dev_err(hba->dev, "lrb in use=0x%lx, outstanding reqs=0x%lx tasks=0x%lx\n",
-		hba->lrb_in_use, hba->outstanding_tasks, hba->outstanding_reqs);
+		hba->lrb_in_use, hba->outstanding_reqs, hba->outstanding_tasks);
 	dev_err(hba->dev, "saved_err=0x%x, saved_uic_err=0x%x\n",
 		hba->saved_err, hba->saved_uic_err);
 	dev_err(hba->dev, "Device power mode=%d, UIC link state=%d\n",