| Message ID | 20170908163929.9277-1-sthemmin@microsoft.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote: > The Linus policy on Kconfig is that the default should be no > for all new devices. I.e the user rebuild a new kernel from an > old config should not by default get a larger kernel. That might make sense for new config, but RC_CORE has been present for 7 years; I don't see how changing defaults for existing config makes sense. Sean > > Fixes: b4c184e506a4 ("[media] media: reorganize the main Kconfig items") > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> > --- > drivers/media/rc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig > index d9ce8ff55d0c..5aa384afcfef 100644 > --- a/drivers/media/rc/Kconfig > +++ b/drivers/media/rc/Kconfig > @@ -2,7 +2,7 @@ > menuconfig RC_CORE > tristate "Remote Controller support" > depends on INPUT > - default y > + default n > ---help--- > Enable support for Remote Controllers on Linux. This is > needed in order to support several video capture adapters, > -- > 2.11.0
On Fri, 8 Sep 2017 19:52:47 +0100 Sean Young <sean@mess.org> wrote: > On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote: > > The Linus policy on Kconfig is that the default should be no > > for all new devices. I.e the user rebuild a new kernel from an > > old config should not by default get a larger kernel. > > That might make sense for new config, but RC_CORE has been present for > 7 years; I don't see how changing defaults for existing config makes > sense. > I took existing config for 4.13 and did 'make oldconfig' and just hitting return caused it to turned on. The problem is that in my config media is disabled, and now your new reconfiguration makes RC_CORE not dependent on media. It is a common problem, developers never test with their subsystem disabled.
Em Fri, 8 Sep 2017 12:06:48 -0700 Stephen Hemminger <stephen@networkplumber.org> escreveu: > On Fri, 8 Sep 2017 19:52:47 +0100 > Sean Young <sean@mess.org> wrote: > > > On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote: > > > The Linus policy on Kconfig is that the default should be no > > > for all new devices. I.e the user rebuild a new kernel from an > > > old config should not by default get a larger kernel. > > > > That might make sense for new config, but RC_CORE has been present for > > 7 years; I don't see how changing defaults for existing config makes > > sense. > > > > I took existing config for 4.13 and did 'make oldconfig' and just > hitting return caused it to turned on. > > The problem is that in my config media is disabled, and now your new > reconfiguration makes RC_CORE not dependent on media. > > It is a common problem, developers never test with their subsystem disabled. Hi Sean, Yes, it makes sense to default 'n' for RC_CORE now that this is an independent menu option and it builds the RC core when enabled. Regards, Mauro
On Fri, Sep 8, 2017 at 6:39 PM, Stephen Hemminger <stephen@networkplumber.org> wrote: > The Linus policy on Kconfig is that the default should be no > for all new devices. I.e the user rebuild a new kernel from an > old config should not by default get a larger kernel. > > Fixes: b4c184e506a4 ("[media] media: reorganize the main Kconfig items") > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> > --- > drivers/media/rc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig > index d9ce8ff55d0c..5aa384afcfef 100644 > --- a/drivers/media/rc/Kconfig > +++ b/drivers/media/rc/Kconfig > @@ -2,7 +2,7 @@ > menuconfig RC_CORE > tristate "Remote Controller support" > depends on INPUT > - default y > + default n "default n" is the default, so you can just drop this line. For the principle: Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig index d9ce8ff55d0c..5aa384afcfef 100644 --- a/drivers/media/rc/Kconfig +++ b/drivers/media/rc/Kconfig @@ -2,7 +2,7 @@ menuconfig RC_CORE tristate "Remote Controller support" depends on INPUT - default y + default n ---help--- Enable support for Remote Controllers on Linux. This is needed in order to support several video capture adapters,
The Linus policy on Kconfig is that the default should be no for all new devices. I.e the user rebuild a new kernel from an old config should not by default get a larger kernel. Fixes: b4c184e506a4 ("[media] media: reorganize the main Kconfig items") Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> --- drivers/media/rc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)