| Message ID | d946c138dc7d9657e986bfe37d255a595ad1671c.1505774663.git.chiranjeevi.rapolu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Chiranjeevi, On Tue, Sep 19, 2017 at 7:47 AM, Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> wrote: > Previously, with crop (0, 0), (4255, 3167), VTS < 0xC9E was resulting in blank > frames sometimes. This appeared as video flickering. But we need VTS < 0xC9E to > get ~30fps. > > Omni Vision recommends to use crop (0,8), (4255, 3159) for 4224x3136. With this > crop, VTS 0xC8E is supported and yields ~30fps. > > Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> > --- > Changes in v2: > - Include Tomasz clarifications in the commit message. Thanks for explanation. It makes perfect sense now. Reviewed-by: Tomasz Figa <tfiga@chromium.org> Best regards, Tomasz
On Tue, Sep 19, 2017 at 01:32:27PM +0900, Tomasz Figa wrote: > Hi Chiranjeevi, > > On Tue, Sep 19, 2017 at 7:47 AM, Chiranjeevi Rapolu > <chiranjeevi.rapolu@intel.com> wrote: > > Previously, with crop (0, 0), (4255, 3167), VTS < 0xC9E was resulting in blank > > frames sometimes. This appeared as video flickering. But we need VTS < 0xC9E to > > get ~30fps. > > > > Omni Vision recommends to use crop (0,8), (4255, 3159) for 4224x3136. With this > > crop, VTS 0xC8E is supported and yields ~30fps. > > > > Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> > > --- > > Changes in v2: > > - Include Tomasz clarifications in the commit message. > > Thanks for explanation. It makes perfect sense now. > > Reviewed-by: Tomasz Figa <tfiga@chromium.org> Thanks, applied! Chiranjeevi: please wrap the commit message at 75 on the next time.
diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c index af7af0d..f7c5771 100644 --- a/drivers/media/i2c/ov13858.c +++ b/drivers/media/i2c/ov13858.c @@ -238,11 +238,11 @@ struct ov13858_mode { {0x3800, 0x00}, {0x3801, 0x00}, {0x3802, 0x00}, - {0x3803, 0x00}, + {0x3803, 0x08}, {0x3804, 0x10}, {0x3805, 0x9f}, {0x3806, 0x0c}, - {0x3807, 0x5f}, + {0x3807, 0x57}, {0x3808, 0x10}, {0x3809, 0x80}, {0x380a, 0x0c},
Previously, with crop (0, 0), (4255, 3167), VTS < 0xC9E was resulting in blank frames sometimes. This appeared as video flickering. But we need VTS < 0xC9E to get ~30fps. Omni Vision recommends to use crop (0,8), (4255, 3159) for 4224x3136. With this crop, VTS 0xC8E is supported and yields ~30fps. Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> --- Changes in v2: - Include Tomasz clarifications in the commit message. drivers/media/i2c/ov13858.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)