diff mbox

arm64: Always use REFCOUNT_FULL

Message ID 20170920204959.GA79741@beast (mailing list archive)
State New, archived
Headers show

Commit Message

Kees Cook Sept. 20, 2017, 8:49 p.m. UTC
As discussed at the Linux Security Summit, arm64 prefers to use
REFCOUNT_FULL by default. This enables it for the architecture.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: hw.likun@huawei.com
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 arch/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Ard Biesheuvel Sept. 20, 2017, 10:44 p.m. UTC | #1
On 20 September 2017 at 13:49, Kees Cook <keescook@chromium.org> wrote:
> As discussed at the Linux Security Summit, arm64 prefers to use
> REFCOUNT_FULL by default. This enables it for the architecture.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: hw.likun@huawei.com
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


> ---
>  arch/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 0df64a6a56d4..9fe7a7f4c94c 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -119,6 +119,7 @@ config ARM64
>         select PCI_ECAM if ACPI
>         select POWER_RESET
>         select POWER_SUPPLY
> +       select REFCOUNT_FULL
>         select SPARSE_IRQ
>         select SYSCTL_EXCEPTION_TRACE
>         select THREAD_INFO_IN_TASK
> --
> 2.7.4
>
>
> --
> Kees Cook
> Pixel Security
Al Viro Sept. 21, 2017, 5:45 p.m. UTC | #2
On Wed, Sep 20, 2017 at 01:49:59PM -0700, Kees Cook wrote:
> As discussed at the Linux Security Summit, arm64 prefers to use
> REFCOUNT_FULL by default. This enables it for the architecture.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: hw.likun@huawei.com
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  arch/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 0df64a6a56d4..9fe7a7f4c94c 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -119,6 +119,7 @@ config ARM64
>  	select PCI_ECAM if ACPI
>  	select POWER_RESET
>  	select POWER_SUPPLY
> +	select REFCOUNT_FULL

Umm...  That does a bit more than "on by default", unless I'm
misreading it.  More like "on, and you can't opt out"...
Kees Cook Sept. 21, 2017, 5:52 p.m. UTC | #3
On Thu, Sep 21, 2017 at 10:45 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Wed, Sep 20, 2017 at 01:49:59PM -0700, Kees Cook wrote:
>> As discussed at the Linux Security Summit, arm64 prefers to use
>> REFCOUNT_FULL by default. This enables it for the architecture.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: hw.likun@huawei.com
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will.deacon@arm.com>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>>  arch/arm64/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 0df64a6a56d4..9fe7a7f4c94c 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -119,6 +119,7 @@ config ARM64
>>       select PCI_ECAM if ACPI
>>       select POWER_RESET
>>       select POWER_SUPPLY
>> +     select REFCOUNT_FULL
>
> Umm...  That does a bit more than "on by default", unless I'm
> misreading it.  More like "on, and you can't opt out"...

True, I should rephrase it to say "arm64 maintainers perfer to use
REFCOUNT_FULL unconditionally".

-Kees
diff mbox

Patch

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 0df64a6a56d4..9fe7a7f4c94c 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -119,6 +119,7 @@  config ARM64
 	select PCI_ECAM if ACPI
 	select POWER_RESET
 	select POWER_SUPPLY
+	select REFCOUNT_FULL
 	select SPARSE_IRQ
 	select SYSCTL_EXCEPTION_TRACE
 	select THREAD_INFO_IN_TASK