[RFC,4/4] ndctl: nvdimmd: notify/monitor the feathers of over threshold event

Commit Message

QI Fuli Sept. 1, 2017, 1:49 a.m. UTC

Notify.c is used to call the emulation of event of over threshold.
You can test nvdimm daemon with the following command.

 notify [nmemX] [all]

Signed-off-by: QI Fuli <[e-mail]>

---
nvdimmd/Makefile |   6 ++-
nvdimmd/notify.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 119 insertions(+), 1 deletion(-)
+}

--
QI Fuli <[e-mail]>

Comments

Dan Williams Sept. 23, 2017, 5:24 p.m. UTC | #1

On Thu, Aug 31, 2017 at 6:49 PM, Qi, Fuli <[e-mail]> wrote:
> Notify.c is used to call the emulation of event of over threshold.
> You can test nvdimm daemon with the following command.
>
>  notify [nmemX] [all]

Let's make this an ndctl command... in fact this is a good candidate
of something to add to the "inject-error" command that Vishal is
developing.

Patch

diff --git a/nvdimmd/Makefile b/nvdimmd/Makefile
index df7eb46..9fb37ec 100644
--- a/nvdimmd/Makefile
+++ b/nvdimmd/Makefile
@@ -3,7 +3,7 @@  LIBS		= -ludev -luuid -lkmod
 DEST		= /usr/bin
 OBJS		= ../ndctl/lib/.libs/libndctl.o ../daxctl/lib/.libs/libdaxctl.o ../util/.libs/sysfs.o ../util/.libs/log.o ../ndctl/lib/.libs/libndctl-smart.o
 IDIR		= -I../ -I../ndctl
-PROGRAM	= nvdimmd
+PROGRAM	= nvdimmd notify
 
 all:		$(PROGRAM)
 nvdimmd:	$(OBJS) nvdimmd.o libnvdimmd.o
@@ -12,6 +12,10 @@  libnvdimmd.o:	libnvdimmd.c
 			$(CC) -o libnvdimmd.o $(IDIR) -c libnvdimmd.c
 nvdimmd.o:	nvdimmd.c
 			$(CC) -o nvdimmd.o $(IDIR) -c nvdimmd.c
+notify:		$(OBJS) notify.o libnvdimmd.o
+			$(CC) $(OBJS) notify.o libnvdimmd.o $(LIBS) $(IDIR) -o notify
+notify.o:	notify.c
+			$(CC) -o notify.o $(IDIR) -c notify.c
 install:	nvdimmd nvdimmd.service
 			install -s nvdimmd $(DEST)
 			cp nvdimmd.service /usr/lib/systemd/system/
diff --git a/nvdimmd/notify.c b/nvdimmd/notify.c
new file mode 100644
index 0000000..f83e60d
--- /dev/null
+++ b/nvdimmd/notify.c
@@ -0,0 +1,113 @@ 
+/*
+ * Copyright (c) 2017, FUJITSU LIMITED. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU Lesser General Public License,
+ * version 2.1, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT ANY
+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for
+ * more details.
+ */
+
+/*
+ * This program is used to call the emulation of event of over threshold.
+ * You can test nvdimmd daemon with the following command.
+ *  notify [nmemX] [all]
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <string.h>
+#include <sys/stat.h>
+#include <syslog.h>
+#include <ndctl/libndctl.h>
+#include "libnvdimmd.h"
+
+const char *notify_help_info = "notify [nmemX] [all]";
+
+static int notify_submit_cmd(threshold_dimm *t_dimm)
+{
+	struct ndctl_cmd *cmd;
+	const char *msg = "command to call over threshold event notification: ";
+
+	cmd = ndctl_dimm_cmd_new_smart_threshold(t_dimm->dimm);
+	if (!cmd) {
+		printf("failed to prepare %s[%s]\n", msg, t_dimm->devname);
+		return -1;
+	}
+	if(ndctl_cmd_submit(cmd)) {
+		printf("failed to submit %s[%s]\n", msg, t_dimm->devname);
+		return -1;
+	}
+	ndctl_cmd_unref(cmd);
+	return 0;
+}
+
+static int
+notify_submit(threshold_dimm *t_dimm, int count_dimm, char *notify_devname)
+{
+	int count_notify = 0;
+
+	for (int i= 0; i < count_dimm; i++) {
+		if (!strcmp(notify_devname, "all")) {
+			if (!notify_submit_cmd(&t_dimm[i]))
+				count_notify++;
+			continue;
+		}
+		if (!strcmp(notify_devname, t_dimm[i].devname)) {
+			if (!notify_submit_cmd(&t_dimm[i]))
+				count_notify++;
+			else
+				count_notify--;
+			break;
+		}
+	}
+	return count_notify;
+}
+
+int main(int argc, char *argv[])
+{
+	struct ndctl_ctx *ctx;
+	int rc, count_dimm;
+	char *notify_devname;
+	threshold_dimm *t_dimm;
+
+	if (argc < 1) {
+		printf("usage: %s\n", notify_help_info);
+		goto out;
+	}
+
+	notify_devname = argv[1];
+	if (!notify_devname || !strcmp(notify_devname, "--help")){
+		printf("usage: %s\n", notify_help_info);
+		goto out;
+	}
+	rc = ndctl_new(&ctx);
+	if (rc)
+		goto out;
+
+	t_dimm = calloc(NUM_MAX_DIMM, sizeof(threshold_dimm));
+	if (!t_dimm) {
+		printf("notify error: memory not allocate\n");
+		goto out;
+	}
+
+	count_dimm = get_threshold_dimm(ctx, t_dimm, NULL, NULL);
+	if (count_dimm == 0) {
+		printf("notify error: no dimm support over threshold notify\n");
+		goto out;
+	}
+
+	rc = notify_submit(t_dimm, count_dimm, notify_devname);
+
+	if (!rc && strcmp(notify_devname, "all"))
+		printf("UNKNOWM DIMM_NAME\n");
+	else if (rc >= 0)
+		printf("%d notify submit: [%s]\n", rc, notify_devname);
+
+	ndctl_unref(ctx);
+out:
+	return 1;