| Message ID | 1505305119-4257-3-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4503b50eac08f472e8690ec61f4d144e62cbdc55 |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Shimoda-san, On Wed, Sep 13, 2017 at 2:18 PM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > This patch enables EthernetAVB for R-Car D3 draak board. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -37,6 +39,14 @@ > }; > > &pfc { > + avb0_pins: avb { > + mux { > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > + "avb0_mii"; > + function = "avb0"; This part depends on (an updated version of) "[PATCH 5/8] pinctrl: sh-pfc: r8a77995: Add EthernetAVB pins, groups and functions", so it may change? And we will probably have to add driver-strengths later, to avoid a dependency on bootloader setup? Apart from that: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, > From: Geert Uytterhoeven > Sent: Wednesday, September 13, 2017 11:55 PM > > Hi Shimoda-san, > > On Wed, Sep 13, 2017 at 2:18 PM, Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > @@ -37,6 +39,14 @@ > > }; > > > > &pfc { > > + avb0_pins: avb { > > + mux { > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > + "avb0_mii"; > > + function = "avb0"; > > This part depends on (an updated version of) "[PATCH 5/8] pinctrl: sh-pfc: > r8a77995: Add EthernetAVB pins, groups and functions", so it may change? Oops, I fotgot to submit v2 PFC patch yesterday... Yes, it is changed like other gen3 SoCs. I submitted it now. > And we will probably have to add driver-strengths later, to avoid a > dependency on bootloader setup? Yes, I will do so, if needed. > Apart from that: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for your review! Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Simon-san, > From: Simon Horman > Sent: Friday, September 15, 2017 4:35 PM > > On Wed, Sep 13, 2017 at 11:58:47PM +0000, Yoshihiro Shimoda wrote: > > Hi Geert-san, > > > > > From: Geert Uytterhoeven > > > Sent: Wednesday, September 13, 2017 11:55 PM > > > > > > Hi Shimoda-san, > > > > > > On Wed, Sep 13, 2017 at 2:18 PM, Yoshihiro Shimoda > > > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > Thanks for your patch! > > > > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > > > @@ -37,6 +39,14 @@ > > > > }; > > > > > > > > &pfc { > > > > + avb0_pins: avb { > > > > + mux { > > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > > > + "avb0_mii"; > > > > + function = "avb0"; > > > > > > This part depends on (an updated version of) "[PATCH 5/8] pinctrl: sh-pfc: > > > r8a77995: Add EthernetAVB pins, groups and functions", so it may change? > > > > Oops, I fotgot to submit v2 PFC patch yesterday... > > Yes, it is changed like other gen3 SoCs. I submitted it now. > > > > > And we will probably have to add driver-strengths later, to avoid a > > > dependency on bootloader setup? > > > > Yes, I will do so, if needed. > > > > > Apart from that: > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Thank you for your review! > > Thanks. I have marked this as "Deferred" pending acceptance of the PFC > patch. Please repost or ping me, f.e. via a reply-to-all to this email, > once that dependency is resolved. Since the PFC patch is applied into renesas-drivers.git / sh-pfc-for-v4.15 branch, I'd like to ping you :) https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=sh-pfc-for-v4.15&id=66abd968d0ef3eb10dea45b48a31321eb29258f8 Or, should I rebase this patch on latest devel tag? If so, I will rebase it in next Monday because I'll take a day off tomorrow. Best regards, Yoshihiro Shimoda
On Thu, Sep 21, 2017 at 10:37:15AM +0000, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman > > Sent: Friday, September 15, 2017 4:35 PM > > > > On Wed, Sep 13, 2017 at 11:58:47PM +0000, Yoshihiro Shimoda wrote: > > > Hi Geert-san, > > > > > > > From: Geert Uytterhoeven > > > > Sent: Wednesday, September 13, 2017 11:55 PM > > > > > > > > Hi Shimoda-san, > > > > > > > > On Wed, Sep 13, 2017 at 2:18 PM, Yoshihiro Shimoda > > > > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > > > Thanks for your patch! > > > > > > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > > > > > @@ -37,6 +39,14 @@ > > > > > }; > > > > > > > > > > &pfc { > > > > > + avb0_pins: avb { > > > > > + mux { > > > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > > > > + "avb0_mii"; > > > > > + function = "avb0"; > > > > > > > > This part depends on (an updated version of) "[PATCH 5/8] pinctrl: sh-pfc: > > > > r8a77995: Add EthernetAVB pins, groups and functions", so it may change? > > > > > > Oops, I fotgot to submit v2 PFC patch yesterday... > > > Yes, it is changed like other gen3 SoCs. I submitted it now. > > > > > > > And we will probably have to add driver-strengths later, to avoid a > > > > dependency on bootloader setup? > > > > > > Yes, I will do so, if needed. > > > > > > > Apart from that: > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > Thank you for your review! > > > > Thanks. I have marked this as "Deferred" pending acceptance of the PFC > > patch. Please repost or ping me, f.e. via a reply-to-all to this email, > > once that dependency is resolved. > > Since the PFC patch is applied into renesas-drivers.git / sh-pfc-for-v4.15 branch, > I'd like to ping you :) > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=sh-pfc-for-v4.15&id=66abd968d0ef3eb10dea45b48a31321eb29258f8 > > Or, should I rebase this patch on latest devel tag? > If so, I will rebase it in next Monday because I'll take a day off tomorrow. Thanks for pinging me. I have applied this patch. There was some fuzz when doing so. Please check that the applied patch is correct once I have pushed an updated devel branch later today.
Hi Simon-san, > From: Simon Horman > Sent: Monday, September 25, 2017 4:08 PM > > On Thu, Sep 21, 2017 at 10:37:15AM +0000, Yoshihiro Shimoda wrote: > > Hi Simon-san, > > > > > From: Simon Horman > > > Sent: Friday, September 15, 2017 4:35 PM > > > > > > On Wed, Sep 13, 2017 at 11:58:47PM +0000, Yoshihiro Shimoda wrote: > > > > Hi Geert-san, > > > > > > > > > From: Geert Uytterhoeven > > > > > Sent: Wednesday, September 13, 2017 11:55 PM > > > > > > > > > > Hi Shimoda-san, > > > > > > > > > > On Wed, Sep 13, 2017 at 2:18 PM, Yoshihiro Shimoda > > > > > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > > > > This patch enables EthernetAVB for R-Car D3 draak board. > > > > > > > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > > > > > > > Thanks for your patch! > > > > > > > > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > > > > > > > > > @@ -37,6 +39,14 @@ > > > > > > }; > > > > > > > > > > > > &pfc { > > > > > > + avb0_pins: avb { > > > > > > + mux { > > > > > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", > > > > > > + "avb0_mii"; > > > > > > + function = "avb0"; > > > > > > > > > > This part depends on (an updated version of) "[PATCH 5/8] pinctrl: sh-pfc: > > > > > r8a77995: Add EthernetAVB pins, groups and functions", so it may change? > > > > > > > > Oops, I fotgot to submit v2 PFC patch yesterday... > > > > Yes, it is changed like other gen3 SoCs. I submitted it now. > > > > > > > > > And we will probably have to add driver-strengths later, to avoid a > > > > > dependency on bootloader setup? > > > > > > > > Yes, I will do so, if needed. > > > > > > > > > Apart from that: > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > > > Thank you for your review! > > > > > > Thanks. I have marked this as "Deferred" pending acceptance of the PFC > > > patch. Please repost or ping me, f.e. via a reply-to-all to this email, > > > once that dependency is resolved. > > > > Since the PFC patch is applied into renesas-drivers.git / sh-pfc-for-v4.15 branch, > > I'd like to ping you :) > > > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=sh-pfc-for-v4.15&id=66abd968d0ef > 3eb10dea45b48a31321eb29258f8 > > > > Or, should I rebase this patch on latest devel tag? > > If so, I will rebase it in next Monday because I'll take a day off tomorrow. > > Thanks for pinging me. I have applied this patch. > There was some fuzz when doing so. Please check that the applied > patch is correct once I have pushed an updated devel branch later today. Thank you for applying! I checked renesas.git / renesas-devel-20170925-v4.14-rc2 tag, and it's correct. Best regards, Yoshihiro Shimoda
On Wed, Sep 27, 2017 at 02:03:14AM +0000, Yoshihiro Shimoda wrote: > Hi Simon-san, > > From: Simon Horman > > Sent: Monday, September 25, 2017 4:08 PM > > On Thu, Sep 21, 2017 at 10:37:15AM +0000, Yoshihiro Shimoda wrote: > > > Hi Simon-san, > > > > From: Simon Horman > > > > Sent: Friday, September 15, 2017 4:35 PM ... > > > > Thanks. I have marked this as "Deferred" pending acceptance of the PFC > > > > patch. Please repost or ping me, f.e. via a reply-to-all to this email, > > > > once that dependency is resolved. > > > > > > Since the PFC patch is applied into renesas-drivers.git / sh-pfc-for-v4.15 branch, > > > I'd like to ping you :) > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=sh-pfc-for-v4.15&id=66abd968d0ef > > 3eb10dea45b48a31321eb29258f8 > > > > > > Or, should I rebase this patch on latest devel tag? > > > If so, I will rebase it in next Monday because I'll take a day off tomorrow. > > > > Thanks for pinging me. I have applied this patch. > > There was some fuzz when doing so. Please check that the applied > > patch is correct once I have pushed an updated devel branch later today. > > Thank you for applying! > I checked renesas.git / renesas-devel-20170925-v4.14-rc2 tag, and it's correct. Thanks for checking, much appreciated.
diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index 19c5462..9c5a790 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts @@ -11,6 +11,7 @@ /dts-v1/; #include "r8a77995.dtsi" +#include <dt-bindings/gpio/gpio.h> / { model = "Renesas Draak board based on r8a77995"; @@ -18,6 +19,7 @@ aliases { serial0 = &scif2; + ethernet0 = &avb; }; chosen { @@ -37,6 +39,14 @@ }; &pfc { + avb0_pins: avb { + mux { + groups = "avb0_link", "avb0_phy_int", "avb0_mdc", + "avb0_mii"; + function = "avb0"; + }; + }; + scif2_pins: scif2 { groups = "scif2_data"; function = "scif2"; @@ -44,6 +54,21 @@ }; +&avb { + pinctrl-0 = <&avb0_pins>; + pinctrl-names = "default"; + renesas,no-ether-link; + phy-handle = <&phy0>; + status = "okay"; + + phy0: ethernet-phy@0 { + rxc-skew-ps = <1500>; + reg = <0>; + interrupt-parent = <&gpio5>; + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; + }; +}; + &scif2 { pinctrl-0 = <&scif2_pins>; pinctrl-names = "default";
This patch enables EthernetAVB for R-Car D3 draak board. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)