| Message ID | 20170925103038.lvr5msjvekwczctn@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 25, 2017 at 12:30 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The callers expect "panel" to be initialized, but that isn't true if we > return -ENODEV. It causes bugs like: > > drivers/gpu/drm/tve200/tve200_drv.c:83 tve200_modeset_init() > error: uninitialized symbol 'panel'. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> I am travelling right now but will apply the patch on monday in one week from now. Yours, Linus Walleij
On Mon, Sep 25, 2017 at 12:30 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The callers expect "panel" to be initialized, but that isn't true if we > return -ENODEV. It causes bugs like: > > drivers/gpu/drm/tve200/tve200_drv.c:83 tve200_modeset_init() > error: uninitialized symbol 'panel'. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index 8dafbdfcd2ea..4c191c050e7d 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -233,6 +233,8 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, if (!panel && !bridge) return -EINVAL; + if (panel) + *panel = NULL; remote = of_graph_get_remote_node(np, port, endpoint); if (!remote)
The callers expect "panel" to be initialized, but that isn't true if we return -ENODEV. It causes bugs like: drivers/gpu/drm/tve200/tve200_drv.c:83 tve200_modeset_init() error: uninitialized symbol 'panel'. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>