diff mbox

Input: sa1111ps2 - extend test delay

Message ID E1dwsgD-0006Hy-5u@rmk-PC.armlinux.org.uk (mailing list archive)
State Accepted
Headers show

Commit Message

Russell King (Oracle) Sept. 26, 2017, 4:25 p.m. UTC 
A 2us delay is too small for the bus to settle after writing to the
register.  Extend to 10us which gives more reliable results.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/input/serio/sa1111ps2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Sept. 26, 2017, 4:57 p.m. UTC | #1 
On Tue, Sep 26, 2017 at 05:25:53PM +0100, Russell King wrote:
> A 2us delay is too small for the bus to settle after writing to the
> register.  Extend to 10us which gives more reliable results.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Applied, thank you.

> ---
>  drivers/input/serio/sa1111ps2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/sa1111ps2.c b/drivers/input/serio/sa1111ps2.c
> index f1c036260d25..f9e5c793f4f0 100644
> --- a/drivers/input/serio/sa1111ps2.c
> +++ b/drivers/input/serio/sa1111ps2.c
> @@ -212,7 +212,7 @@ static unsigned int ps2_test_one(struct ps2if *ps2if,
>  
>  	writel_relaxed(PS2CR_ENA | mask, ps2if->base + PS2CR);
>  
> -	udelay(2);
> +	udelay(10);
>  
>  	val = readl_relaxed(ps2if->base + PS2STAT);
>  	return val & (PS2STAT_KBC | PS2STAT_KBD);
> -- 
> 2.7.4
>
diff mbox

Patch

diff --git a/drivers/input/serio/sa1111ps2.c b/drivers/input/serio/sa1111ps2.c
index f1c036260d25..f9e5c793f4f0 100644
--- a/drivers/input/serio/sa1111ps2.c
+++ b/drivers/input/serio/sa1111ps2.c
@@ -212,7 +212,7 @@  static unsigned int ps2_test_one(struct ps2if *ps2if,
 
 	writel_relaxed(PS2CR_ENA | mask, ps2if->base + PS2CR);
 
-	udelay(2);
+	udelay(10);
 
 	val = readl_relaxed(ps2if->base + PS2STAT);
 	return val & (PS2STAT_KBC | PS2STAT_KBD);