| Message ID | 920f1461-2c2a-430f-28ef-18af18788889@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
Hi Markus, On Tue, Sep 26, 2017 at 10:05:59PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 26 Sep 2017 22:00:05 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> This patch is good for me, it's true that below error log senstence is redundant with its caller hisi_clk_register_gate_sep(). Reviewed-by: Leo Yan <leo.yan@linaro.org> > --- > drivers/clk/hisilicon/clkgate-separated.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/clk/hisilicon/clkgate-separated.c b/drivers/clk/hisilicon/clkgate-separated.c > index 7908bc3c9ec7..f028bcffe12c 100644 > --- a/drivers/clk/hisilicon/clkgate-separated.c > +++ b/drivers/clk/hisilicon/clkgate-separated.c > @@ -105,10 +105,8 @@ struct clk *hisi_register_clkgate_sep(struct device *dev, const char *name, > struct clk_init_data init; > > sclk = kzalloc(sizeof(*sclk), GFP_KERNEL); > - if (!sclk) { > - pr_err("%s: fail to allocate separated gated clk\n", __func__); > + if (!sclk) > return ERR_PTR(-ENOMEM); > - } > > init.name = name; > init.ops = &clkgate_separated_ops; > -- > 2.14.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/26, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 26 Sep 2017 22:00:05 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- Applied to clk-next
diff --git a/drivers/clk/hisilicon/clkgate-separated.c b/drivers/clk/hisilicon/clkgate-separated.c index 7908bc3c9ec7..f028bcffe12c 100644 --- a/drivers/clk/hisilicon/clkgate-separated.c +++ b/drivers/clk/hisilicon/clkgate-separated.c @@ -105,10 +105,8 @@ struct clk *hisi_register_clkgate_sep(struct device *dev, const char *name, struct clk_init_data init; sclk = kzalloc(sizeof(*sclk), GFP_KERNEL); - if (!sclk) { - pr_err("%s: fail to allocate separated gated clk\n", __func__); + if (!sclk) return ERR_PTR(-ENOMEM); - } init.name = name; init.ops = &clkgate_separated_ops;