| Message ID | 1506632100-6293-1-git-send-email-jbacik@fb.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 28, 2017 at 04:55:00PM -0400, Josef Bacik wrote: > This should be verify'ing that we have an empty key, not that we have a > filled out key. > > Signed-off-by: Josef Bacik <jbacik@fb.com> > --- > Dave this is on top of your ext/jeffm/extent-cache branch and fixes the segfault > you reported. Great, thanks for the fix. I'll fold it to the original patch so the branches remain bisectable. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/backref.c b/backref.c index 8fc0fae779f2..8615f6b8677a 100644 --- a/backref.c +++ b/backref.c @@ -465,7 +465,7 @@ static int __add_missing_keys(struct btrfs_fs_info *fs_info, ASSERT(ref->root_id); ASSERT(!ref->parent); - ASSERT(ref->key_for_search.type); + ASSERT(!ref->key_for_search.type); BUG_ON(!ref->wanted_disk_byte); eb = read_tree_block(fs_info, ref->wanted_disk_byte, 0); if (!extent_buffer_uptodate(eb)) {
This should be verify'ing that we have an empty key, not that we have a filled out key. Signed-off-by: Josef Bacik <jbacik@fb.com> --- Dave this is on top of your ext/jeffm/extent-cache branch and fixes the segfault you reported. backref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)