diff mbox

[1/2] dt-bindings: hwmon: add compatible for max1619

Message ID 20170911191649.3344-1-atull@kernel.org (mailing list archive)
State Accepted
Headers show

Commit Message

Alan Tull Sept. 11, 2017, 7:16 p.m. UTC
Add new device tree bindings document for max1619 device
including a new compatible string.

Signed-off-by: Alan Tull <atull@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
---
 Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt

Comments

Alan Tull Sept. 11, 2017, 7:33 p.m. UTC | #1
On Mon, Sep 11, 2017 at 2:16 PM, Alan Tull <atull@kernel.org> wrote:

Add Oleksij Rempel

> Add new device tree bindings document for max1619 device
> including a new compatible string.
>
> Signed-off-by: Alan Tull <atull@kernel.org>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
>  Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/max1619.txt b/Documentation/devicetree/bindings/hwmon/max1619.txt
> new file mode 100644
> index 0000000..c70dbbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/max1619.txt
> @@ -0,0 +1,12 @@
> +Bindings for MAX1619 Temperature Sensor
> +
> +Required properties:
> +- compatible : "maxim,max1619"
> +- reg        : I2C address, one of 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, or
> +               0x4d, 0x4e
> +
> +Example:
> +       temp@4c {
> +               compatible = "maxim,max1619";
> +               reg = <0x4c>;
> +       };
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Tull Sept. 11, 2017, 9:18 p.m. UTC | #2
On Mon, Sep 11, 2017 at 2:33 PM, Alan Tull <atull@kernel.org> wrote:

Forget this - Guenter has pointed out that this patch is not needed,
as the i2c layer handles this without needing the compatible added.

Alan

> On Mon, Sep 11, 2017 at 2:16 PM, Alan Tull <atull@kernel.org> wrote:
>
> Add Oleksij Rempel
>
>> Add new device tree bindings document for max1619 device
>> including a new compatible string.
>>
>> Signed-off-by: Alan Tull <atull@kernel.org>
>> Cc: Jean Delvare <jdelvare@suse.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> ---
>>  Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/max1619.txt b/Documentation/devicetree/bindings/hwmon/max1619.txt
>> new file mode 100644
>> index 0000000..c70dbbe
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/max1619.txt
>> @@ -0,0 +1,12 @@
>> +Bindings for MAX1619 Temperature Sensor
>> +
>> +Required properties:
>> +- compatible : "maxim,max1619"
>> +- reg        : I2C address, one of 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, or
>> +               0x4d, 0x4e
>> +
>> +Example:
>> +       temp@4c {
>> +               compatible = "maxim,max1619";
>> +               reg = <0x4c>;
>> +       };
>> --
>> 2.7.4
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Sept. 18, 2017, 9:12 p.m. UTC | #3
On Mon, Sep 11, 2017 at 04:18:22PM -0500, Alan Tull wrote:
> On Mon, Sep 11, 2017 at 2:33 PM, Alan Tull <atull@kernel.org> wrote:
> 
> Forget this - Guenter has pointed out that this patch is not needed,
> as the i2c layer handles this without needing the compatible added.

The binding is needed regardless.

This could be in trivial-devices.txt instead. Either way,

Acked-by: Rob Herring <robh@kernel.org>

Rob

> 
> Alan
> 
> > On Mon, Sep 11, 2017 at 2:16 PM, Alan Tull <atull@kernel.org> wrote:
> >
> > Add Oleksij Rempel
> >
> >> Add new device tree bindings document for max1619 device
> >> including a new compatible string.
> >>
> >> Signed-off-by: Alan Tull <atull@kernel.org>
> >> Cc: Jean Delvare <jdelvare@suse.com>
> >> Cc: Guenter Roeck <linux@roeck-us.net>
> >> Cc: Rob Herring <robh+dt@kernel.org>
> >> Cc: Mark Rutland <mark.rutland@arm.com>
> >> ---
> >>  Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ++++++++++++
> >>  1 file changed, 12 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwmon/max1619.txt b/Documentation/devicetree/bindings/hwmon/max1619.txt
> >> new file mode 100644
> >> index 0000000..c70dbbe
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/hwmon/max1619.txt
> >> @@ -0,0 +1,12 @@
> >> +Bindings for MAX1619 Temperature Sensor
> >> +
> >> +Required properties:
> >> +- compatible : "maxim,max1619"
> >> +- reg        : I2C address, one of 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, or
> >> +               0x4d, 0x4e
> >> +
> >> +Example:
> >> +       temp@4c {
> >> +               compatible = "maxim,max1619";
> >> +               reg = <0x4c>;
> >> +       };
> >> --
> >> 2.7.4
> >>
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Guenter Roeck Oct. 1, 2017, 2:11 p.m. UTC | #4
On Mon, Sep 11, 2017 at 02:16:48PM -0500, Alan Tull wrote:
> Add new device tree bindings document for max1619 device
> including a new compatible string.
> 
> Signed-off-by: Alan Tull <atull@kernel.org>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Rob Herring <robh@kernel.org>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  Documentation/devicetree/bindings/hwmon/max1619.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/max1619.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/max1619.txt b/Documentation/devicetree/bindings/hwmon/max1619.txt
> new file mode 100644
> index 0000000..c70dbbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/max1619.txt
> @@ -0,0 +1,12 @@
> +Bindings for MAX1619 Temperature Sensor
> +
> +Required properties:
> +- compatible : "maxim,max1619"
> +- reg        : I2C address, one of 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, or
> +               0x4d, 0x4e
> +
> +Example:
> +	temp@4c {
> +		compatible = "maxim,max1619";
> +		reg = <0x4c>;
> +	};
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/max1619.txt b/Documentation/devicetree/bindings/hwmon/max1619.txt
new file mode 100644
index 0000000..c70dbbe
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/max1619.txt
@@ -0,0 +1,12 @@ 
+Bindings for MAX1619 Temperature Sensor
+
+Required properties:
+- compatible : "maxim,max1619"
+- reg        : I2C address, one of 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, or
+               0x4d, 0x4e
+
+Example:
+	temp@4c {
+		compatible = "maxim,max1619";
+		reg = <0x4c>;
+	};