diff mbox

dmaengine: usb-dmac: Add compatible string for r8a7743/5

Message ID 1507216771-8957-1-git-send-email-biju.das@bp.renesas.com (mailing list archive)
State Changes Requested
Headers show

Commit Message

Biju Das Oct. 5, 2017, 3:19 p.m. UTC
This patch adds support for r8a7743/5 SoC. The Renesas RZ/G1[ME]
(R8A7743/5) usbdmac engine is identical to the R-Car Gen2 family.

This doesn't change the driver, so it does nothing by itself.  But it does
mean that checkpatch won't complain about a future patch that adds
"renesas,r8a7743-usb-dmac" or "renesas,r8a7745-usb-dmac" to a DT,
which helps ensure that shipped DTs use documented compatibility strings.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
This patch is tested against Linux next tag next-20170929 

 Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven Oct. 6, 2017, 7:36 a.m. UTC | #1
Hi Biju,

On Thu, Oct 5, 2017 at 5:19 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> This patch adds support for r8a7743/5 SoC. The Renesas RZ/G1[ME]
> (R8A7743/5) usbdmac engine is identical to the R-Car Gen2 family.
>
> This doesn't change the driver, so it does nothing by itself.  But it does

Wording it like this may give the wrong impression to the casual reader
that a driver change will be submitted separately.
No driver change is needed due to the fallback compatible value
"renesas,usb-dmac".

> mean that checkpatch won't complain about a future patch that adds
> "renesas,r8a7743-usb-dmac" or "renesas,r8a7745-usb-dmac" to a DT,
> which helps ensure that shipped DTs use documented compatibility strings.

Adding the SoC-specific compatible values here has two purposes:
  1. Document which SoCs have this hardware module,
  2. Allow checkpatch to validate compatible values.

> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> +++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> @@ -3,6 +3,8 @@
>  Required Properties:
>  -compatible: "renesas,<soctype>-usb-dmac", "renesas,usb-dmac" as fallback.
>         Examples with soctypes are:
> +         - "renesas,r8a7743-usb-dmac" (RZ/G1M)
> +         - "renesas,r8a7745-usb-dmac" (RZ/G1E)
>           - "renesas,r8a7790-usb-dmac" (R-Car H2)
>           - "renesas,r8a7791-usb-dmac" (R-Car M2-W)
>           - "renesas,r8a7793-usb-dmac" (R-Car M2-N)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Biju Das Oct. 6, 2017, 9 a.m. UTC | #2
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogZ2VlcnQudXl0dGVyaG9l
dmVuQGdtYWlsLmNvbSBbbWFpbHRvOmdlZXJ0LnV5dHRlcmhvZXZlbkBnbWFpbC5jb21dDQo+IE9u
IEJlaGFsZiBPZiBHZWVydCBVeXR0ZXJob2V2ZW4NCj4gU2VudDogMDYgT2N0b2JlciAyMDE3IDA4
OjM2DQo+IFRvOiBCaWp1IERhcyA8YmlqdS5kYXNAYnAucmVuZXNhcy5jb20+DQo+IENjOiBWaW5v
ZCBLb3VsIDx2aW5vZC5rb3VsQGludGVsLmNvbT47IFJvYiBIZXJyaW5nIDxyb2JoK2R0QGtlcm5l
bC5vcmc+Ow0KPiBNYXJrIFJ1dGxhbmQgPG1hcmsucnV0bGFuZEBhcm0uY29tPjsgU2ltb24gSG9y
bWFuDQo+IDxob3Jtc0B2ZXJnZS5uZXQuYXU+OyBDaHJpcyBQYXRlcnNvbiA8Q2hyaXMuUGF0ZXJz
b24yQHJlbmVzYXMuY29tPjsNCj4gRmFicml6aW8gQ2FzdHJvIDxmYWJyaXppby5jYXN0cm9AYnAu
cmVuZXNhcy5jb20+Ow0KPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgTGludXgtUmVuZXNh
cyA8bGludXgtcmVuZXNhcy0NCj4gc29jQHZnZXIua2VybmVsLm9yZz47IGRtYWVuZ2luZUB2Z2Vy
Lmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gZG1hZW5naW5lOiB1c2ItZG1hYzog
QWRkIGNvbXBhdGlibGUgc3RyaW5nIGZvcg0KPiByOGE3NzQzLzUNCj4NCj4gSGkgQmlqdSwNCj4N
Cj4gT24gVGh1LCBPY3QgNSwgMjAxNyBhdCA1OjE5IFBNLCBCaWp1IERhcyA8YmlqdS5kYXNAYnAu
cmVuZXNhcy5jb20+IHdyb3RlOg0KPiA+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciByOGE3
NzQzLzUgU29DLiBUaGUgUmVuZXNhcyBSWi9HMVtNRV0NCj4gPiAoUjhBNzc0My81KSB1c2JkbWFj
IGVuZ2luZSBpcyBpZGVudGljYWwgdG8gdGhlIFItQ2FyIEdlbjIgZmFtaWx5Lg0KPiA+DQo+ID4g
VGhpcyBkb2Vzbid0IGNoYW5nZSB0aGUgZHJpdmVyLCBzbyBpdCBkb2VzIG5vdGhpbmcgYnkgaXRz
ZWxmLiAgQnV0IGl0DQo+ID4gZG9lcw0KPg0KPiBXb3JkaW5nIGl0IGxpa2UgdGhpcyBtYXkgZ2l2
ZSB0aGUgd3JvbmcgaW1wcmVzc2lvbiB0byB0aGUgY2FzdWFsIHJlYWRlciB0aGF0IGENCj4gZHJp
dmVyIGNoYW5nZSB3aWxsIGJlIHN1Ym1pdHRlZCBzZXBhcmF0ZWx5Lg0KPiBObyBkcml2ZXIgY2hh
bmdlIGlzIG5lZWRlZCBkdWUgdG8gdGhlIGZhbGxiYWNrIGNvbXBhdGlibGUgdmFsdWUgInJlbmVz
YXMsdXNiLQ0KPiBkbWFjIi4NCj4NCj4gPiBtZWFuIHRoYXQgY2hlY2twYXRjaCB3b24ndCBjb21w
bGFpbiBhYm91dCBhIGZ1dHVyZSBwYXRjaCB0aGF0IGFkZHMNCj4gPiAicmVuZXNhcyxyOGE3NzQz
LXVzYi1kbWFjIiBvciAicmVuZXNhcyxyOGE3NzQ1LXVzYi1kbWFjIiB0byBhIERULA0KPiA+IHdo
aWNoIGhlbHBzIGVuc3VyZSB0aGF0IHNoaXBwZWQgRFRzIHVzZSBkb2N1bWVudGVkIGNvbXBhdGli
aWxpdHkgc3RyaW5ncy4NCj4NCj4gQWRkaW5nIHRoZSBTb0Mtc3BlY2lmaWMgY29tcGF0aWJsZSB2
YWx1ZXMgaGVyZSBoYXMgdHdvIHB1cnBvc2VzOg0KPiAgIDEuIERvY3VtZW50IHdoaWNoIFNvQ3Mg
aGF2ZSB0aGlzIGhhcmR3YXJlIG1vZHVsZSwNCj4gICAyLiBBbGxvdyBjaGVja3BhdGNoIHRvIHZh
bGlkYXRlIGNvbXBhdGlibGUgdmFsdWVzLg0KDQpUaGFua3MuIEkgd2lsbCBzZW5kICB2MiB3aXRo
IGFib3ZlIGNoYW5nZXMNCg0KPiA+IFNpZ25lZC1vZmYtYnk6IEJpanUgRGFzIDxiaWp1LmRhc0Bi
cC5yZW5lc2FzLmNvbT4NCj4NCj4gUmV2aWV3ZWQtYnk6IEdlZXJ0IFV5dHRlcmhvZXZlbiA8Z2Vl
cnQrcmVuZXNhc0BnbGlkZXIuYmU+DQo+DQoNCg0KDQpSZW5lc2FzIEVsZWN0cm9uaWNzIEV1cm9w
ZSBMdGQsIER1a2VzIE1lYWRvdywgTWlsbGJvYXJkIFJvYWQsIEJvdXJuZSBFbmQsIEJ1Y2tpbmdo
YW1zaGlyZSwgU0w4IDVGSCwgVUsuIFJlZ2lzdGVyZWQgaW4gRW5nbGFuZCAmIFdhbGVzIHVuZGVy
IFJlZ2lzdGVyZWQgTm8uIDA0NTg2NzA5Lg0K
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
index 1be6941..f3d1f15 100644
--- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
+++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
@@ -3,6 +3,8 @@ 
 Required Properties:
 -compatible: "renesas,<soctype>-usb-dmac", "renesas,usb-dmac" as fallback.
 	Examples with soctypes are:
+	  - "renesas,r8a7743-usb-dmac" (RZ/G1M)
+	  - "renesas,r8a7745-usb-dmac" (RZ/G1E)
 	  - "renesas,r8a7790-usb-dmac" (R-Car H2)
 	  - "renesas,r8a7791-usb-dmac" (R-Car M2-W)
 	  - "renesas,r8a7793-usb-dmac" (R-Car M2-N)