| Message ID | a6f5942b90cca416b7d9f93889669db2cd4fc1f5.1503087292.git.mathieu.larouche@matrox.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
I would like to know if anyone had the time to look at this patch and when I could expect to have it accepted. Thank you, Mathieu On 18/08/2017 4:24 PM, mathieu.larouche@matrox.com wrote: > From: Mathieu Larouche <mathieu.larouche@matrox.com> > > OEMs started distributing this module out of the box so adding the > version in modinfo output for this module may be a good idea. > > Signed-off-by: Mathieu Larouche <mathieu.larouche@matrox.com> > --- > drivers/gpu/drm/mgag200/mgag200_drv.c | 3 +++ > drivers/gpu/drm/mgag200/mgag200_drv.h | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c > index 9ac0078..ad3f193 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_drv.c > +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c > @@ -134,3 +134,6 @@ static void __exit mgag200_exit(void) > MODULE_AUTHOR(DRIVER_AUTHOR); > MODULE_DESCRIPTION(DRIVER_DESC); > MODULE_LICENSE("GPL"); > +MODULE_VERSION(__stringify(DRIVER_MAJOR) "." > + __stringify(DRIVER_MINOR) "." > + __stringify(DRIVER_PATCHLEVEL)); > diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h > index c88b6ec..df4833b 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_drv.h > +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h > @@ -37,7 +37,7 @@ > #define DRIVER_DATE "20110418" > > #define DRIVER_MAJOR 1 > -#define DRIVER_MINOR 0 > +#define DRIVER_MINOR 1 > #define DRIVER_PATCHLEVEL 0 > > #define MGAG200FB_CONN_LIMIT 1
On Thu, Oct 5, 2017 at 9:18 PM, Mathieu Larouche <mathieu.larouche@matrox.com> wrote: > I would like to know if anyone had the time to look at this patch and when I > could expect to have it accepted. MODULE_VERSION is kinda considered uncool in drm. For KMS drivers (which mga200g is one) there's really no reason, for render/gem drivers we have tons of other ways to communicate the uapi version/feature support to userspace. There's also the occasional thread on lkml to just rip it all out as essentially nonsense. Please explain what you need this for and we can point you in the right direction. -Daniel > > Thank you, > > Mathieu > > > On 18/08/2017 4:24 PM, mathieu.larouche@matrox.com wrote: >> >> From: Mathieu Larouche <mathieu.larouche@matrox.com> >> >> OEMs started distributing this module out of the box so adding the >> version in modinfo output for this module may be a good idea. >> >> Signed-off-by: Mathieu Larouche <mathieu.larouche@matrox.com> >> --- >> drivers/gpu/drm/mgag200/mgag200_drv.c | 3 +++ >> drivers/gpu/drm/mgag200/mgag200_drv.h | 2 +- >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c >> b/drivers/gpu/drm/mgag200/mgag200_drv.c >> index 9ac0078..ad3f193 100644 >> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c >> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c >> @@ -134,3 +134,6 @@ static void __exit mgag200_exit(void) >> MODULE_AUTHOR(DRIVER_AUTHOR); >> MODULE_DESCRIPTION(DRIVER_DESC); >> MODULE_LICENSE("GPL"); >> +MODULE_VERSION(__stringify(DRIVER_MAJOR) "." >> + __stringify(DRIVER_MINOR) "." >> + __stringify(DRIVER_PATCHLEVEL)); >> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h >> b/drivers/gpu/drm/mgag200/mgag200_drv.h >> index c88b6ec..df4833b 100644 >> --- a/drivers/gpu/drm/mgag200/mgag200_drv.h >> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h >> @@ -37,7 +37,7 @@ >> #define DRIVER_DATE "20110418" >> #define DRIVER_MAJOR 1 >> -#define DRIVER_MINOR 0 >> +#define DRIVER_MINOR 1 >> #define DRIVER_PATCHLEVEL 0 >> #define MGAG200FB_CONN_LIMIT 1 > > > -- > Mathieu Larouche Ing./Eng. > Software Designer > Matrox Graphics Inc. > Phone : 514 822-6000 x7905 > Email : mathieu.larouche@matrox.com > > CONFIDENTIAL & WITHOUT PREJUDICE > > This e-mail and any files transmitted with it, is confidential, may be > protected under NDA and/or privileged and shall be treated as such. The > e-mail and its attachments are intended only for use of the individual(s) or > entity(ies) indicated above. Any other person is hereby advised that it > strictly forbidden to disclose, distribute or reproduce this message. If you > have received this e-mail in error, please advise me by return e-mail or by > telephone at 514-822-6000, immediately and destroy the message and its > contents immediately. Thank You. > > CONFIDENTIEL- SANS PRÉJUDICE > > Ce courriel et tout document qui y est joint, est confidentiel, peut être > privilégié et protégé par entente de confidentialité et est à l'usage > exclusif du destinataire. Toute autre personne est par les présentes avisée > qu'il lui est strictement interdit de le diffuser, le distribuer ou le > reproduire. Si vous recevez ce courriel par erreur, veuillez m'en aviser > immédiatement, par retour de courriel ou par téléphone au (514) 822-6000 et > détruire ce message et toute copie de celui-ci immédiatement. Merci. > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c index 9ac0078..ad3f193 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.c +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c @@ -134,3 +134,6 @@ static void __exit mgag200_exit(void) MODULE_AUTHOR(DRIVER_AUTHOR); MODULE_DESCRIPTION(DRIVER_DESC); MODULE_LICENSE("GPL"); +MODULE_VERSION(__stringify(DRIVER_MAJOR) "." + __stringify(DRIVER_MINOR) "." + __stringify(DRIVER_PATCHLEVEL)); diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h index c88b6ec..df4833b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.h +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h @@ -37,7 +37,7 @@ #define DRIVER_DATE "20110418" #define DRIVER_MAJOR 1 -#define DRIVER_MINOR 0 +#define DRIVER_MINOR 1 #define DRIVER_PATCHLEVEL 0 #define MGAG200FB_CONN_LIMIT 1