| Message ID | 20171006213333.6721-14-bart.vanassche@wdc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
> > Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> > Cc: Steve Wise <swise@opengridcomputing.com> > --- > drivers/infiniband/hw/cxgb4/cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index 2331e7d57704..49d9f9b870e5 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -99,7 +99,7 @@ module_param(enable_tcp_window_scaling, int, 0644); > MODULE_PARM_DESC(enable_tcp_window_scaling, > "Enable tcp window scaling (default=1)"); > > -int c4iw_debug; > +static int c4iw_debug; > module_param(c4iw_debug, int, 0644); > MODULE_PARM_DESC(c4iw_debug, "obsolete"); Can we just remove this now? IE has it been 1 release since it was obsoleted? Reviewed-by: Steve Wise <swise@opengridcomputing.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2017-10-06 at 17:09 -0500, Steve Wise wrote: > > > > Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> > > Cc: Steve Wise <swise@opengridcomputing.com> > > --- > > drivers/infiniband/hw/cxgb4/cm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c > > b/drivers/infiniband/hw/cxgb4/cm.c > > index 2331e7d57704..49d9f9b870e5 100644 > > --- a/drivers/infiniband/hw/cxgb4/cm.c > > +++ b/drivers/infiniband/hw/cxgb4/cm.c > > @@ -99,7 +99,7 @@ module_param(enable_tcp_window_scaling, int, 0644); > > MODULE_PARM_DESC(enable_tcp_window_scaling, > > "Enable tcp window scaling (default=1)"); > > > > -int c4iw_debug; > > +static int c4iw_debug; > > module_param(c4iw_debug, int, 0644); > > MODULE_PARM_DESC(c4iw_debug, "obsolete"); > > Can we just remove this now? IE has it been 1 release since it was obsoleted? That's a good question but I'm not sure what would be a good time to remove this. I think the answer depends on how likely it is that people use this variable in scripts or /etc/modprobe.d configuration files because in that case removing the module parameter would break setups. Bart.
On Mon, Oct 09, 2017 at 11:20:20PM +0000, Bart Van Assche wrote: > On Fri, 2017-10-06 at 17:09 -0500, Steve Wise wrote: > > > > > > Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> > > > Cc: Steve Wise <swise@opengridcomputing.com> > > > --- > > > drivers/infiniband/hw/cxgb4/cm.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c > > > > b/drivers/infiniband/hw/cxgb4/cm.c > > > index 2331e7d57704..49d9f9b870e5 100644 > > > --- a/drivers/infiniband/hw/cxgb4/cm.c > > > +++ b/drivers/infiniband/hw/cxgb4/cm.c > > > @@ -99,7 +99,7 @@ module_param(enable_tcp_window_scaling, int, 0644); > > > MODULE_PARM_DESC(enable_tcp_window_scaling, > > > "Enable tcp window scaling (default=1)"); > > > > > > -int c4iw_debug; > > > +static int c4iw_debug; > > > module_param(c4iw_debug, int, 0644); > > > MODULE_PARM_DESC(c4iw_debug, "obsolete"); > > > > Can we just remove this now? IE has it been 1 release since it was obsoleted? > > That's a good question but I'm not sure what would be a good time to remove > this. I think the answer depends on how likely it is that people use this > variable in scripts or /etc/modprobe.d configuration files because in that > case removing the module parameter would break setups. It is unlikely to happen, for many reasons. It is marked as obsolete for a long time, the proper infrastructure (dynamic prints) already for a decade with us and no adequate user is running debug system in production. Another thing that we do remove visible to user interfaces from time to time and the rule is "try to remove it and see if someone screams about it". There are a lot of commits which do such thing and latest one is 0d0c71b31720 ("btrfs: obsolete and remove mount option alloc_start") It is safe to remove c4iw_debug module parameter. Thanks > > Bart.
On Tue, 2017-10-10 at 06:59 +0300, Leon Romanovsky wrote: > On Mon, Oct 09, 2017 at 11:20:20PM +0000, Bart Van Assche wrote: > > On Fri, 2017-10-06 at 17:09 -0500, Steve Wise wrote: > > > Can we just remove this now? IE has it been 1 release since it was obsoleted? > > > > That's a good question but I'm not sure what would be a good time to remove > > this. I think the answer depends on how likely it is that people use this > > variable in scripts or /etc/modprobe.d configuration files because in that > > case removing the module parameter would break setups. > > It is unlikely to happen, for many reasons. It is marked as obsolete for > a long time, the proper infrastructure (dynamic prints) already for a decade > with us and no adequate user is running debug system in production. > > Another thing that we do remove visible to user interfaces from time to time > and the rule is "try to remove it and see if someone screams about it". > > There are a lot of commits which do such thing and latest one is 0d0c71b31720 > ("btrfs: obsolete and remove mount option alloc_start") > > It is safe to remove c4iw_debug module parameter. OK, I will remove that module parameter. Bart.
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 2331e7d57704..49d9f9b870e5 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -99,7 +99,7 @@ module_param(enable_tcp_window_scaling, int, 0644); MODULE_PARM_DESC(enable_tcp_window_scaling, "Enable tcp window scaling (default=1)"); -int c4iw_debug; +static int c4iw_debug; module_param(c4iw_debug, int, 0644); MODULE_PARM_DESC(c4iw_debug, "obsolete");
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: Steve Wise <swise@opengridcomputing.com> --- drivers/infiniband/hw/cxgb4/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)