diff mbox

RMI4 support for synaptics (users, please test patch)

Message ID 20170920.092218.1849017994555826153.teika@gmx.com (mailing list archive)
State New, archived
Headers show

Commit Message

Teika Kazura Sept. 20, 2017, 12:22 a.m. UTC
CC-ed folks, your devices need "psmouse.synaptics_intertouch=1". Let me follow up. (I'm not a kernel developer, but in a similar situation as yours.) The patch should apply to 4.13.x and 4.12.x.

@Lukas Prettenthaler, rosenp, Pablo Cholaky, jan.steffens, Darrick J. Wong:
 Could you please test the patch below? Make sure to delete "psmouse.synaptics_intertouch=1" from your boot parameter. If the patch has the same effect as the above boot parameter, it seems ok.

@Kamil Iskra: Maybe add "SYN3054" to the patch, and try?

@Sibren Vasse: I know your patch works for you, but could you try dropping SYN0100, SYN0002 and PNP0f13 from your patch? (Typical dmesg is like: "Your touchpad (PNP: SYN3221 PNP0f03) says it can support a different bus", and adding only the first of two, "SYN3221", suffices.)

@Adam Goode: As you know, your issue (freeze after resuming) is yet to be fixed. I haven't included your model in my patch.

@Christopher Bachner: What's the status of your PC? I'm subscribing linux-input@vger.kernel.org, and found your issue browsing linux-input archive, but you don't read this list, right? I think you've tried this patch: https://marc.info/?l=linux-input&m=149854999528878&w=2 

Best regards. Thank you for reporting.

---
 drivers/input/mouse/synaptics.c | 6 ++++++
 1 file changed, 6 insertions(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Darrick J. Wong Oct. 14, 2017, 8:09 p.m. UTC | #1
On Wed, Sep 20, 2017 at 09:22:18AM +0900, Teika Kazura wrote:
> CC-ed folks, your devices need "psmouse.synaptics_intertouch=1". Let me follow up. (I'm not a kernel developer, but in a similar situation as yours.) The patch should apply to 4.13.x and 4.12.x.
> 
> @Lukas Prettenthaler, rosenp, Pablo Cholaky, jan.steffens, Darrick J. Wong:
>  Could you please test the patch below? Make sure to delete "psmouse.synaptics_intertouch=1" from your boot parameter. If the patch has the same effect as the above boot parameter, it seems ok.

Seems to work (4.13.7), sorry it took so long to get back to you.

--D

> 
> @Kamil Iskra: Maybe add "SYN3054" to the patch, and try?
> 
> @Sibren Vasse: I know your patch works for you, but could you try dropping SYN0100, SYN0002 and PNP0f13 from your patch? (Typical dmesg is like: "Your touchpad (PNP: SYN3221 PNP0f03) says it can support a different bus", and adding only the first of two, "SYN3221", suffices.)
> 
> @Adam Goode: As you know, your issue (freeze after resuming) is yet to be fixed. I haven't included your model in my patch.
> 
> @Christopher Bachner: What's the status of your PC? I'm subscribing linux-input@vger.kernel.org, and found your issue browsing linux-input archive, but you don't read this list, right? I think you've tried this patch: https://marc.info/?l=linux-input&m=149854999528878&w=2 
> 
> Best regards. Thank you for reporting.
> 
> ---
>  drivers/input/mouse/synaptics.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 5af0b7d..bc02040 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -169,10 +169,16 @@ static const char * const topbuttonpad_pnp_ids[] = {
>  
>  static const char * const smbus_pnp_ids[] = {
>  	/* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
> +	"DLL075b",
>  	"LEN0048", /* X1 Carbon 3 */
>  	"LEN0046", /* X250 */
>  	"LEN004a", /* W541 */
> +	"LEN004b", /* T460s */
> +	"LEN006e", /* T470 */
>  	"LEN200f", /* T450s */
> +	/* "LEN2014", commented out, depending on resume bug fix */
> +	"SYN1219", /* Used by many */
> +	"SYN3221",
>  	NULL
>  };
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 5af0b7d..bc02040 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -169,10 +169,16 @@  static const char * const topbuttonpad_pnp_ids[] = {
 
 static const char * const smbus_pnp_ids[] = {
 	/* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
+	"DLL075b",
 	"LEN0048", /* X1 Carbon 3 */
 	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
+	"LEN004b", /* T460s */
+	"LEN006e", /* T470 */
 	"LEN200f", /* T450s */
+	/* "LEN2014", commented out, depending on resume bug fix */
+	"SYN1219", /* Used by many */
+	"SYN3221",
 	NULL
 };