diff mbox

[9/9] ARM: multi_v7_defconfig: Statically build RTC_DRV_RK808

Message ID 1508156187-27519-10-git-send-email-jagan@amarulasolutions.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jagan Teki Oct. 16, 2017, 12:16 p.m. UTC
RTC_DRV_RK808 need to have build statically for the platforms
do use MFB_RK808 so replace module with statical link.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 arch/arm/configs/multi_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Stübner Oct. 16, 2017, 6:02 p.m. UTC | #1
Hi,

Am Montag, 16. Oktober 2017, 17:46:27 CEST schrieb Jagan Teki:
> RTC_DRV_RK808 need to have build statically for the platforms
> do use MFB_RK808 so replace module with statical link.

why would you need this to be compiled on? MFD_RK808 will happily
just create the platform-devices which are then bound to the RTC
driver later once the module is ready.

Heiko

> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  arch/arm/configs/multi_v7_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig index 2adef49..6ddc35c 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -768,7 +768,7 @@ CONFIG_RTC_DRV_MAX8907=y
>  CONFIG_RTC_DRV_MAX8998=m
>  CONFIG_RTC_DRV_MAX8997=m
>  CONFIG_RTC_DRV_MAX77686=y
> -CONFIG_RTC_DRV_RK808=m
> +CONFIG_RTC_DRV_RK808=y
>  CONFIG_RTC_DRV_RS5C372=m
>  CONFIG_RTC_DRV_BQ32K=m
>  CONFIG_RTC_DRV_PALMAS=y
Jagan Teki Oct. 16, 2017, 6:13 p.m. UTC | #2
On Mon, Oct 16, 2017 at 11:32 PM, Heiko Stübner <heiko@sntech.de> wrote:
> Hi,
>
> Am Montag, 16. Oktober 2017, 17:46:27 CEST schrieb Jagan Teki:
>> RTC_DRV_RK808 need to have build statically for the platforms
>> do use MFB_RK808 so replace module with statical link.
>
> why would you need this to be compiled on? MFD_RK808 will happily
> just create the platform-devices which are then bound to the RTC
> driver later once the module is ready.

Yeah, that can be true but seems like rk808 need rtc at the
beginning(like boot time) because we observed the boot hang even with
gmac (like one with HDMI [1]) eventually booting continue only when it
linked statically.

[1] https://lkml.org/lkml/2017/9/4/224

thanks!
diff mbox

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 2adef49..6ddc35c 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -768,7 +768,7 @@  CONFIG_RTC_DRV_MAX8907=y
 CONFIG_RTC_DRV_MAX8998=m
 CONFIG_RTC_DRV_MAX8997=m
 CONFIG_RTC_DRV_MAX77686=y
-CONFIG_RTC_DRV_RK808=m
+CONFIG_RTC_DRV_RK808=y
 CONFIG_RTC_DRV_RS5C372=m
 CONFIG_RTC_DRV_BQ32K=m
 CONFIG_RTC_DRV_PALMAS=y