| Message ID | 20171006133203.22803-13-jean-philippe.brucker@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Oct 06, 2017 at 02:31:39PM +0100, Jean-Philippe Brucker wrote: > On ARM systems, some platform devices behind an IOMMU may support stall > and PASID features. Stall is the ability to recover from page faults and > PASID offers multiple process address spaces to the device. Together they > allow to do paging with a device. Let the firmware tell us when a device > supports stall and PASID. Can't these be implied by the compatible string of the devices? > > Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> > --- > Documentation/devicetree/bindings/iommu/iommu.txt | 24 +++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/iommu.txt b/Documentation/devicetree/bindings/iommu/iommu.txt > index 5a8b4624defc..c589b75f7277 100644 > --- a/Documentation/devicetree/bindings/iommu/iommu.txt > +++ b/Documentation/devicetree/bindings/iommu/iommu.txt > @@ -86,6 +86,30 @@ have a means to turn off translation. But it is invalid in such cases to > disable the IOMMU's device tree node in the first place because it would > prevent any driver from properly setting up the translations. > > +Optional properties: > +-------------------- > +- dma-can-stall: When present, the master can wait for a transaction to > + complete for an indefinite amount of time. Upon translation fault some > + IOMMUs, instead of aborting the translation immediately, may first > + notify the driver and keep the transaction in flight. This allows the OS > + to inspect the fault and, for example, make physical pages resident > + before updating the mappings and completing the transaction. Such IOMMU > + accepts a limited number of simultaneous stalled transactions before > + having to either put back-pressure on the master, or abort new faulting > + transactions. > + > + Firmware has to opt-in stalling, because most buses and masters don't > + support it. In particular it isn't compatible with PCI, where > + transactions have to complete before a time limit. More generally it > + won't work in systems and masters that haven't been designed for > + stalling. For example the OS, in order to handle a stalled transaction, > + may attempt to retrieve pages from secondary storage in a stalled > + domain, leading to a deadlock. > + > +- pasid-bits: Some masters support multiple address spaces for DMA. By > + tagging DMA transactions with an address space identifier. By default, > + this is 0, which means that the device only has one address space. > + > > Notes: > ====== > -- > 2.13.3 >
On 13/10/17 20:10, Rob Herring wrote: > On Fri, Oct 06, 2017 at 02:31:39PM +0100, Jean-Philippe Brucker wrote: >> On ARM systems, some platform devices behind an IOMMU may support stall >> and PASID features. Stall is the ability to recover from page faults and >> PASID offers multiple process address spaces to the device. Together they >> allow to do paging with a device. Let the firmware tell us when a device >> supports stall and PASID. > > Can't these be implied by the compatible string of the devices? I think that PASID capacity can be deduced from the compatible string but don't know how these devices will be implemented (the only known example being a software model for testing). In any case implementing PASID based on the compatible string is tricky, because the IOMMU driver needs to know PASID capacity before the device driver has had time to probe the device. Maybe we could get away with a static table associating compatible string to PASID capacity, but it's not very nice. For stall it's a property of the integration between device and IOMMU, much like the "iommus" property, so it can't be deduced only from the compatible string. It's crucial that the firmware validates that stalling is safe, because we don't have any other way to discover it. Thanks, Jean
On Mon, Oct 16, 2017 at 5:23 AM, Jean-Philippe Brucker <jean-philippe.brucker@arm.com> wrote: > On 13/10/17 20:10, Rob Herring wrote: >> On Fri, Oct 06, 2017 at 02:31:39PM +0100, Jean-Philippe Brucker wrote: >>> On ARM systems, some platform devices behind an IOMMU may support stall >>> and PASID features. Stall is the ability to recover from page faults and >>> PASID offers multiple process address spaces to the device. Together they >>> allow to do paging with a device. Let the firmware tell us when a device >>> supports stall and PASID. >> >> Can't these be implied by the compatible string of the devices? > > I think that PASID capacity can be deduced from the compatible string but > don't know how these devices will be implemented (the only known example > being a software model for testing). In any case implementing PASID based > on the compatible string is tricky, because the IOMMU driver needs to know > PASID capacity before the device driver has had time to probe the device. > Maybe we could get away with a static table associating compatible string > to PASID capacity, but it's not very nice. > > For stall it's a property of the integration between device and IOMMU, > much like the "iommus" property, so it can't be deduced only from the > compatible string. It's crucial that the firmware validates that stalling > is safe, because we don't have any other way to discover it. Okay, fair enough. I'll let others comment. Rob
diff --git a/Documentation/devicetree/bindings/iommu/iommu.txt b/Documentation/devicetree/bindings/iommu/iommu.txt index 5a8b4624defc..c589b75f7277 100644 --- a/Documentation/devicetree/bindings/iommu/iommu.txt +++ b/Documentation/devicetree/bindings/iommu/iommu.txt @@ -86,6 +86,30 @@ have a means to turn off translation. But it is invalid in such cases to disable the IOMMU's device tree node in the first place because it would prevent any driver from properly setting up the translations. +Optional properties: +-------------------- +- dma-can-stall: When present, the master can wait for a transaction to + complete for an indefinite amount of time. Upon translation fault some + IOMMUs, instead of aborting the translation immediately, may first + notify the driver and keep the transaction in flight. This allows the OS + to inspect the fault and, for example, make physical pages resident + before updating the mappings and completing the transaction. Such IOMMU + accepts a limited number of simultaneous stalled transactions before + having to either put back-pressure on the master, or abort new faulting + transactions. + + Firmware has to opt-in stalling, because most buses and masters don't + support it. In particular it isn't compatible with PCI, where + transactions have to complete before a time limit. More generally it + won't work in systems and masters that haven't been designed for + stalling. For example the OS, in order to handle a stalled transaction, + may attempt to retrieve pages from secondary storage in a stalled + domain, leading to a deadlock. + +- pasid-bits: Some masters support multiple address spaces for DMA. By + tagging DMA transactions with an address space identifier. By default, + this is 0, which means that the device only has one address space. + Notes: ======
On ARM systems, some platform devices behind an IOMMU may support stall and PASID features. Stall is the ability to recover from page faults and PASID offers multiple process address spaces to the device. Together they allow to do paging with a device. Let the firmware tell us when a device supports stall and PASID. Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> --- Documentation/devicetree/bindings/iommu/iommu.txt | 24 +++++++++++++++++++++++ 1 file changed, 24 insertions(+)