| Message ID | 1508506702-17704-8-git-send-email-ian.jackson@eu.citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Ian Jackson writes ("[PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash"):
> This makes it much easier to find a particular thing in config.log.
>
> The information may be lacking in other shells, resulting in harmless
> empty output. (This is why we don't use the proper ${FUNCNAME[*]}
> array syntax - other shells will choke on that.)
>
> The extra output is only printed if configure is run with bash. The
> something), it is necessary to say bash ./configure to get the extra
> debug info in the log.
Kent Spillner points out that this last sentence is garbled. The
paragraph should read:
The extra output is only printed if configure is run with bash. On
systems where /bin/sh is not bash, it is necessary to say bash
./configure to get the extra debug info in the log.
I have updated it in my branch.
Ian.
CC'ing the maintainers for this. On Fri, 20 Oct 2017, Ian Jackson wrote: > This makes it much easier to find a particular thing in config.log. > > The information may be lacking in other shells, resulting in harmless > empty output. (This is why we don't use the proper ${FUNCNAME[*]} > array syntax - other shells will choke on that.) > > The extra output is only printed if configure is run with bash. The > something), it is necessary to say bash ./configure to get the extra > debug info in the log. > > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> > --- > v4: No longer tag this patch RFC. > --- > configure | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index 6f691df..21a2b15 100755 > --- a/configure > +++ b/configure > @@ -60,6 +60,10 @@ do_compiler() { > # is compiler binary to execute. > local compiler="$1" > shift > + echo >>config.log " > +funcs: ${FUNCNAME} > +lines: ${BASH_LINENO} > +files: ${BASH_SOURCE}" > echo $compiler "$@" >> config.log > $compiler "$@" >> config.log 2>&1 || return $? > # Test passed. If this is an --enable-werror build, rerun > -- > 2.1.4 >
Stefano Stabellini writes ("Re: [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash"):
> CC'ing the maintainers for this.
Thanks, but scripts/get_maintainer.pl seems to print different
information for me... (see my other mail)
Ian.
diff --git a/configure b/configure index 6f691df..21a2b15 100755 --- a/configure +++ b/configure @@ -60,6 +60,10 @@ do_compiler() { # is compiler binary to execute. local compiler="$1" shift + echo >>config.log " +funcs: ${FUNCNAME} +lines: ${BASH_LINENO} +files: ${BASH_SOURCE}" echo $compiler "$@" >> config.log $compiler "$@" >> config.log 2>&1 || return $? # Test passed. If this is an --enable-werror build, rerun
This makes it much easier to find a particular thing in config.log. The information may be lacking in other shells, resulting in harmless empty output. (This is why we don't use the proper ${FUNCNAME[*]} array syntax - other shells will choke on that.) The extra output is only printed if configure is run with bash. The something), it is necessary to say bash ./configure to get the extra debug info in the log. Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> --- v4: No longer tag this patch RFC. --- configure | 4 ++++ 1 file changed, 4 insertions(+)