diff mbox

tools/hotplug: create XEN_LOG_DIR at runtime

Message ID 1509123157-23914-1-git-send-email-andrii.anisov@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andrii Anisov Oct. 27, 2017, 4:52 p.m. UTC 
From: Andrii Anisov <andrii_anisov@epam.com>

/var/log could be a tmpfs mount point, so create xen subfolder at runtime.

Signed-off-by: Andrii Anisov <andrii_anisov@epam.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 tools/hotplug/Linux/init.d/xencommons.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Wei Liu Oct. 27, 2017, 5:22 p.m. UTC | #1 
On Fri, Oct 27, 2017 at 07:52:37PM +0300, Andrii Anisov wrote:
> From: Andrii Anisov <andrii_anisov@epam.com>
> 
> /var/log could be a tmpfs mount point, so create xen subfolder at runtime.
> 
> Signed-off-by: Andrii Anisov <andrii_anisov@epam.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

Julien I think we should apply this for 4.10.
Ian Jackson Oct. 30, 2017, 2:39 p.m. UTC | #2 
Wei Liu writes ("Re: [PATCH] tools/hotplug: create XEN_LOG_DIR at runtime"):
> On Fri, Oct 27, 2017 at 07:52:37PM +0300, Andrii Anisov wrote:
> > From: Andrii Anisov <andrii_anisov@epam.com>
> > 
> > /var/log could be a tmpfs mount point, so create xen subfolder at runtime.
> > 
> > Signed-off-by: Andrii Anisov <andrii_anisov@epam.com>
> > Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> Julien I think we should apply this for 4.10.

I agree.  Subject line tag added.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Ian.
Julien Grall Nov. 2, 2017, 1:51 p.m. UTC | #3 
On 30/10/17 14:39, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] tools/hotplug: create XEN_LOG_DIR at runtime"):
>> On Fri, Oct 27, 2017 at 07:52:37PM +0300, Andrii Anisov wrote:
>>> From: Andrii Anisov <andrii_anisov@epam.com>
>>>
>>> /var/log could be a tmpfs mount point, so create xen subfolder at runtime.
>>>
>>> Signed-off-by: Andrii Anisov <andrii_anisov@epam.com>
>>> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>>> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>> Acked-by: Wei Liu <wei.liu2@citrix.com>
>>
>> Julien I think we should apply this for 4.10.
> 
> I agree.  Subject line tag added.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Release-acked-by: Julien Grall <julien.grall@linaro.org>

Cheers,

> 
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>
diff mbox

Patch

diff --git a/tools/hotplug/Linux/init.d/xencommons.in b/tools/hotplug/Linux/init.d/xencommons.in
index a6a40d6..ec42b05 100644
--- a/tools/hotplug/Linux/init.d/xencommons.in
+++ b/tools/hotplug/Linux/init.d/xencommons.in
@@ -58,6 +58,7 @@  do_start () {
 
 	mkdir -p ${XEN_RUN_DIR}
 	mkdir -p ${XEN_LOCK_DIR}
+	mkdir -p ${XEN_LOG_DIR}
 
 	@XEN_SCRIPT_DIR@/launch-xenstore || exit 1