diff mbox

[v3] display: panel: Add Mitsubishi aa070mc01 display support (800x480)

Message ID 1508537917-1723-1-git-send-email-lukma@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Lukasz Majewski Oct. 20, 2017, 10:18 p.m. UTC
This commit adds support for Mitsubishi aa070mc01 TFT panel working
with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
Changes for v2:
- Place the code sorted alphabetically
- Add missing ./Documentation/devicetree/binding/display properties
  description

Changes for v3:
- Fix typo in display name (in property description)

---
 .../display/panel/mitsubishi,aa070mc01.txt         |  7 +++++
 drivers/gpu/drm/panel/panel-simple.c               | 35 ++++++++++++++++++++++
 2 files changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt

Comments

Lukasz Majewski Nov. 5, 2017, 10:20 p.m. UTC | #1
Dear All,

> This commit adds support for Mitsubishi aa070mc01 TFT panel working
> with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).

Gentle ping...

> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> Changes for v2:
> - Place the code sorted alphabetically
> - Add missing ./Documentation/devicetree/binding/display properties
>   description
> 
> Changes for v3:
> - Fix typo in display name (in property description)
> 
> ---
>  .../display/panel/mitsubishi,aa070mc01.txt         |  7 +++++
>  drivers/gpu/drm/panel/panel-simple.c               | 35
> ++++++++++++++++++++++ 2 files changed, 42 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt
> 
> diff --git
> a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt
> b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt
> new file mode 100644 index 0000000..4f5094f --- /dev/null
> +++
> b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt
> @@ -0,0 +1,7 @@ +Mitsubishi "AA070MC01 7.0" WVGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "mitsubishi,aa070mc01-ca1"
> +
> +This binding is compatible with the simple-panel binding, which is
> specified +in simple-panel.txt in this directory.
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index 07188dc..72a20fc 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1350,6 +1350,38 @@ static const struct panel_desc lg_lp129qe = {
>  	},
>  };
>  
> +static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> +	.clock = 30400,
> +	.hdisplay = 800,
> +	.hsync_start = 800 + 0,
> +	.hsync_end = 800 + 1,
> +	.htotal = 800 + 0 + 1 + 160,
> +	.vdisplay = 480,
> +	.vsync_start = 480 + 0,
> +	.vsync_end = 480 + 48 + 1,
> +	.vtotal = 480 + 48 + 1 + 0,
> +	.vrefresh = 60,
> +	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc mitsubishi_aa070mc01 = {
> +	.modes = &mitsubishi_aa070mc01_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 152,
> +		.height = 91,
> +	},
> +
> +	.delay = {
> +		.enable = 200,
> +		.unprepare = 200,
> +		.disable = 400,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +};
> +
>  static const struct display_timing nec_nl12880bc20_05_timing = {
>  	.pixelclock = { 67000000, 71000000, 75000000 },
>  	.hactive = { 1280, 1280, 1280 },
> @@ -2080,6 +2112,9 @@ static const struct of_device_id
> platform_of_match[] = { .compatible = "lg,lp129qe",
>  		.data = &lg_lp129qe,
>  	}, {
> +		.compatible = "mitsubishi,aa070mc01-ca1",
> +		.data = &mitsubishi_aa070mc01,
> +	}, {
>  		.compatible = "nec,nl12880bc20-05",
>  		.data = &nec_nl12880bc20_05,
>  	}, {



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Rob Herring Nov. 6, 2017, 2:08 p.m. UTC | #2
On Fri, Oct 20, 2017 at 5:18 PM, Lukasz Majewski <lukma@denx.de> wrote:
> This commit adds support for Mitsubishi aa070mc01 TFT panel working
> with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> Changes for v2:
> - Place the code sorted alphabetically
> - Add missing ./Documentation/devicetree/binding/display properties
>   description
>
> Changes for v3:
> - Fix typo in display name (in property description)
>
> ---
>  .../display/panel/mitsubishi,aa070mc01.txt         |  7 +++++
>  drivers/gpu/drm/panel/panel-simple.c               | 35 ++++++++++++++++++++++
>  2 files changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt

Acked-by: Rob Herring <robh@kernel.org>
Lukasz Majewski Nov. 17, 2017, 10:03 a.m. UTC | #3
Dear All,

> On Fri, Oct 20, 2017 at 5:18 PM, Lukasz Majewski <lukma@denx.de>
> wrote:
> > This commit adds support for Mitsubishi aa070mc01 TFT panel working
> > with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> > Changes for v2:
> > - Place the code sorted alphabetically
> > - Add missing ./Documentation/devicetree/binding/display properties
> >   description
> >
> > Changes for v3:
> > - Fix typo in display name (in property description)
> >
> > ---
> >  .../display/panel/mitsubishi,aa070mc01.txt         |  7 +++++
> >  drivers/gpu/drm/panel/panel-simple.c               | 35
> > ++++++++++++++++++++++ 2 files changed, 42 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt  
> 
> Acked-by: Rob Herring <robh@kernel.org>

Is there a chance that this patch will find its way to v4.15-rc1 ?

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt
new file mode 100644
index 0000000..4f5094f
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa070mc01.txt
@@ -0,0 +1,7 @@ 
+Mitsubishi "AA070MC01 7.0" WVGA TFT LCD panel
+
+Required properties:
+- compatible: should be "mitsubishi,aa070mc01-ca1"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 07188dc..72a20fc 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1350,6 +1350,38 @@  static const struct panel_desc lg_lp129qe = {
 	},
 };
 
+static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
+	.clock = 30400,
+	.hdisplay = 800,
+	.hsync_start = 800 + 0,
+	.hsync_end = 800 + 1,
+	.htotal = 800 + 0 + 1 + 160,
+	.vdisplay = 480,
+	.vsync_start = 480 + 0,
+	.vsync_end = 480 + 48 + 1,
+	.vtotal = 480 + 48 + 1 + 0,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc mitsubishi_aa070mc01 = {
+	.modes = &mitsubishi_aa070mc01_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 152,
+		.height = 91,
+	},
+
+	.delay = {
+		.enable = 200,
+		.unprepare = 200,
+		.disable = 400,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+};
+
 static const struct display_timing nec_nl12880bc20_05_timing = {
 	.pixelclock = { 67000000, 71000000, 75000000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -2080,6 +2112,9 @@  static const struct of_device_id platform_of_match[] = {
 		.compatible = "lg,lp129qe",
 		.data = &lg_lp129qe,
 	}, {
+		.compatible = "mitsubishi,aa070mc01-ca1",
+		.data = &mitsubishi_aa070mc01,
+	}, {
 		.compatible = "nec,nl12880bc20-05",
 		.data = &nec_nl12880bc20_05,
 	}, {