| Message ID | 20171109210311.25655-4-jeremy.linton@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Nov 09, 2017 at 03:03:05PM -0600, Jeremy Linton wrote: > Its helpful to be able to lookup the acpi_processor_id > associated with a logical cpu. Provide an arm64 > helper to do this. > > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com> > --- > arch/arm64/include/asm/acpi.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > index 59cca1d6ec54..408e7989d3a2 100644 > --- a/arch/arm64/include/asm/acpi.h > +++ b/arch/arm64/include/asm/acpi.h > @@ -86,6 +86,10 @@ static inline bool acpi_has_cpu_in_madt(void) > } > > struct acpi_madt_generic_interrupt *acpi_cpu_get_madt_gicc(int cpu); > +static inline u32 get_acpi_id_for_cpu(unsigned int cpu) > +{ > + return acpi_cpu_get_madt_gicc(cpu)->uid; > +} If I followed the series correctly, this function is used in 2/9 already. So this needs to be moved down in the series to avoid build failure during bisection. -- Regards, Sudeep
Hi, On 11/20/2017 11:06 AM, Sudeep Holla wrote: > On Thu, Nov 09, 2017 at 03:03:05PM -0600, Jeremy Linton wrote: >> Its helpful to be able to lookup the acpi_processor_id >> associated with a logical cpu. Provide an arm64 >> helper to do this. >> >> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com> >> --- >> arch/arm64/include/asm/acpi.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h >> index 59cca1d6ec54..408e7989d3a2 100644 >> --- a/arch/arm64/include/asm/acpi.h >> +++ b/arch/arm64/include/asm/acpi.h >> @@ -86,6 +86,10 @@ static inline bool acpi_has_cpu_in_madt(void) >> } >> >> struct acpi_madt_generic_interrupt *acpi_cpu_get_madt_gicc(int cpu); >> +static inline u32 get_acpi_id_for_cpu(unsigned int cpu) >> +{ >> + return acpi_cpu_get_madt_gicc(cpu)->uid; >> +} > > If I followed the series correctly, this function is used in 2/9 already. > So this needs to be moved down in the series to avoid build failure during > bisection. I don't believe there is a bisection failure here because the code using this routine is not yet being compiled until the 4/9.
On Mon, Nov 20, 2017 at 11:09:47AM -0600, Jeremy Linton wrote: > Hi, > > On 11/20/2017 11:06 AM, Sudeep Holla wrote: > >On Thu, Nov 09, 2017 at 03:03:05PM -0600, Jeremy Linton wrote: > >>Its helpful to be able to lookup the acpi_processor_id > >>associated with a logical cpu. Provide an arm64 > >>helper to do this. > >> > >>Signed-off-by: Jeremy Linton <jeremy.linton@arm.com> > >>--- > >> arch/arm64/include/asm/acpi.h | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >>diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > >>index 59cca1d6ec54..408e7989d3a2 100644 > >>--- a/arch/arm64/include/asm/acpi.h > >>+++ b/arch/arm64/include/asm/acpi.h > >>@@ -86,6 +86,10 @@ static inline bool acpi_has_cpu_in_madt(void) > >> } > >> struct acpi_madt_generic_interrupt *acpi_cpu_get_madt_gicc(int cpu); > >>+static inline u32 get_acpi_id_for_cpu(unsigned int cpu) > >>+{ > >>+ return acpi_cpu_get_madt_gicc(cpu)->uid; > >>+} > > > >If I followed the series correctly, this function is used in 2/9 already. > >So this needs to be moved down in the series to avoid build failure during > >bisection. > > I don't believe there is a bisection failure here because the code using > this routine is not yet being compiled until the 4/9. > OK, I see. It's good to have definition ready before you use generally, up to you. -- Regards, Sudeep
diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index 59cca1d6ec54..408e7989d3a2 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -86,6 +86,10 @@ static inline bool acpi_has_cpu_in_madt(void) } struct acpi_madt_generic_interrupt *acpi_cpu_get_madt_gicc(int cpu); +static inline u32 get_acpi_id_for_cpu(unsigned int cpu) +{ + return acpi_cpu_get_madt_gicc(cpu)->uid; +} static inline void arch_fix_phys_package_id(int num, u32 slot) { } void __init acpi_init_cpus(void);
Its helpful to be able to lookup the acpi_processor_id associated with a logical cpu. Provide an arm64 helper to do this. Signed-off-by: Jeremy Linton <jeremy.linton@arm.com> --- arch/arm64/include/asm/acpi.h | 4 ++++ 1 file changed, 4 insertions(+)