Message ID | 20171127124450.28799-4-jeremy@azazel.net (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Mon, 27 Nov 2017 12:44:50 +0000
Jeremy Sowden <jeremy@azazel.net> wrote:
> Changed the types of some arrays from int16_t to s16W
Which are the same type, except int16_t is the standard form.
No point.
Alan
On 2017-11-27, at 19:09:38 +0000, Alan Cox wrote: > On Mon, 27 Nov 2017 12:44:50 +0000 Jeremy Sowden wrote: > > Changed the types of some arrays from int16_t to s16 > > Which are the same type, except int16_t is the standard form. > > No point. Righto, so this would be one of those cases in which I should have exercised judgment: checkpatch suggested preferring the kernel's own types, but it wasn't a reason to change existing code. Thanks for the feedback. J.
Fixed some sparse warnings in the Atom ISP staging driver. This time with longer commit messages. :) I've chosen to ignore checkpatch.pl's suggestion to change the types of the arrays in the second patch from int16_t to s16. Jeremy Sowden (2): media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings. media: staging: atomisp: fixes for "symbol was not declared. Should it be static?" sparse warnings. .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++++----------- .../isp_param/interface/ia_css_isp_param_types.h | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) base-commit: 844056fd74ebdd826bd23a7d989597e15f478acb
On Tue, Nov 28, 2017 at 10:27:24AM +0000, Jeremy Sowden wrote: > Fixed some sparse warnings in the Atom ISP staging driver. > > This time with longer commit messages. :) > > I've chosen to ignore checkpatch.pl's suggestion to change the types of > the arrays in the second patch from int16_t to s16. > > Jeremy Sowden (2): > media: staging: atomisp: fix for sparse "using plain integer as NULL > pointer" warnings. > media: staging: atomisp: fixes for "symbol was not declared. Should it > be static?" sparse warnings. > > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++++----------- > .../isp_param/interface/ia_css_isp_param_types.h | 2 +- > 2 files changed, 13 insertions(+), 13 deletions(-) Thanks, applied!
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c index 47bb5042381b..af6c8688876d 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c @@ -32,47 +32,46 @@ #define NUMBER_OF_TCINV_POINTS 9 #define NUMBER_OF_FCINV_POINTS 9 -static const int16_t chgrinv_x[NUMBER_OF_CHGRINV_POINTS] = { +static const s16 chgrinv_x[NUMBER_OF_CHGRINV_POINTS] = { 0, 16, 64, 144, 272, 448, 672, 976, 1376, 1888, 2528, 3312, 4256, 5376, 6688}; -static const int16_t chgrinv_a[NUMBER_OF_CHGRINV_POINTS] = { +static const s16 chgrinv_a[NUMBER_OF_CHGRINV_POINTS] = { -7171, -256, -29, -3456, -1071, -475, -189, -102, -48, -38, -10, -9, -7, -6, 0}; -static const int16_t chgrinv_b[NUMBER_OF_CHGRINV_POINTS] = { +static const s16 chgrinv_b[NUMBER_OF_CHGRINV_POINTS] = { 8191, 1021, 256, 114, 60, 37, 24, 17, 12, 9, 6, 5, 4, 3, 2}; -static const int16_t chgrinv_c[NUMBER_OF_CHGRINV_POINTS] = { +static const s16 chgrinv_c[NUMBER_OF_CHGRINV_POINTS] = { 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; -static const int16_t tcinv_x[NUMBER_OF_TCINV_POINTS] = { +static const s16 tcinv_x[NUMBER_OF_TCINV_POINTS] = { 0, 4, 11, 23, 42, 68, 102, 148, 205}; -static const int16_t tcinv_a[NUMBER_OF_TCINV_POINTS] = { +static const s16 tcinv_a[NUMBER_OF_TCINV_POINTS] = { -6364, -631, -126, -34, -13, -6, -4452, -2156, 0}; -static const int16_t tcinv_b[NUMBER_OF_TCINV_POINTS] = { +static const s16 tcinv_b[NUMBER_OF_TCINV_POINTS] = { 8191, 1828, 726, 352, 197, 121, 80, 55, 40}; -static const int16_t tcinv_c[NUMBER_OF_TCINV_POINTS] = { +static const s16 tcinv_c[NUMBER_OF_TCINV_POINTS] = { 1, 1, 1, 1, 1, 1, 0, 0, 0}; -static const int16_t fcinv_x[NUMBER_OF_FCINV_POINTS] = { +static const s16 fcinv_x[NUMBER_OF_FCINV_POINTS] = { 0, 80, 216, 456, 824, 1344, 2040, 2952, 4096}; -static const int16_t fcinv_a[NUMBER_OF_FCINV_POINTS] = { +static const s16 fcinv_a[NUMBER_OF_FCINV_POINTS] = { -5244, -486, -86, -2849, -961, -400, -180, -86, 0}; -static const int16_t fcinv_b[NUMBER_OF_FCINV_POINTS] = { +static const s16 fcinv_b[NUMBER_OF_FCINV_POINTS] = { 8191, 1637, 607, 287, 159, 98, 64, 44, 32}; -static const int16_t fcinv_c[NUMBER_OF_FCINV_POINTS] = { +static const s16 fcinv_c[NUMBER_OF_FCINV_POINTS] = { 1, 1, 1, 0, 0, 0, 0, 0, 0}; - void ia_css_eed1_8_vmem_encode( struct eed1_8_vmem_params *to,
Changed the types of some arrays from int16_t to s16. Signed-off-by: Jeremy Sowden <jeremy@azazel.net> --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 25 +++++++++++----------- 1 file changed, 12 insertions(+), 13 deletions(-)