| Message ID | 1512096776-22883-4-git-send-email-okaya@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sinan, Thanks for the patch. On Thu, Nov 30, 2017 at 09:52:54PM -0500, Sinan Kaya wrote: > There is an OF/ACPI function to obtain the driver data. We want to hide > OF/ACPI details from the device drivers and abstract following the device > family of functions. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > drivers/base/property.c | 14 ++++++++++++++ > include/linux/property.h | 2 ++ > 2 files changed, 16 insertions(+) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 7ed99c1..6adec89 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -15,6 +15,7 @@ > #include <linux/kernel.h> > #include <linux/of.h> > #include <linux/of_address.h> > +#include <linux/of_device.h> > #include <linux/of_graph.h> > #include <linux/property.h> > #include <linux/etherdevice.h> > @@ -1335,3 +1336,16 @@ int fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, > return fwnode_call_int_op(fwnode, graph_parse_endpoint, endpoint); > } > EXPORT_SYMBOL(fwnode_graph_parse_endpoint); > + > +void *device_get_match_data(struct device *dev) > +{ > + void *ret; > + > + if (IS_ENABLED(CONFIG_OF) && dev->of_node) Most of the dev->of_node checks have been removed from property.c and replaced by calls to the firmware specific fwnode operations. What remains should probably be moved there, too (apart from dev_fwnode). How about adding a new op for this one to struct fwnode_operations in include/linux/fwnode.h? > + ret = (void *)of_device_get_match_data(dev); > + else > + ret = acpi_get_match_data(dev); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(device_get_match_data); > diff --git a/include/linux/property.h b/include/linux/property.h > index 6bebee1..01fa55b 100644 > --- a/include/linux/property.h > +++ b/include/linux/property.h > @@ -275,6 +275,8 @@ int device_add_properties(struct device *dev, > > enum dev_dma_attr device_get_dma_attr(struct device *dev); > > +void *device_get_match_data(struct device *dev); > + > int device_get_phy_mode(struct device *dev); > > void *device_get_mac_address(struct device *dev, char *addr, int alen);
On 12/1/2017 4:13 AM, Sakari Ailus wrote: > Most of the dev->of_node checks have been removed from property.c and > replaced by calls to the firmware specific fwnode operations. What remains > should probably be moved there, too (apart from dev_fwnode). > > How about adding a new op for this one to struct fwnode_operations in > include/linux/fwnode.h? Sure, let me look. I was following the get_dma function. Bad example I guess.
diff --git a/drivers/base/property.c b/drivers/base/property.c index 7ed99c1..6adec89 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -15,6 +15,7 @@ #include <linux/kernel.h> #include <linux/of.h> #include <linux/of_address.h> +#include <linux/of_device.h> #include <linux/of_graph.h> #include <linux/property.h> #include <linux/etherdevice.h> @@ -1335,3 +1336,16 @@ int fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, return fwnode_call_int_op(fwnode, graph_parse_endpoint, endpoint); } EXPORT_SYMBOL(fwnode_graph_parse_endpoint); + +void *device_get_match_data(struct device *dev) +{ + void *ret; + + if (IS_ENABLED(CONFIG_OF) && dev->of_node) + ret = (void *)of_device_get_match_data(dev); + else + ret = acpi_get_match_data(dev); + + return ret; +} +EXPORT_SYMBOL_GPL(device_get_match_data); diff --git a/include/linux/property.h b/include/linux/property.h index 6bebee1..01fa55b 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -275,6 +275,8 @@ int device_add_properties(struct device *dev, enum dev_dma_attr device_get_dma_attr(struct device *dev); +void *device_get_match_data(struct device *dev); + int device_get_phy_mode(struct device *dev); void *device_get_mac_address(struct device *dev, char *addr, int alen);
There is an OF/ACPI function to obtain the driver data. We want to hide OF/ACPI details from the device drivers and abstract following the device family of functions. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- drivers/base/property.c | 14 ++++++++++++++ include/linux/property.h | 2 ++ 2 files changed, 16 insertions(+)