diff mbox

[V7,2/2] dt-bindings: Add qcom spmi_pmic clock divider bindings

Message ID 1511255465-3984-3-git-send-email-tirupath@codeaurora.org (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Tirupathi Reddy Nov. 21, 2017, 9:11 a.m. UTC 
This patch adds device tree bindings for Qualcomm SPMI PMIC
clock divider module.

Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
---
 .../bindings/clock/qcom,spmi-pmic-div.txt          | 59 ++++++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt

Comments

Rob Herring (Arm) Dec. 4, 2017, 8:29 p.m. UTC | #1 
On Tue, Nov 21, 2017 at 02:41:05PM +0530, Tirupathi Reddy wrote:
> This patch adds device tree bindings for Qualcomm SPMI PMIC
> clock divider module.
> 
> Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
> ---
>  .../bindings/clock/qcom,spmi-pmic-div.txt          | 59 ++++++++++++++++++++++

Didn't Stephen say to move this somewhere else?

>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt b/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt
> new file mode 100644
> index 0000000..2cf2aba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt
> @@ -0,0 +1,59 @@
> +Qualcomm Technologies, Inc. SPMI PMIC clock divider (clkdiv)
> +
> +clkdiv configures the clock frequency of a set of outputs on the PMIC.
> +These clocks are typically wired through alternate functions on
> +gpio pins.
> +
> +=======================
> +Properties
> +=======================
> +
> +- compatible
> +	Usage:      required
> +	Value type: <string>
> +	Definition: must be "qcom,spmi-clkdiv".
> +
> +- reg
> +	Usage:      required
> +	Value type: <prop-encoded-array>
> +	Definition: base address of CLKDIV peripherals.
> +
> +- qcom,num-clkdivs
> +	Usage:      required
> +	Value type: <u32>
> +	Definition: number of CLKDIV peripherals.
> +
> +- clocks:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: reference to the xo clock.
> +
> +- clock-names:
> +	Usage: required
> +	Value type: <stringlist>
> +	Definition: must be "xo".
> +
> +- clock-cells:

#clock-cells

> +	Usage: required
> +	Value type: <u32>
> +	Definition: shall contain 1.
> +
> +=======
> +Example
> +=======
> +
> +pm8998_clk_divs: clock-controller@5b00 {
> +	compatible = "qcom,spmi-clkdiv";
> +	reg = <0x5b00>;
> +	#clock-cells = <1>;
> +	qcom,num-clkdivs = <3>;
> +	clocks = <&xo_board>;
> +	clock-names = "xo";
> +
> +	assigned-clocks = <&pm8998_clk_divs 1>,
> +			  <&pm8998_clk_divs 2>,
> +			  <&pm8998_clk_divs 3>;
> +	assigned-clock-rates = <9600000>,
> +			       <9600000>,
> +			       <9600000>;
> +};
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Boyd Dec. 7, 2017, 6:28 a.m. UTC | #2 
On 12/04, Rob Herring wrote:
> On Tue, Nov 21, 2017 at 02:41:05PM +0530, Tirupathi Reddy wrote:
> > This patch adds device tree bindings for Qualcomm SPMI PMIC
> > clock divider module.
> > 
> > Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
> > ---
> >  .../bindings/clock/qcom,spmi-pmic-div.txt          | 59 ++++++++++++++++++++++
> 
> Didn't Stephen say to move this somewhere else?

yeah I'll move it to qcom,spmi-clkdiv.txt

> > +
> > +- clock-cells:
> 
> #clock-cells
> 

And fix this. Thanks.
Stephen Boyd Dec. 7, 2017, 6:32 a.m. UTC | #3 
On 11/21, Tirupathi Reddy wrote:
> This patch adds device tree bindings for Qualcomm SPMI PMIC
> clock divider module.
> 
> Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
> ---

Applied to clk-next
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt b/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt
new file mode 100644
index 0000000..2cf2aba
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt
@@ -0,0 +1,59 @@ 
+Qualcomm Technologies, Inc. SPMI PMIC clock divider (clkdiv)
+
+clkdiv configures the clock frequency of a set of outputs on the PMIC.
+These clocks are typically wired through alternate functions on
+gpio pins.
+
+=======================
+Properties
+=======================
+
+- compatible
+	Usage:      required
+	Value type: <string>
+	Definition: must be "qcom,spmi-clkdiv".
+
+- reg
+	Usage:      required
+	Value type: <prop-encoded-array>
+	Definition: base address of CLKDIV peripherals.
+
+- qcom,num-clkdivs
+	Usage:      required
+	Value type: <u32>
+	Definition: number of CLKDIV peripherals.
+
+- clocks:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: reference to the xo clock.
+
+- clock-names:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be "xo".
+
+- clock-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: shall contain 1.
+
+=======
+Example
+=======
+
+pm8998_clk_divs: clock-controller@5b00 {
+	compatible = "qcom,spmi-clkdiv";
+	reg = <0x5b00>;
+	#clock-cells = <1>;
+	qcom,num-clkdivs = <3>;
+	clocks = <&xo_board>;
+	clock-names = "xo";
+
+	assigned-clocks = <&pm8998_clk_divs 1>,
+			  <&pm8998_clk_divs 2>,
+			  <&pm8998_clk_divs 3>;
+	assigned-clock-rates = <9600000>,
+			       <9600000>,
+			       <9600000>;
+};