| Message ID | 1512188864-773-2-git-send-email-okaya@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Dec 01, 2017 at 11:27:38PM -0500, Sinan Kaya wrote: > A new version of the HIDMA IP has been released with bug fixes. Bumping the > hardware version to differentiate from others. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > index 55492c2..5d93d6d 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > @@ -47,8 +47,8 @@ When the OS is not in control of the management interface (i.e. it's a guest), > the channel nodes appear on their own, not under a management node. > > Required properties: > -- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" > -for MSI capable HW. > +- compatible: must contain "qcom,hidma-1.0" for initial HW or > + "qcom,hidma-1.1"/"qcom,hidma-1.2" for MSI capable HW. Hopefully 1.2 corresponds to some actual version numbering and not just something you made up. I'd really rather have SoC based compatible strings unless you have dozens of SoCs for each version. I'll probably just say the same thing again when 1.3 or 2.0 gets added... Reviewed-by: Rob Herring <robh@kernel.org> > - reg: Addresses for the transfer and event channel > - interrupts: Should contain the event interrupt > - desc-count: Number of asynchronous requests this channel can handle > -- > 1.9.1 >
On 12/4/2017 5:14 PM, Rob Herring wrote: > Hopefully 1.2 corresponds to some actual version numbering and not just > something you made up. I'd really rather have SoC based compatible > strings unless you have dozens of SoCs for each version. I'll probably > just say the same thing again when 1.3 or 2.0 gets added... > No, these are coming from the HW. They are user visible. [ 107.167207] hidma-mgmt QCOM8060:00: HW rev: 1.2 @ 0x0000ffff8b800000 with 6 physical channels > Reviewed-by: Rob Herring <robh@kernel.org> Thanks
diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt index 55492c2..5d93d6d 100644 --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt @@ -47,8 +47,8 @@ When the OS is not in control of the management interface (i.e. it's a guest), the channel nodes appear on their own, not under a management node. Required properties: -- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" -for MSI capable HW. +- compatible: must contain "qcom,hidma-1.0" for initial HW or + "qcom,hidma-1.1"/"qcom,hidma-1.2" for MSI capable HW. - reg: Addresses for the transfer and event channel - interrupts: Should contain the event interrupt - desc-count: Number of asynchronous requests this channel can handle
A new version of the HIDMA IP has been released with bug fixes. Bumping the hardware version to differentiate from others. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)