| Message ID | 1512631227-27334-1-git-send-email-takuo.koguchi.sw@hitachi.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c810daba0ab5226084a56893a789af427a801146 |
| Headers | show |
Hi, On Thu, Dec 07, 2017 at 04:20:14PM +0900, Takuo Koguchi wrote: > mclk and hclk need to be disabled. Since pm_runtime_disable does > not disable the clocks, use pm_runtime_force_suspend instead. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@hitachi.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Maxime
On Thu, Dec 07, 2017 at 04:20:14PM +0900, Takuo Koguchi wrote: > mclk and hclk need to be disabled. Since pm_runtime_disable does > not disable the clocks, use pm_runtime_force_suspend instead. Please don't send new patches in reply to existing threads, it makes it harder to spot them.
diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c index c5cd635..4141003 100644 --- a/drivers/spi/spi-sun4i.c +++ b/drivers/spi/spi-sun4i.c @@ -525,7 +525,7 @@ static int sun4i_spi_probe(struct platform_device *pdev) static int sun4i_spi_remove(struct platform_device *pdev) { - pm_runtime_disable(&pdev->dev); + pm_runtime_force_suspend(&pdev->dev); return 0; }
mclk and hclk need to be disabled. Since pm_runtime_disable does not disable the clocks, use pm_runtime_force_suspend instead. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@hitachi.com> --- V3: remove redundant pm_runtime_disable call. Compile test only, no runtime test done. drivers/spi/spi-sun4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)