| Message ID | 20171214103011.24713-8-miquel.raynal@free-electrons.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Miquel, On jeu., déc. 14 2017, Miquel Raynal <miquel.raynal@free-electrons.com> wrote: > Update Armada thermal driver Kconfig entry as well as the driver's > MODULE_DESCRIPTION content, now that 64-bit SoCs are also supported, > eg. Armada 7K and Armada 8K. > > Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> > --- > drivers/thermal/Kconfig | 4 ++-- > drivers/thermal/armada_thermal.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 315ae2926e20..44cad046f272 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -301,13 +301,13 @@ config DB8500_THERMAL > thermal zone if trip points reached. > > config ARMADA_THERMAL > - tristate "Armada 370/XP thermal management" > + tristate "Armada 370/XP/7K/8K thermal management" if you want to be exhaustive you should also add Armada 375 and 38x. > depends on ARCH_MVEBU || COMPILE_TEST > depends on HAS_IOMEM > depends on OF > help > Enable this option if you want to have support for thermal management > - controller present in Armada 370 and Armada XP SoC. > + controller present in Armada 370, Armada XP, Armada 7K/8K > SoCs. here as well. Gregory > > config DA9062_THERMAL > tristate "DA9062/DA9061 Dialog Semiconductor thermal driver" > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c > index f5c911524656..da58a8961a37 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -403,5 +403,5 @@ static struct platform_driver armada_thermal_driver = { > module_platform_driver(armada_thermal_driver); > > MODULE_AUTHOR("Ezequiel Garcia <ezequiel.garcia@free-electrons.com>"); > -MODULE_DESCRIPTION("Armada 370/XP thermal driver"); > +MODULE_DESCRIPTION("Armada SoCs thermal driver"); > MODULE_LICENSE("GPL v2"); > -- > 2.11.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Gregory, On Thu, 14 Dec 2017 12:13:51 +0100 Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > Hi Miquel, > > On jeu., déc. 14 2017, Miquel Raynal > <miquel.raynal@free-electrons.com> wrote: > > > Update Armada thermal driver Kconfig entry as well as the driver's > > MODULE_DESCRIPTION content, now that 64-bit SoCs are also supported, > > eg. Armada 7K and Armada 8K. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> > > --- > > drivers/thermal/Kconfig | 4 ++-- > > drivers/thermal/armada_thermal.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 315ae2926e20..44cad046f272 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -301,13 +301,13 @@ config DB8500_THERMAL > > thermal zone if trip points reached. > > > > config ARMADA_THERMAL > > - tristate "Armada 370/XP thermal management" > > + tristate "Armada 370/XP/7K/8K thermal management" > if you want to be exhaustive you should also add Armada 375 and 38x. That is right, both are missing from the description, but wouldn't it be better to just state "Armada SoCs" instead of patching that file everythime a new SoC reuses this IP? Thanks, Miquèl
Hi Miquel, On jeu., déc. 14 2017, Miquel RAYNAL <miquel.raynal@free-electrons.com> wrote: > Hi Gregory, > > On Thu, 14 Dec 2017 12:13:51 +0100 > Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > >> Hi Miquel, >> >> On jeu., déc. 14 2017, Miquel Raynal >> <miquel.raynal@free-electrons.com> wrote: >> >> > Update Armada thermal driver Kconfig entry as well as the driver's >> > MODULE_DESCRIPTION content, now that 64-bit SoCs are also supported, >> > eg. Armada 7K and Armada 8K. >> > >> > Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> >> > --- >> > drivers/thermal/Kconfig | 4 ++-- >> > drivers/thermal/armada_thermal.c | 2 +- >> > 2 files changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> > index 315ae2926e20..44cad046f272 100644 >> > --- a/drivers/thermal/Kconfig >> > +++ b/drivers/thermal/Kconfig >> > @@ -301,13 +301,13 @@ config DB8500_THERMAL >> > thermal zone if trip points reached. >> > >> > config ARMADA_THERMAL >> > - tristate "Armada 370/XP thermal management" >> > + tristate "Armada 370/XP/7K/8K thermal management" >> if you want to be exhaustive you should also add Armada 375 and 38x. > > That is right, both are missing from the description, but wouldn't it > be better to just state "Armada SoCs" instead of patching that file > everythime a new SoC reuses this IP? Unfortunately Armada SoCs is more that just these SoC! Have a look on Documentation/arm/Marvell/README to see how the Marvell marketing guys had been creative :) Some kirkwood are called Armada 300 and Armada 310. The Dove is also called Armada 510. Some PXA are called Armada too such as Armada 168 or Armada 610. And finally the Berlin also use Aramda as code name: Armada 1000 or Aramda 1500 Gregory > > Thanks, > Miquèl >
Hi Gregory, On Thu, 14 Dec 2017 12:30:08 +0100 Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > Hi Miquel, > > On jeu., déc. 14 2017, Miquel RAYNAL > <miquel.raynal@free-electrons.com> wrote: > > > Hi Gregory, > > > > On Thu, 14 Dec 2017 12:13:51 +0100 > > Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > > > >> Hi Miquel, > >> > >> On jeu., déc. 14 2017, Miquel Raynal > >> <miquel.raynal@free-electrons.com> wrote: > >> > >> > Update Armada thermal driver Kconfig entry as well as the > >> > driver's MODULE_DESCRIPTION content, now that 64-bit SoCs are > >> > also supported, eg. Armada 7K and Armada 8K. > >> > > >> > Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> > >> > --- > >> > drivers/thermal/Kconfig | 4 ++-- > >> > drivers/thermal/armada_thermal.c | 2 +- > >> > 2 files changed, 3 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > >> > index 315ae2926e20..44cad046f272 100644 > >> > --- a/drivers/thermal/Kconfig > >> > +++ b/drivers/thermal/Kconfig > >> > @@ -301,13 +301,13 @@ config DB8500_THERMAL > >> > thermal zone if trip points reached. > >> > > >> > config ARMADA_THERMAL > >> > - tristate "Armada 370/XP thermal management" > >> > + tristate "Armada 370/XP/7K/8K thermal management" > >> if you want to be exhaustive you should also add Armada 375 and > >> 38x. > > > > That is right, both are missing from the description, but wouldn't > > it be better to just state "Armada SoCs" instead of patching that > > file everythime a new SoC reuses this IP? > > Unfortunately Armada SoCs is more that just these SoC! > > Have a look on Documentation/arm/Marvell/README to see how the Marvell > marketing guys had been creative :) > > Some kirkwood are called Armada 300 and Armada 310. > The Dove is also called Armada 510. > Some PXA are called Armada too such as Armada 168 or Armada 610. > And finally the Berlin also use Aramda as code name: Armada 1000 or > Aramda 1500 Ehr... Ok, I'll stick to "Armada 37x/38x/XP/7K/8K SoCs". Miquèl
Hello, On Thu, 14 Dec 2017 12:30:08 +0100, Gregory CLEMENT wrote: > Unfortunately Armada SoCs is more that just these SoC! > > Have a look on Documentation/arm/Marvell/README to see how the Marvell > marketing guys had been creative :) > > Some kirkwood are called Armada 300 and Armada 310. > The Dove is also called Armada 510. > Some PXA are called Armada too such as Armada 168 or Armada 610. > And finally the Berlin also use Aramda as code name: Armada 1000 or > Aramda 1500 However: "Marvell EBU Armada" should be distinctive enough. Thomas
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 315ae2926e20..44cad046f272 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -301,13 +301,13 @@ config DB8500_THERMAL thermal zone if trip points reached. config ARMADA_THERMAL - tristate "Armada 370/XP thermal management" + tristate "Armada 370/XP/7K/8K thermal management" depends on ARCH_MVEBU || COMPILE_TEST depends on HAS_IOMEM depends on OF help Enable this option if you want to have support for thermal management - controller present in Armada 370 and Armada XP SoC. + controller present in Armada 370, Armada XP, Armada 7K/8K SoCs. config DA9062_THERMAL tristate "DA9062/DA9061 Dialog Semiconductor thermal driver" diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index f5c911524656..da58a8961a37 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -403,5 +403,5 @@ static struct platform_driver armada_thermal_driver = { module_platform_driver(armada_thermal_driver); MODULE_AUTHOR("Ezequiel Garcia <ezequiel.garcia@free-electrons.com>"); -MODULE_DESCRIPTION("Armada 370/XP thermal driver"); +MODULE_DESCRIPTION("Armada SoCs thermal driver"); MODULE_LICENSE("GPL v2");
Update Armada thermal driver Kconfig entry as well as the driver's MODULE_DESCRIPTION content, now that 64-bit SoCs are also supported, eg. Armada 7K and Armada 8K. Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com> --- drivers/thermal/Kconfig | 4 ++-- drivers/thermal/armada_thermal.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)