| Message ID | 20171206003305.22895-1-javierm@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Em Wed, 6 Dec 2017 01:33:05 +0100 Javier Martinez Canillas <javierm@redhat.com> escreveu: > Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") > added input signals support for the tvp5150, but the approach was found > to be incorrect so the corresponding DT binding commit 82c2ffeb217a > ("[media] tvp5150: document input connectors DT bindings") was reverted. > > This left the driver with an undocumented (and wrong) DT parsing logic, > so lets get rid of this code as well until the input connectors support > is implemented properly. > > It's a partial revert due other patches added on top of mentioned commit > not allowing the commit to be reverted cleanly anymore. But all the code > related to the DT parsing logic and input entities creation are removed. > > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > This patch was posted about a year ago but was never merged: > > https://patchwork.kernel.org/patch/9472623/ It was a RFT, on that time. I guess I told that before. Maybe not. Anyway, reverting it doesn't seem to be the proper fix, as it will break support for existing devices, by removing functionality from tvp5150 driver. You should remind that, since the code was added, someone could be already using it, as all it is needed is to have some dtb. Also, it gets rid of a lot of good work for no good reason. Reinserting them later while preserving the code copyrights could be painful. IMHO, the best here is to move ahead, agreeing with a DT structure that represents the connectors and then change the driver to implement it, if needed. Thanks, Mauro
Hello Mauro, On 12/14/2017 06:02 PM, Mauro Carvalho Chehab wrote: > Em Wed, 6 Dec 2017 01:33:05 +0100 > Javier Martinez Canillas <javierm@redhat.com> escreveu: > >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >> added input signals support for the tvp5150, but the approach was found >> to be incorrect so the corresponding DT binding commit 82c2ffeb217a >> ("[media] tvp5150: document input connectors DT bindings") was reverted. >> >> This left the driver with an undocumented (and wrong) DT parsing logic, >> so lets get rid of this code as well until the input connectors support >> is implemented properly. >> >> It's a partial revert due other patches added on top of mentioned commit >> not allowing the commit to be reverted cleanly anymore. But all the code >> related to the DT parsing logic and input entities creation are removed. >> >> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> >> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> >> --- >> >> This patch was posted about a year ago but was never merged: >> >> https://patchwork.kernel.org/patch/9472623/ > > It was a RFT, on that time. > Yes, sorry if it sounded as if I was complaining. I was just mentioning and part of the patch falling through the cracks is that I also forgot about it. > I guess I told that before. Maybe not. Anyway, reverting it doesn't seem > to be the proper fix, as it will break support for existing devices, by > removing functionality from tvp5150 driver. You should remind that, since > the code was added, someone could be already using it, as all it is I'm not sure about this. What I'm removing is basically dead code (unless someone is using an undocumented Device Tree binding), since the DT binding got already removed by commit 31e717dba1e1 ("[media] Revert "[media] tvp5150: document input connectors DT bindings"). > needed is to have some dtb. Also, it gets rid of a lot of good work for > no good reason. Reinserting them later while preserving the code > copyrights could be painful. > I would normally agree with you, although I think that in this particular case is better to just revert this (unused) code for the reasons I mentioned above. But don't really have a strong opinion on this, so I'm OK with either approach. > IMHO, the best here is to move ahead, agreeing with a DT structure > that represents the connectors and then change the driver to > implement it, if needed. > There was some agreement on the DT binding, it's just that I never found time to implement the logic in the driver. Let's see if I can get some during the winter holidays and finally fix this. > Thanks, > Mauro > Best regards,
Em Thu, 14 Dec 2017 18:37:30 +0100 Javier Martinez Canillas <javierm@redhat.com> escreveu: > Hello Mauro, > > On 12/14/2017 06:02 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 6 Dec 2017 01:33:05 +0100 > > Javier Martinez Canillas <javierm@redhat.com> escreveu: > > > >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") > >> added input signals support for the tvp5150, but the approach was found > >> to be incorrect so the corresponding DT binding commit 82c2ffeb217a > >> ("[media] tvp5150: document input connectors DT bindings") was reverted. > >> > >> This left the driver with an undocumented (and wrong) DT parsing logic, > >> so lets get rid of this code as well until the input connectors support > >> is implemented properly. > >> > >> It's a partial revert due other patches added on top of mentioned commit > >> not allowing the commit to be reverted cleanly anymore. But all the code > >> related to the DT parsing logic and input entities creation are removed. > >> > >> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > >> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > >> > >> --- > >> > >> This patch was posted about a year ago but was never merged: > >> > >> https://patchwork.kernel.org/patch/9472623/ > > > > It was a RFT, on that time. > > > > Yes, sorry if it sounded as if I was complaining. I was just mentioning and > part of the patch falling through the cracks is that I also forgot about it. > > > I guess I told that before. Maybe not. Anyway, reverting it doesn't seem > > to be the proper fix, as it will break support for existing devices, by > > removing functionality from tvp5150 driver. You should remind that, since > > the code was added, someone could be already using it, as all it is > > I'm not sure about this. What I'm removing is basically dead code (unless > someone is using an undocumented Device Tree binding), since the DT binding > got already removed by commit 31e717dba1e1 ("[media] Revert "[media] tvp5150: > document input connectors DT bindings"). > > > needed is to have some dtb. Also, it gets rid of a lot of good work for > > no good reason. Reinserting them later while preserving the code > > copyrights could be painful. > > > > I would normally agree with you, although I think that in this particular case > is better to just revert this (unused) code for the reasons I mentioned above. > > But don't really have a strong opinion on this, so I'm OK with either approach. > > > IMHO, the best here is to move ahead, agreeing with a DT structure > > that represents the connectors and then change the driver to > > implement it, if needed. > > > > There was some agreement on the DT binding, it's just that I never found time > to implement the logic in the driver. Let's see if I can get some during the > winter holidays and finally fix this. Ok. This was pending for a long time to be touched. Waiting for a couple of weeks for a final solution seems worth. If you can't do that, by then, please ping us for us to seek for an alternative way to move forward. Thanks, Mauro
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index 7b79a7498751..a7c2c0c09a8d 100644 --- a/drivers/media/i2c/tvp5150.c +++ b/drivers/media/i2c/tvp5150.c @@ -43,8 +43,6 @@ struct tvp5150 { struct v4l2_subdev sd; #ifdef CONFIG_MEDIA_CONTROLLER struct media_pad pads[DEMOD_NUM_PADS]; - struct media_entity input_ent[TVP5150_INPUT_NUM]; - struct media_pad input_pad[TVP5150_INPUT_NUM]; #endif struct v4l2_ctrl_handler hdl; struct v4l2_rect rect; @@ -1015,40 +1013,6 @@ static int tvp5150_enum_frame_size(struct v4l2_subdev *sd, return 0; } -/**************************************************************************** - Media entity ops - ****************************************************************************/ - -#ifdef CONFIG_MEDIA_CONTROLLER -static int tvp5150_link_setup(struct media_entity *entity, - const struct media_pad *local, - const struct media_pad *remote, u32 flags) -{ - struct v4l2_subdev *sd = media_entity_to_v4l2_subdev(entity); - struct tvp5150 *decoder = to_tvp5150(sd); - int i; - - for (i = 0; i < TVP5150_INPUT_NUM; i++) { - if (remote->entity == &decoder->input_ent[i]) - break; - } - - /* Do nothing for entities that are not input connectors */ - if (i == TVP5150_INPUT_NUM) - return 0; - - decoder->input = i; - - tvp5150_selmux(sd); - - return 0; -} - -static const struct media_entity_operations tvp5150_sd_media_ops = { - .link_setup = tvp5150_link_setup, -}; -#endif - /**************************************************************************** I2C Command ****************************************************************************/ @@ -1186,42 +1150,6 @@ static int tvp5150_g_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt) return 0; } -static int tvp5150_registered(struct v4l2_subdev *sd) -{ -#ifdef CONFIG_MEDIA_CONTROLLER - struct tvp5150 *decoder = to_tvp5150(sd); - int ret = 0; - int i; - - for (i = 0; i < TVP5150_INPUT_NUM; i++) { - struct media_entity *input = &decoder->input_ent[i]; - struct media_pad *pad = &decoder->input_pad[i]; - - if (!input->name) - continue; - - decoder->input_pad[i].flags = MEDIA_PAD_FL_SOURCE; - - ret = media_entity_pads_init(input, 1, pad); - if (ret < 0) - return ret; - - ret = media_device_register_entity(sd->v4l2_dev->mdev, input); - if (ret < 0) - return ret; - - ret = media_create_pad_link(input, 0, &sd->entity, - DEMOD_PAD_IF_INPUT, 0); - if (ret < 0) { - media_device_unregister_entity(input); - return ret; - } - } -#endif - - return 0; -} - /* ----------------------------------------------------------------------- */ static const struct v4l2_ctrl_ops tvp5150_ctrl_ops = { @@ -1272,11 +1200,6 @@ static const struct v4l2_subdev_ops tvp5150_ops = { .pad = &tvp5150_pad_ops, }; -static const struct v4l2_subdev_internal_ops tvp5150_internal_ops = { - .registered = tvp5150_registered, -}; - - /**************************************************************************** I2C Client & Driver ****************************************************************************/ @@ -1358,12 +1281,6 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np) { struct v4l2_fwnode_endpoint bus_cfg; struct device_node *ep; -#ifdef CONFIG_MEDIA_CONTROLLER - struct device_node *connectors, *child; - struct media_entity *input; - const char *name; - u32 input_type; -#endif unsigned int flags; int ret = 0; @@ -1387,63 +1304,6 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np) decoder->mbus_type = bus_cfg.bus_type; -#ifdef CONFIG_MEDIA_CONTROLLER - connectors = of_get_child_by_name(np, "connectors"); - - if (!connectors) - goto err; - - for_each_available_child_of_node(connectors, child) { - ret = of_property_read_u32(child, "input", &input_type); - if (ret) { - dev_err(decoder->sd.dev, - "missing type property in node %s\n", - child->name); - goto err_connector; - } - - if (input_type >= TVP5150_INPUT_NUM) { - ret = -EINVAL; - goto err_connector; - } - - input = &decoder->input_ent[input_type]; - - /* Each input connector can only be defined once */ - if (input->name) { - dev_err(decoder->sd.dev, - "input %s with same type already exists\n", - input->name); - ret = -EINVAL; - goto err_connector; - } - - switch (input_type) { - case TVP5150_COMPOSITE0: - case TVP5150_COMPOSITE1: - input->function = MEDIA_ENT_F_CONN_COMPOSITE; - break; - case TVP5150_SVIDEO: - input->function = MEDIA_ENT_F_CONN_SVIDEO; - break; - } - - input->flags = MEDIA_ENT_FL_CONNECTOR; - - ret = of_property_read_string(child, "label", &name); - if (ret < 0) { - dev_err(decoder->sd.dev, - "missing label property in node %s\n", - child->name); - goto err_connector; - } - - input->name = name; - } - -err_connector: - of_node_put(connectors); -#endif err: of_node_put(ep); return ret; @@ -1489,7 +1349,6 @@ static int tvp5150_probe(struct i2c_client *c, } v4l2_i2c_subdev_init(sd, c, &tvp5150_ops); - sd->internal_ops = &tvp5150_internal_ops; sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; #if defined(CONFIG_MEDIA_CONTROLLER) @@ -1503,7 +1362,6 @@ static int tvp5150_probe(struct i2c_client *c, if (res < 0) return res; - sd->entity.ops = &tvp5150_sd_media_ops; #endif res = tvp5150_detect_version(core);
Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") added input signals support for the tvp5150, but the approach was found to be incorrect so the corresponding DT binding commit 82c2ffeb217a ("[media] tvp5150: document input connectors DT bindings") was reverted. This left the driver with an undocumented (and wrong) DT parsing logic, so lets get rid of this code as well until the input connectors support is implemented properly. It's a partial revert due other patches added on top of mentioned commit not allowing the commit to be reverted cleanly anymore. But all the code related to the DT parsing logic and input entities creation are removed. Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- This patch was posted about a year ago but was never merged: https://patchwork.kernel.org/patch/9472623/ Best regards, Javier drivers/media/i2c/tvp5150.c | 142 -------------------------------------------- 1 file changed, 142 deletions(-)