Message ID | 20171122135625.16625-1-fziglio@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
ping the series > > This fields points to an old interface that is no more > used in the current code. > > Signed-off-by: Frediano Ziglio <fziglio@redhat.com> > --- > hw/display/qxl.c | 1 - > include/ui/spice-display.h | 1 - > ui/spice-display.c | 2 -- > 3 files changed, 4 deletions(-) > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > index 99365c3e8f..b9fa067f6e 100644 > --- a/hw/display/qxl.c > +++ b/hw/display/qxl.c > @@ -518,7 +518,6 @@ static void interface_attach_worker(QXLInstance *sin, > QXLWorker *qxl_worker) > PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl); > > trace_qxl_interface_attach_worker(qxl->id); > - qxl->ssd.worker = qxl_worker; > } > > static void interface_set_compression_level(QXLInstance *sin, int level) > diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h > index aaf2019889..6b5c73b21c 100644 > --- a/include/ui/spice-display.h > +++ b/include/ui/spice-display.h > @@ -86,7 +86,6 @@ struct SimpleSpiceDisplay { > DisplayChangeListener dcl; > void *buf; > int bufsize; > - QXLWorker *worker; > QXLInstance qxl; > uint32_t unique; > pixman_image_t *surface; > diff --git a/ui/spice-display.c b/ui/spice-display.c > index ad1ceafb3f..85a72fe76a 100644 > --- a/ui/spice-display.c > +++ b/ui/spice-display.c > @@ -519,7 +519,6 @@ static void interface_attach_worker(QXLInstance *sin, > QXLWorker *qxl_worker) > SimpleSpiceDisplay *ssd = container_of(sin, SimpleSpiceDisplay, qxl); > > dprint(1, "%s/%d:\n", __func__, ssd->qxl.id); > - ssd->worker = qxl_worker; > } > > static void interface_set_compression_level(QXLInstance *sin, int level) > @@ -1028,7 +1027,6 @@ static void qemu_spice_display_init_one(QemuConsole > *con) > > ssd->qxl.base.sif = &dpy_interface.base; > qemu_spice_add_display_interface(&ssd->qxl, con); > - assert(ssd->worker); > qemu_spice_create_host_memslot(ssd); > > register_displaychangelistener(&ssd->dcl);
ping > > ping the series > > > > > This fields points to an old interface that is no more > > used in the current code. > > > > Signed-off-by: Frediano Ziglio <fziglio@redhat.com> > > --- > > hw/display/qxl.c | 1 - > > include/ui/spice-display.h | 1 - > > ui/spice-display.c | 2 -- > > 3 files changed, 4 deletions(-) > > > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > > index 99365c3e8f..b9fa067f6e 100644 > > --- a/hw/display/qxl.c > > +++ b/hw/display/qxl.c > > @@ -518,7 +518,6 @@ static void interface_attach_worker(QXLInstance *sin, > > QXLWorker *qxl_worker) > > PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl); > > > > trace_qxl_interface_attach_worker(qxl->id); > > - qxl->ssd.worker = qxl_worker; > > } > > > > static void interface_set_compression_level(QXLInstance *sin, int level) > > diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h > > index aaf2019889..6b5c73b21c 100644 > > --- a/include/ui/spice-display.h > > +++ b/include/ui/spice-display.h > > @@ -86,7 +86,6 @@ struct SimpleSpiceDisplay { > > DisplayChangeListener dcl; > > void *buf; > > int bufsize; > > - QXLWorker *worker; > > QXLInstance qxl; > > uint32_t unique; > > pixman_image_t *surface; > > diff --git a/ui/spice-display.c b/ui/spice-display.c > > index ad1ceafb3f..85a72fe76a 100644 > > --- a/ui/spice-display.c > > +++ b/ui/spice-display.c > > @@ -519,7 +519,6 @@ static void interface_attach_worker(QXLInstance *sin, > > QXLWorker *qxl_worker) > > SimpleSpiceDisplay *ssd = container_of(sin, SimpleSpiceDisplay, qxl); > > > > dprint(1, "%s/%d:\n", __func__, ssd->qxl.id); > > - ssd->worker = qxl_worker; > > } > > > > static void interface_set_compression_level(QXLInstance *sin, int level) > > @@ -1028,7 +1027,6 @@ static void qemu_spice_display_init_one(QemuConsole > > *con) > > > > ssd->qxl.base.sif = &dpy_interface.base; > > qemu_spice_add_display_interface(&ssd->qxl, con); > > - assert(ssd->worker); > > qemu_spice_create_host_memslot(ssd); > > > > register_displaychangelistener(&ssd->dcl); > >
ping > > ping > > > > > ping the series > > > > > > > > This fields points to an old interface that is no more > > > used in the current code. > > > > > > Signed-off-by: Frediano Ziglio <fziglio@redhat.com> > > > --- > > > hw/display/qxl.c | 1 - > > > include/ui/spice-display.h | 1 - > > > ui/spice-display.c | 2 -- > > > 3 files changed, 4 deletions(-) > > > > > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > > > index 99365c3e8f..b9fa067f6e 100644 > > > --- a/hw/display/qxl.c > > > +++ b/hw/display/qxl.c > > > @@ -518,7 +518,6 @@ static void interface_attach_worker(QXLInstance *sin, > > > QXLWorker *qxl_worker) > > > PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl); > > > > > > trace_qxl_interface_attach_worker(qxl->id); > > > - qxl->ssd.worker = qxl_worker; > > > } > > > > > > static void interface_set_compression_level(QXLInstance *sin, int level) > > > diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h > > > index aaf2019889..6b5c73b21c 100644 > > > --- a/include/ui/spice-display.h > > > +++ b/include/ui/spice-display.h > > > @@ -86,7 +86,6 @@ struct SimpleSpiceDisplay { > > > DisplayChangeListener dcl; > > > void *buf; > > > int bufsize; > > > - QXLWorker *worker; > > > QXLInstance qxl; > > > uint32_t unique; > > > pixman_image_t *surface; > > > diff --git a/ui/spice-display.c b/ui/spice-display.c > > > index ad1ceafb3f..85a72fe76a 100644 > > > --- a/ui/spice-display.c > > > +++ b/ui/spice-display.c > > > @@ -519,7 +519,6 @@ static void interface_attach_worker(QXLInstance *sin, > > > QXLWorker *qxl_worker) > > > SimpleSpiceDisplay *ssd = container_of(sin, SimpleSpiceDisplay, > > > qxl); > > > > > > dprint(1, "%s/%d:\n", __func__, ssd->qxl.id); > > > - ssd->worker = qxl_worker; > > > } > > > > > > static void interface_set_compression_level(QXLInstance *sin, int level) > > > @@ -1028,7 +1027,6 @@ static void qemu_spice_display_init_one(QemuConsole > > > *con) > > > > > > ssd->qxl.base.sif = &dpy_interface.base; > > > qemu_spice_add_display_interface(&ssd->qxl, con); > > > - assert(ssd->worker); > > > qemu_spice_create_host_memslot(ssd); > > > > > > register_displaychangelistener(&ssd->dcl); > > > > > >
On Sun, Dec 31, 2017 at 05:17:43AM -0500, Frediano Ziglio wrote: > ping > > > > > ping > > > > > > > > ping the series > > > Was on sick leave for a few weeks, back now, will process asap but will probably take a while nevertheless due to the big backlog I have now. cheers, Gerd
Thanks. How is your hand? Frediano ----- Original Message ----- > > On Sun, Dec 31, 2017 at 05:17:43AM -0500, Frediano Ziglio wrote: > > ping > > > > > > > > ping > > > > > > > > > > > ping the series > > > > > > Was on sick leave for a few weeks, back now, will process asap but will > probably take a while nevertheless due to the big backlog I have now. > > cheers, > Gerd > > >
On Wed, Nov 22, 2017 at 01:56:22PM +0000, Frediano Ziglio wrote: > This fields points to an old interface that is no more > used in the current code. Series queued now. thanks, Gerd
diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 99365c3e8f..b9fa067f6e 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -518,7 +518,6 @@ static void interface_attach_worker(QXLInstance *sin, QXLWorker *qxl_worker) PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl); trace_qxl_interface_attach_worker(qxl->id); - qxl->ssd.worker = qxl_worker; } static void interface_set_compression_level(QXLInstance *sin, int level) diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h index aaf2019889..6b5c73b21c 100644 --- a/include/ui/spice-display.h +++ b/include/ui/spice-display.h @@ -86,7 +86,6 @@ struct SimpleSpiceDisplay { DisplayChangeListener dcl; void *buf; int bufsize; - QXLWorker *worker; QXLInstance qxl; uint32_t unique; pixman_image_t *surface; diff --git a/ui/spice-display.c b/ui/spice-display.c index ad1ceafb3f..85a72fe76a 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -519,7 +519,6 @@ static void interface_attach_worker(QXLInstance *sin, QXLWorker *qxl_worker) SimpleSpiceDisplay *ssd = container_of(sin, SimpleSpiceDisplay, qxl); dprint(1, "%s/%d:\n", __func__, ssd->qxl.id); - ssd->worker = qxl_worker; } static void interface_set_compression_level(QXLInstance *sin, int level) @@ -1028,7 +1027,6 @@ static void qemu_spice_display_init_one(QemuConsole *con) ssd->qxl.base.sif = &dpy_interface.base; qemu_spice_add_display_interface(&ssd->qxl, con); - assert(ssd->worker); qemu_spice_create_host_memslot(ssd); register_displaychangelistener(&ssd->dcl);
This fields points to an old interface that is no more used in the current code. Signed-off-by: Frediano Ziglio <fziglio@redhat.com> --- hw/display/qxl.c | 1 - include/ui/spice-display.h | 1 - ui/spice-display.c | 2 -- 3 files changed, 4 deletions(-)