diff mbox

video: fbdev: remove redundant self assignment of 'height'

Message ID 20171123105553.18969-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Colin King Nov. 23, 2017, 10:55 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The assignment of height to itself is redundant and can be removed.
Detected with Coccinelle.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/video/fbdev/vga16fb.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bartlomiej Zolnierkiewicz Dec. 29, 2017, 5:36 p.m. UTC | #1 
On Thursday, November 23, 2017 10:55:53 AM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment of height to itself is redundant and can be removed.
> Detected with Coccinelle.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch queued for 4.16, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 5f0690c8fc93..2c6a576ed84c 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -1055,7 +1055,6 @@  static void vga16fb_copyarea(struct fb_info *info, const struct fb_copyarea *are
 	case FB_TYPE_VGA_PLANES:
 		if (info->fix.type_aux == FB_AUX_VGA_PLANES_VGA4) {
 			width = width/8;
-			height = height;
 			line_ofs = info->fix.line_length - width;
 
 			setmode(1);