| Message ID | 1514432154-9833-1-git-send-email-Hongbo.He@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Reviewed-by: Chunming Zhou <david1.zhou@amd.com> On 2017年12月28日 11:35, Roger He wrote: > Fixes interface change done in the following commit: > eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver > > i missed this driver because it is in staging dir. > > Signed-off-by: Roger He <Hongbo.He@amd.com> > --- > drivers/staging/vboxvideo/vbox_ttm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c > index 231c89e..55f14c9 100644 > --- a/drivers/staging/vboxvideo/vbox_ttm.c > +++ b/drivers/staging/vboxvideo/vbox_ttm.c > @@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev, > return tt; > } > > -static int vbox_ttm_tt_populate(struct ttm_tt *ttm) > +static int vbox_ttm_tt_populate(struct ttm_tt *ttm, > + struct ttm_operation_ctx *ctx) > { > - return ttm_pool_populate(ttm); > + return ttm_pool_populate(ttm, ctx); > } > > static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)
Seems I have no permission to push the patch into amd-staging-drm-next. Needs Whitelisted. http://git.amd.com:8080/#/c/124051/1 anyone can help? Thanks Roger(Hongbo.He) -----Original Message----- From: Zhou, David(ChunMing) Sent: Thursday, December 28, 2017 12:24 PM To: He, Roger <Hongbo.He@amd.com>; dri-devel@lists.freedesktop.org Cc: hdegoede@redhat.com; gregkh@linuxfoundation.org; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com> Subject: Re: [PATCH] staging: vboxvideo adapt to new TTM interface Reviewed-by: Chunming Zhou <david1.zhou@amd.com> On 2017年12月28日 11:35, Roger He wrote: > Fixes interface change done in the following commit: > eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver > > i missed this driver because it is in staging dir. > > Signed-off-by: Roger He <Hongbo.He@amd.com> > --- > drivers/staging/vboxvideo/vbox_ttm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c > index 231c89e..55f14c9 100644 > --- a/drivers/staging/vboxvideo/vbox_ttm.c > +++ b/drivers/staging/vboxvideo/vbox_ttm.c > @@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev, > return tt; > } > > -static int vbox_ttm_tt_populate(struct ttm_tt *ttm) > +static int vbox_ttm_tt_populate(struct ttm_tt *ttm, > + struct ttm_operation_ctx *ctx) > { > - return ttm_pool_populate(ttm); > + return ttm_pool_populate(ttm, ctx); > } > > static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)
+Alex Do you know who can help about it? Thanks Roger(Hongbo.He) -----Original Message----- From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of He, Roger Sent: Thursday, December 28, 2017 6:21 PM To: dri-devel@lists.freedesktop.org; Bridgman, John <John.Bridgman@amd.com>; Gregory, Robert <Robert.Gregory@amd.com>; Khan, Tahir <Tahir.Khan@amd.com>; Shamim, Zafar <Zafar.Shamim@amd.com> Cc: hdegoede@redhat.com; Koenig, Christian <Christian.Koenig@amd.com>; gregkh@linuxfoundation.org Subject: RE: [PATCH] staging: vboxvideo adapt to new TTM interface Seems I have no permission to push the patch into amd-staging-drm-next. Needs Whitelisted. http://git.amd.com:8080/#/c/124051/1 anyone can help? Thanks Roger(Hongbo.He) -----Original Message----- From: Zhou, David(ChunMing) Sent: Thursday, December 28, 2017 12:24 PM To: He, Roger <Hongbo.He@amd.com>; dri-devel@lists.freedesktop.org Cc: hdegoede@redhat.com; gregkh@linuxfoundation.org; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com> Subject: Re: [PATCH] staging: vboxvideo adapt to new TTM interface Reviewed-by: Chunming Zhou <david1.zhou@amd.com> On 2017年12月28日 11:35, Roger He wrote: > Fixes interface change done in the following commit: > eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver > > i missed this driver because it is in staging dir. > > Signed-off-by: Roger He <Hongbo.He@amd.com> > --- > drivers/staging/vboxvideo/vbox_ttm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c > index 231c89e..55f14c9 100644 > --- a/drivers/staging/vboxvideo/vbox_ttm.c > +++ b/drivers/staging/vboxvideo/vbox_ttm.c > @@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev, > return tt; > } > > -static int vbox_ttm_tt_populate(struct ttm_tt *ttm) > +static int vbox_ttm_tt_populate(struct ttm_tt *ttm, > + struct ttm_operation_ctx *ctx) > { > - return ttm_pool_populate(ttm); > + return ttm_pool_populate(ttm, ctx); > } > > static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Roger, you already pinged the right persons, just be a bit more patience about it. They are probably just on vacation. Regards, Christian. PS: Happy new year! Am 02.01.2018 um 03:15 schrieb He, Roger: > +Alex > > Do you know who can help about it? > > > Thanks > Roger(Hongbo.He) > > -----Original Message----- > From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of He, Roger > Sent: Thursday, December 28, 2017 6:21 PM > To: dri-devel@lists.freedesktop.org; Bridgman, John <John.Bridgman@amd.com>; Gregory, Robert <Robert.Gregory@amd.com>; Khan, Tahir <Tahir.Khan@amd.com>; Shamim, Zafar <Zafar.Shamim@amd.com> > Cc: hdegoede@redhat.com; Koenig, Christian <Christian.Koenig@amd.com>; gregkh@linuxfoundation.org > Subject: RE: [PATCH] staging: vboxvideo adapt to new TTM interface > > Seems I have no permission to push the patch into amd-staging-drm-next. > Needs Whitelisted. > > http://git.amd.com:8080/#/c/124051/1 > anyone can help? > > Thanks > Roger(Hongbo.He) > -----Original Message----- > From: Zhou, David(ChunMing) > Sent: Thursday, December 28, 2017 12:24 PM > To: He, Roger <Hongbo.He@amd.com>; dri-devel@lists.freedesktop.org > Cc: hdegoede@redhat.com; gregkh@linuxfoundation.org; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com> > Subject: Re: [PATCH] staging: vboxvideo adapt to new TTM interface > > Reviewed-by: Chunming Zhou <david1.zhou@amd.com> > > > On 2017年12月28日 11:35, Roger He wrote: >> Fixes interface change done in the following commit: >> eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver >> >> i missed this driver because it is in staging dir. >> >> Signed-off-by: Roger He <Hongbo.He@amd.com> >> --- >> drivers/staging/vboxvideo/vbox_ttm.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c >> index 231c89e..55f14c9 100644 >> --- a/drivers/staging/vboxvideo/vbox_ttm.c >> +++ b/drivers/staging/vboxvideo/vbox_ttm.c >> @@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev, >> return tt; >> } >> >> -static int vbox_ttm_tt_populate(struct ttm_tt *ttm) >> +static int vbox_ttm_tt_populate(struct ttm_tt *ttm, >> + struct ttm_operation_ctx *ctx) >> { >> - return ttm_pool_populate(ttm); >> + return ttm_pool_populate(ttm, ctx); >> } >> >> static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm) > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo/vbox_ttm.c index 231c89e..55f14c9 100644 --- a/drivers/staging/vboxvideo/vbox_ttm.c +++ b/drivers/staging/vboxvideo/vbox_ttm.c @@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct ttm_bo_device *bdev, return tt; } -static int vbox_ttm_tt_populate(struct ttm_tt *ttm) +static int vbox_ttm_tt_populate(struct ttm_tt *ttm, + struct ttm_operation_ctx *ctx) { - return ttm_pool_populate(ttm); + return ttm_pool_populate(ttm, ctx); } static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)
Fixes interface change done in the following commit: eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver i missed this driver because it is in staging dir. Signed-off-by: Roger He <Hongbo.He@amd.com> --- drivers/staging/vboxvideo/vbox_ttm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)