| Message ID | 1514835793-1104-10-git-send-email-pure.logic@nexus-software.ie (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
Bryan O'Donoghue <pure.logic@nexus-software.ie> writes: > bcm2835_pll_rate_from_divisor returns a long but the function calling it > returns an unsigned long. There's no reason to have a type disparity here > so tidy up the return type of bcm2835_pll_rate_from_divisor() from signed > to unsigned long. I'm still surprised that clocks are using longs instead of u64s, but this seems like a fine change. For the 2 bcm2835 patches, Reviewed-by: Eric Anholt <eric@anholt.net>
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index fb2b012..cde2cf1 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -955,9 +955,9 @@ static u32 bcm2835_clock_choose_div(struct clk_hw *hw, return div; } -static long bcm2835_clock_rate_from_divisor(struct bcm2835_clock *clock, - unsigned long parent_rate, - u32 div) +static unsigned long bcm2835_clock_rate_from_divisor(struct bcm2835_clock *clock, + unsigned long parent_rate, + u32 div) { const struct bcm2835_clock_data *data = clock->data; u64 temp;
bcm2835_pll_rate_from_divisor returns a long but the function calling it returns an unsigned long. There's no reason to have a type disparity here so tidy up the return type of bcm2835_pll_rate_from_divisor() from signed to unsigned long. Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@codeaurora.org> Cc: Eric Anholt <eric@anholt.net> Cc: Stefan Wahren <stefan.wahren@i2se.com> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: Boris Brezillon <boris.brezillon@free-electrons.com> Cc: Phil Elwell <phil@raspberrypi.org> Cc: linux-clk@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/bcm/clk-bcm2835.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)