diff mbox

[1/4] ASoC: max98373: Changed SPDX header in C++ comments style

Message ID 1515560521-10850-1-git-send-email-ryans.lee@maximintegrated.com (mailing list archive)
State Accepted
Headers show

Commit Message

Ryan Lee Jan. 10, 2018, 5:01 a.m. UTC
Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
---
Changelog:
	Changed SPDX header in C comment-style to C++ comment-style

 sound/soc/codecs/max98373.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Jan. 10, 2018, 10:15 a.m. UTC | #1
On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:

> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> +// SPDX-License-Identifier: GPL-2.0
>  /* Copyright (c) 2017, Maxim Integrated */

Please change the entire header to C++, mixing C and C++ on adjacent
lines looks ugly.
Takashi Iwai Jan. 10, 2018, 10:21 a.m. UTC | #2
On Wed, 10 Jan 2018 11:15:06 +0100,
Mark Brown wrote:
> 
> On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:
> 
> > @@ -1,4 +1,4 @@
> > -/* SPDX-License-Identifier: GPL-2.0 */
> > +// SPDX-License-Identifier: GPL-2.0
> >  /* Copyright (c) 2017, Maxim Integrated */
> 
> Please change the entire header to C++, mixing C and C++ on adjacent
> lines looks ugly.

I'm not sure whether it's a good direction to go, either.

I rather wonder why SPDX line *must* be in C++ comment style...


thanks,

Takashi
Mark Brown Jan. 10, 2018, 10:29 a.m. UTC | #3
On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:

> > > @@ -1,4 +1,4 @@
> > > -/* SPDX-License-Identifier: GPL-2.0 */
> > > +// SPDX-License-Identifier: GPL-2.0
> > >  /* Copyright (c) 2017, Maxim Integrated */

> > Please change the entire header to C++, mixing C and C++ on adjacent
> > lines looks ugly.

> I'm not sure whether it's a good direction to go, either.

> I rather wonder why SPDX line *must* be in C++ comment style...

Apparently it's to remove any ambiguity for the tooling or something,
plus Linus decided he likes C++ comments.

I don't understand why this isn't done as a macro like MODULE_LICENSE()
and so on but the decision was rushed through and not really publicised
:9
Ryan Lee Jan. 18, 2018, 9:35 p.m. UTC | #4
>-----Original Message-----
>From: Mark Brown [mailto:broonie@kernel.org]
>Sent: Wednesday, January 10, 2018 2:30 AM
>To: Takashi Iwai <tiwai@suse.de>
>Cc: Ryan Lee <RyanS.Lee@maximintegrated.com>; alsa-devel@alsa-project.org;
>lgirdwood@gmail.com; ryan.lee.maxim@gmail.com; perex@perex.cz; linux-
>kernel@vger.kernel.org
>Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++
>comments style
>
>On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote:
>> Mark Brown wrote:
>> > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:
>
>> > > @@ -1,4 +1,4 @@
>> > > -/* SPDX-License-Identifier: GPL-2.0 */
>> > > +// SPDX-License-Identifier: GPL-2.0
>> > >  /* Copyright (c) 2017, Maxim Integrated */
>
>> > Please change the entire header to C++, mixing C and C++ on adjacent
>> > lines looks ugly.
>
>> I'm not sure whether it's a good direction to go, either.
>
>> I rather wonder why SPDX line *must* be in C++ comment style...
>
>Apparently it's to remove any ambiguity for the tooling or something, plus Linus
>decided he likes C++ comments.
>
>I don't understand why this isn't done as a macro like MODULE_LICENSE() and
>so on but the decision was rushed through and not really publicised
>:9

Thank you for your feedback.
I modified two header lines in C++ comment style and send it again.
diff mbox

Patch

diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c
index 9af0d98..e040b03 100644
--- a/sound/soc/codecs/max98373.c
+++ b/sound/soc/codecs/max98373.c
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: GPL-2.0 */
+// SPDX-License-Identifier: GPL-2.0
 /* Copyright (c) 2017, Maxim Integrated */
 
 #include <linux/acpi.h>