diff mbox

[2/3] Allow the compiler to verify the consistency of the uxsock_timeout definition and declaration

Message ID 20171212004503.12823-3-bart.vanassche@wdc.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show

Commit Message

Bart Van Assche Dec. 12, 2017, 12:45 a.m. UTC 
Global variables should be defined after the header file with
their declaration has been included. Hence move the declaration
of usock_timeout further down.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
---
 multipathd/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Martin Wilck Jan. 11, 2018, 10:28 p.m. UTC | #1 
On Mon, 2017-12-11 at 16:45 -0800, Bart Van Assche wrote:
> Global variables should be defined after the header file with
> their declaration has been included. Hence move the declaration
> of usock_timeout further down.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> ---
>  multipathd/main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Martin Wilck <mwilck@suse.com>
diff mbox

Patch

diff --git a/multipathd/main.c b/multipathd/main.c
index 31ce923385a7..d611597a4ef8 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -39,8 +39,6 @@ 
 static int use_watchdog;
 #endif
 
-int uxsock_timeout;
-
 /*
  * libmultipath
  */
@@ -106,6 +104,7 @@  struct mpath_event_param
 };
 
 int logsink;
+int uxsock_timeout;
 int verbosity;
 int bindings_read_only;
 int ignore_new_devs;