| Message ID | 20180112005858.26472-6-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jan 12, 2018 at 02:58:53AM +0200, Laurent Pinchart wrote: > The HDMI encoder is connected to the RGB output of the DU, which is > port@0, not port@1. Fix the incorrect DT description. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Should this have the following tag? Fixes: c5af8a4248d3 ("ARM: dts: porter: add DU DT support") If so, is it a fix to apply for v4.15 or a more regular patch to apply for v4.16?
Hi Simon, On Monday, 15 January 2018 09:56:03 EET Simon Horman wrote: > On Fri, Jan 12, 2018 at 02:58:53AM +0200, Laurent Pinchart wrote: > > The HDMI encoder is connected to the RGB output of the DU, which is > > port@0, not port@1. Fix the incorrect DT description. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > Should this have the following tag? > > Fixes: c5af8a4248d3 ("ARM: dts: porter: add DU DT support") That would make sense, yes. > If so, is it a fix to apply for v4.15 or a more regular patch > to apply for v4.16? I believe we can wait for v4.16. HDMI output works on Porter at the moment due to a separate bug in the DU driver that clones outputs by default when it shouldn't. There's however no harm in backporting the patch to stable series if desired, but it's not required.
On Mon, Jan 15, 2018 at 10:25:34AM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Monday, 15 January 2018 09:56:03 EET Simon Horman wrote: > > On Fri, Jan 12, 2018 at 02:58:53AM +0200, Laurent Pinchart wrote: > > > The HDMI encoder is connected to the RGB output of the DU, which is > > > port@0, not port@1. Fix the incorrect DT description. > > > > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@ideasonboard.com> > > > > Should this have the following tag? > > > > Fixes: c5af8a4248d3 ("ARM: dts: porter: add DU DT support") > > That would make sense, yes. > > > If so, is it a fix to apply for v4.15 or a more regular patch > > to apply for v4.16? > > I believe we can wait for v4.16. HDMI output works on Porter at the > moment due to a separate bug in the DU driver that clones outputs by > default when it shouldn't. There's however no harm in backporting the > patch to stable series if desired, but it's not required. Thanks, I've applied this for v4.16 with the fixes tag above. Possibly the fixes tag will result in some automated backporting occurring. If so we can let that run its course, if not we can leave things be with the option to backport later if we decide its necessary. I have not applied the other dts patches in this series at this point.
diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts index eb374956294f..9a02d03b23c2 100644 --- a/arch/arm/boot/dts/r8a7791-porter.dts +++ b/arch/arm/boot/dts/r8a7791-porter.dts @@ -425,7 +425,7 @@ "dclkin.0", "dclkin.1"; ports { - port@1 { + port@0 { endpoint { remote-endpoint = <&adv7511_in>; };
The HDMI encoder is connected to the RGB output of the DU, which is port@0, not port@1. Fix the incorrect DT description. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7791-porter.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)