| Message ID | 20180115165946.GA20134@lenoch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday, January 15, 2018 05:59:46 PM Ladislav Michl wrote: > Both dlfb_fix and fb_device_attrs are never written to, so > it is safe to make them const. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index 47e31668f316..f0118c10b4ab 100644 --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -32,7 +32,7 @@ #include <video/udlfb.h> #include "edid.h" -static struct fb_fix_screeninfo dlfb_fix = { +static const struct fb_fix_screeninfo dlfb_fix = { .id = "udlfb", .type = FB_TYPE_PACKED_PIXELS, .visual = FB_VISUAL_TRUECOLOR, @@ -1455,7 +1455,7 @@ static const struct bin_attribute edid_attr = { .write = edid_store }; -static struct device_attribute fb_device_attrs[] = { +static const struct device_attribute fb_device_attrs[] = { __ATTR_RO(metrics_bytes_rendered), __ATTR_RO(metrics_bytes_identical), __ATTR_RO(metrics_bytes_sent),
Both dlfb_fix and fb_device_attrs are never written to, so it is safe to make them const. Signed-off-by: Ladislav Michl <ladis@linux-mips.org> --- drivers/video/fbdev/udlfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)