| Message ID | 1516718246-24746-1-git-send-email-clabbe@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe <clabbe@baylibre.com> wrote: > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support") > Lets remove this kconfig option. First of all, I hardly understand how that change is related. Second, did you check Makefile? Third, the files are in the folder (for OV8858). Taking all above into account, it seems NACK, though regression might be made by renaming patch from Sakari (no, it's not). So, it looks like it was never enabled in the first place. Anyway, do you have hardware to test? This is *most* important reason why to accept or decline a change to the driver.
On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe <clabbe@baylibre.com> wrote: > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support") > > Lets remove this kconfig option. > > First of all, I hardly understand how that change is related. > Second, did you check Makefile? I don't see it being used in any Makefile, what file do you see it: $ git grep VIDEO_ATOMISP_OV8858 drivers/staging/media/atomisp/i2c/Kconfig:config VIDEO_ATOMISP_OV8858 So it should be removed. thanks, greg k-h
On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe <clabbe@baylibre.com> wrote: > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support") > > Lets remove this kconfig option. > > First of all, I hardly understand how that change is related. It's pretty obvious if you look at the commit. -obj-$(CONFIG_VIDEO_ATOMISP_OV8858) += atomisp-ov8858.o It sounds like you deleted that line by mistake and re-added it to your local Makefile? regards, dan carpenter
On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: > > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe <clabbe@baylibre.com> wrote: > > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support") > > > Lets remove this kconfig option. > > > > First of all, I hardly understand how that change is related. > > Second, did you check Makefile? > > I don't see it being used in any Makefile, what file do you see it: > $ git grep VIDEO_ATOMISP_OV8858 > drivers/staging/media/atomisp/i2c/Kconfig:config VIDEO_ATOMISP_OV8858 > > So it should be removed. > > thanks, > Hello I just see that 3a81c7660f80 left ov8858.c so do you agree that I send a v2 which remove also this file ? av8858.c is useless without dw9718.c and vcm.c which 3a81c7660f80 removed. Regards
On Fri, Jan 26, 2018 at 2:49 PM, LABBE Corentin <clabbe@baylibre.com> wrote: > On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote: >> On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: >> > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe <clabbe@baylibre.com> wrote: >> > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support") >> > > Lets remove this kconfig option. >> > >> > First of all, I hardly understand how that change is related. >> > Second, did you check Makefile? >> >> I don't see it being used in any Makefile, what file do you see it: >> $ git grep VIDEO_ATOMISP_OV8858 >> drivers/staging/media/atomisp/i2c/Kconfig:config VIDEO_ATOMISP_OV8858 >> >> So it should be removed. >> >> thanks, > I just see that 3a81c7660f80 left ov8858.c so do you agree that I send a v2 which remove also this file ? > av8858.c is useless without dw9718.c and vcm.c which 3a81c7660f80 removed. Removal of dead code is pretty fine to me, though the decision is to Alan and Sakari.
diff --git a/drivers/staging/media/atomisp/i2c/Kconfig b/drivers/staging/media/atomisp/i2c/Kconfig index db054d3c7ed6..f7f7177b9b37 100644 --- a/drivers/staging/media/atomisp/i2c/Kconfig +++ b/drivers/staging/media/atomisp/i2c/Kconfig @@ -28,18 +28,6 @@ config VIDEO_ATOMISP_GC2235 It currently only works with the atomisp driver. -config VIDEO_ATOMISP_OV8858 - tristate "Omnivision ov8858 sensor support" - depends on ACPI - depends on I2C && VIDEO_V4L2 && VIDEO_ATOMISP - ---help--- - This is a Video4Linux2 sensor-level driver for the Omnivision - ov8858 RAW sensor. - - OV8858 is a 8M raw sensor. - - It currently only works with the atomisp driver. - config VIDEO_ATOMISP_MSRLIST_HELPER tristate "Helper library to load, parse and apply large register lists." depends on I2C
Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support") Lets remove this kconfig option. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- drivers/staging/media/atomisp/i2c/Kconfig | 12 ------------ 1 file changed, 12 deletions(-)