| Message ID | 20180129092223.12423-1-codekipper@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper@gmail.com wrote: > From: Marcus Cooper <codekipper@gmail.com> > > Add the new DAI block for I2S2 which is used for HDMI audio. > > Signed-off-by: Marcus Cooper <codekipper@gmail.com> queued for 4.17, thanks! Maxime
Hi Maxime, (previously I respond only to linux-sunxi mailing list) >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper@gmail.com wrote: >> From: Marcus Cooper <codekipper@gmail.com> >> >> Add the new DAI block for I2S2 which is used for HDMI audio. >> >> Signed-off-by: Marcus Cooper <codekipper@gmail.com> > >queued for 4.17, thanks! >Maxime Please note that HDMI I2S has usable 4 I2S lanes, since HDMI supports 8 channel audio. As Marcus said, other blocks probably support them too, they are just not wired out on pins. Should we change compatible for HDMI? Best regards, Jernej
On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote: > Hi Maxime, > > (previously I respond only to linux-sunxi mailing list) > > >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper@gmail.com wrote: > >> From: Marcus Cooper <codekipper@gmail.com> > >> > >> Add the new DAI block for I2S2 which is used for HDMI audio. > >> > >> Signed-off-by: Marcus Cooper <codekipper@gmail.com> > > > >queued for 4.17, thanks! > >Maxime > > Please note that HDMI I2S has usable 4 I2S lanes, since HDMI > supports 8 channel audio. As Marcus said, other blocks probably > support them too, they are just not wired out on pins. I've dropped those patches for now. > Should we change compatible for HDMI? I guess, another way of doing things if they are strictly identical but for the number of lanes they support would be to add a DT property for that number of lanes. Maxime
On 31 January 2018 at 08:16, maxime ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote: >> Hi Maxime, >> >> (previously I respond only to linux-sunxi mailing list) >> >> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper@gmail.com wrote: >> >> From: Marcus Cooper <codekipper@gmail.com> >> >> >> >> Add the new DAI block for I2S2 which is used for HDMI audio. >> >> >> >> Signed-off-by: Marcus Cooper <codekipper@gmail.com> >> > >> >queued for 4.17, thanks! >> >Maxime >> >> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI >> supports 8 channel audio. As Marcus said, other blocks probably >> support them too, they are just not wired out on pins. > > I've dropped those patches for now. > >> Should we change compatible for HDMI? > > I guess, another way of doing things if they are strictly identical > but for the number of lanes they support would be to add a DT property > for that number of lanes. > That's fine...I'll look into adding a dt property and how we would map channels to lanes. Do you know of any examples?, BR, CK > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
On Wed, Jan 31, 2018 at 10:54:29AM +0100, Code Kipper wrote: > On 31 January 2018 at 08:16, maxime ripard > <maxime.ripard@free-electrons.com> wrote: > > On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote: > >> Hi Maxime, > >> > >> (previously I respond only to linux-sunxi mailing list) > >> > >> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper@gmail.com wrote: > >> >> From: Marcus Cooper <codekipper@gmail.com> > >> >> > >> >> Add the new DAI block for I2S2 which is used for HDMI audio. > >> >> > >> >> Signed-off-by: Marcus Cooper <codekipper@gmail.com> > >> > > >> >queued for 4.17, thanks! > >> >Maxime > >> > >> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI > >> supports 8 channel audio. As Marcus said, other blocks probably > >> support them too, they are just not wired out on pins. > > > > I've dropped those patches for now. > > > >> Should we change compatible for HDMI? > > > > I guess, another way of doing things if they are strictly identical > > but for the number of lanes they support would be to add a DT property > > for that number of lanes. > > > That's fine...I'll look into adding a dt property and how we would map > channels to lanes. > Do you know of any examples?, Grepping for of_property_read_u32 should give you plenty of examples :) maxime
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi index 7a83b15225c7..238e7007d5b9 100644 --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi @@ -568,6 +568,19 @@ status = "disabled"; }; + i2s2: i2s@1c22800 { + #sound-dai-cells = <0>; + compatible = "allwinner,sun8i-h3-i2s"; + reg = <0x01c22800 0x400>; + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>; + clock-names = "apb", "mod"; + dmas = <&dma 27>; + resets = <&ccu RST_BUS_I2S2>; + dma-names = "tx"; + status = "disabled"; + }; + codec: codec@1c22c00 { #sound-dai-cells = <0>; compatible = "allwinner,sun8i-h3-codec";