| Message ID | 20180126131710.7622-2-thierry.escande@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jan 26, 2018 at 02:16:28PM +0100, Thierry Escande wrote: > From: Tomasz Figa <tfiga@chromium.org> > > This patch removes unused fields from vop structure. > > Signed-off-by: Tomasz Figa <tfiga@chromium.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Signed-off-by: Thierry Escande <thierry.escande@collabora.com> Reviewed-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index ba7505292b78..7a137bc5708c 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -95,9 +95,6 @@ struct vop { > struct drm_device *drm_dev; > bool is_enabled; > > - /* mutex vsync_ work */ > - struct mutex vsync_mutex; > - bool vsync_work_pending; > struct completion dsp_hold_completion; > > /* protected by dev->event_lock */ > @@ -1567,8 +1564,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data) > spin_lock_init(&vop->reg_lock); > spin_lock_init(&vop->irq_lock); > > - mutex_init(&vop->vsync_mutex); > - > ret = devm_request_irq(dev, vop->irq, vop_isr, > IRQF_SHARED, dev_name(dev), vop); > if (ret) > -- > 2.14.1 >
在 2018/1/26 21:16, Thierry Escande 写道: > From: Tomasz Figa <tfiga@chromium.org> > > This patch removes unused fields from vop structure. > > Signed-off-by: Tomasz Figa <tfiga@chromium.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Signed-off-by: Thierry Escande <thierry.escande@collabora.com> > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index ba7505292b78..7a137bc5708c 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -95,9 +95,6 @@ struct vop { > struct drm_device *drm_dev; > bool is_enabled; > > - /* mutex vsync_ work */ > - struct mutex vsync_mutex; > - bool vsync_work_pending; > struct completion dsp_hold_completion; > > /* protected by dev->event_lock */ > @@ -1567,8 +1564,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data) > spin_lock_init(&vop->reg_lock); > spin_lock_init(&vop->irq_lock); > > - mutex_init(&vop->vsync_mutex); > - > ret = devm_request_irq(dev, vop->irq, vop_isr, > IRQF_SHARED, dev_name(dev), vop); > if (ret) > Reviewed-by: Sandy huang <hjc@rock-chips.com>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index ba7505292b78..7a137bc5708c 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -95,9 +95,6 @@ struct vop { struct drm_device *drm_dev; bool is_enabled; - /* mutex vsync_ work */ - struct mutex vsync_mutex; - bool vsync_work_pending; struct completion dsp_hold_completion; /* protected by dev->event_lock */ @@ -1567,8 +1564,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data) spin_lock_init(&vop->reg_lock); spin_lock_init(&vop->irq_lock); - mutex_init(&vop->vsync_mutex); - ret = devm_request_irq(dev, vop->irq, vop_isr, IRQF_SHARED, dev_name(dev), vop); if (ret)