diff mbox

[libdrm,7/7] meson: cleanup whitespace

Message ID 20180126113047.25658-7-eric.engestrom@imgtec.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Engestrom Jan. 26, 2018, 11:30 a.m. UTC 
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 meson.build | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Dylan Baker Jan. 26, 2018, 5:45 p.m. UTC | #1 
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>

Quoting Eric Engestrom (2018-01-26 03:30:47)
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  meson.build | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 1fd58b071bb90a49996e..1bccdb2c03d7846e7bfb 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -207,8 +207,8 @@ foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Werror=undef',
>               '-Werror-implicit-function-declaration', '-Wpointer-arith',
>               '-Wwrite-strings', '-Wstrict-prototypes', '-Wmissing-prototypes',
>               '-Wmissing-declarations', '-Wnested-externs', '-Wpacked',
> -             '-Wswitch-enum', '-Wmissing-format-attribute', 
> -             '-Wstrict-aliasing=2', '-Winit-self', '-Winline', '-Wshadow', 
> +             '-Wswitch-enum', '-Wmissing-format-attribute',
> +             '-Wstrict-aliasing=2', '-Winit-self', '-Winline', '-Wshadow',
>               '-Wdeclaration-after-statement', '-Wold-style-definition']
>    if cc.has_argument(a)
>      warn_c_args += a
> @@ -216,7 +216,7 @@ foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Werror=undef',
>  endforeach
>  # GCC will never error for -Wno-*, so check for -W* then add -Wno-* to the list
>  # of options
> -foreach a : ['unused-parameter', 'attributes', 'long-long', 
> +foreach a : ['unused-parameter', 'attributes', 'long-long',
>               'missing-field-initializers']
>    if cc.has_argument('-W@0@'.format(a))
>      warn_c_args += '-Wno-@0@'.format(a)
> @@ -326,7 +326,7 @@ pkg.generate(
>    version : meson.project_version(),
>    description : 'Userspace interface to kernel DRM services',
>  )
> - 
> +
>  if with_libkms
>    subdir('libkms')
>  endif
> -- 
> Cheers,
>   Eric
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Eric Engestrom Jan. 29, 2018, 10:54 a.m. UTC | #2 
On Friday, 2018-01-26 09:45:14 -0800, Dylan Baker wrote:
> Reviewed-by: Dylan Baker <dylan@pnwbakers.com>

Thanks :)
Is that for this patch or the series?

> 
> Quoting Eric Engestrom (2018-01-26 03:30:47)
> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > ---
> >  meson.build | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 1fd58b071bb90a49996e..1bccdb2c03d7846e7bfb 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -207,8 +207,8 @@ foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Werror=undef',
> >               '-Werror-implicit-function-declaration', '-Wpointer-arith',
> >               '-Wwrite-strings', '-Wstrict-prototypes', '-Wmissing-prototypes',
> >               '-Wmissing-declarations', '-Wnested-externs', '-Wpacked',
> > -             '-Wswitch-enum', '-Wmissing-format-attribute', 
> > -             '-Wstrict-aliasing=2', '-Winit-self', '-Winline', '-Wshadow', 
> > +             '-Wswitch-enum', '-Wmissing-format-attribute',
> > +             '-Wstrict-aliasing=2', '-Winit-self', '-Winline', '-Wshadow',
> >               '-Wdeclaration-after-statement', '-Wold-style-definition']
> >    if cc.has_argument(a)
> >      warn_c_args += a
> > @@ -216,7 +216,7 @@ foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Werror=undef',
> >  endforeach
> >  # GCC will never error for -Wno-*, so check for -W* then add -Wno-* to the list
> >  # of options
> > -foreach a : ['unused-parameter', 'attributes', 'long-long', 
> > +foreach a : ['unused-parameter', 'attributes', 'long-long',
> >               'missing-field-initializers']
> >    if cc.has_argument('-W@0@'.format(a))
> >      warn_c_args += '-Wno-@0@'.format(a)
> > @@ -326,7 +326,7 @@ pkg.generate(
> >    version : meson.project_version(),
> >    description : 'Userspace interface to kernel DRM services',
> >  )
> > - 
> > +
> >  if with_libkms
> >    subdir('libkms')
> >  endif
> > -- 
> > Cheers,
> >   Eric
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Dylan Baker Jan. 29, 2018, 7:13 p.m. UTC | #3 
For the series :)

But please do get someone from nouveau (Emil CC'd Ben, so presumably him) before
pushing the nouveau patch.

Dylan

Quoting Eric Engestrom (2018-01-29 02:54:47)
> On Friday, 2018-01-26 09:45:14 -0800, Dylan Baker wrote:
> > Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
> 
> Thanks :)
> Is that for this patch or the series?
> 
> > 
> > Quoting Eric Engestrom (2018-01-26 03:30:47)
> > > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > > ---
> > >  meson.build | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/meson.build b/meson.build
> > > index 1fd58b071bb90a49996e..1bccdb2c03d7846e7bfb 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -207,8 +207,8 @@ foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Werror=undef',
> > >               '-Werror-implicit-function-declaration', '-Wpointer-arith',
> > >               '-Wwrite-strings', '-Wstrict-prototypes', '-Wmissing-prototypes',
> > >               '-Wmissing-declarations', '-Wnested-externs', '-Wpacked',
> > > -             '-Wswitch-enum', '-Wmissing-format-attribute', 
> > > -             '-Wstrict-aliasing=2', '-Winit-self', '-Winline', '-Wshadow', 
> > > +             '-Wswitch-enum', '-Wmissing-format-attribute',
> > > +             '-Wstrict-aliasing=2', '-Winit-self', '-Winline', '-Wshadow',
> > >               '-Wdeclaration-after-statement', '-Wold-style-definition']
> > >    if cc.has_argument(a)
> > >      warn_c_args += a
> > > @@ -216,7 +216,7 @@ foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Werror=undef',
> > >  endforeach
> > >  # GCC will never error for -Wno-*, so check for -W* then add -Wno-* to the list
> > >  # of options
> > > -foreach a : ['unused-parameter', 'attributes', 'long-long', 
> > > +foreach a : ['unused-parameter', 'attributes', 'long-long',
> > >               'missing-field-initializers']
> > >    if cc.has_argument('-W@0@'.format(a))
> > >      warn_c_args += '-Wno-@0@'.format(a)
> > > @@ -326,7 +326,7 @@ pkg.generate(
> > >    version : meson.project_version(),
> > >    description : 'Userspace interface to kernel DRM services',
> > >  )
> > > - 
> > > +
> > >  if with_libkms
> > >    subdir('libkms')
> > >  endif
> > > -- 
> > > Cheers,
> > >   Eric
> > > 
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
>
Eric Engestrom Jan. 30, 2018, 5:50 p.m. UTC | #4 
On January 30, 2018 5:33:39 PM UTC, Dylan Baker <dylan@pnwbakers.com> wrote:
> For the series :)

Thanks :)

> 
> But please do get someone from nouveau (Emil CC'd Ben, so presumably
> him) before
> pushing the nouveau patch.

I'm not pushing the nouveau patch until I get an ack, and the amdgpu
sign patch needs a v2.
I'll push the rest tomorrow.

> 
> Dylan
> 
> Quoting Eric Engestrom (2018-01-29 02:54:47)
> > On Friday, 2018-01-26 09:45:14 -0800, Dylan Baker wrote:
> > > Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
> > 
> > Thanks :)
> > Is that for this patch or the series?
> > 
> > > 
> > > Quoting Eric Engestrom (2018-01-26 03:30:47)
> > > > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > > > ---
> > > >  meson.build | 8 ++++----
> > > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > > > 
> > > > diff --git a/meson.build b/meson.build
> > > > index 1fd58b071bb90a49996e..1bccdb2c03d7846e7bfb 100644
> > > > --- a/meson.build
> > > > +++ b/meson.build
> > > > @@ -207,8 +207,8 @@ foreach a : ['-Wall', '-Wextra',
> '-Wsign-compare', '-Werror=undef',
> > > >               '-Werror-implicit-function-declaration',
> '-Wpointer-arith',
> > > >               '-Wwrite-strings', '-Wstrict-prototypes',
> '-Wmissing-prototypes',
> > > >               '-Wmissing-declarations', '-Wnested-externs',
> '-Wpacked',
> > > > -             '-Wswitch-enum', '-Wmissing-format-attribute', 
> > > > -             '-Wstrict-aliasing=2', '-Winit-self', '-Winline',
> '-Wshadow', 
> > > > +             '-Wswitch-enum', '-Wmissing-format-attribute',
> > > > +             '-Wstrict-aliasing=2', '-Winit-self', '-Winline',
> '-Wshadow',
> > > >               '-Wdeclaration-after-statement',
> '-Wold-style-definition']
> > > >    if cc.has_argument(a)
> > > >      warn_c_args += a
> > > > @@ -216,7 +216,7 @@ foreach a : ['-Wall', '-Wextra',
> '-Wsign-compare', '-Werror=undef',
> > > >  endforeach
> > > >  # GCC will never error for -Wno-*, so check for -W* then add
> -Wno-* to the list
> > > >  # of options
> > > > -foreach a : ['unused-parameter', 'attributes', 'long-long', 
> > > > +foreach a : ['unused-parameter', 'attributes', 'long-long',
> > > >               'missing-field-initializers']
> > > >    if cc.has_argument('-W@0@'.format(a))
> > > >      warn_c_args += '-Wno-@0@'.format(a)
> > > > @@ -326,7 +326,7 @@ pkg.generate(
> > > >    version : meson.project_version(),
> > > >    description : 'Userspace interface to kernel DRM services',
> > > >  )
> > > > - 
> > > > +
> > > >  if with_libkms
> > > >    subdir('libkms')
> > > >  endif
> > > > -- 
> > > > Cheers,
> > > >   Eric
> > > > 
> > > > _______________________________________________
> > > > dri-devel mailing list
> > > > dri-devel@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > 
> >
diff mbox

Patch

diff --git a/meson.build b/meson.build
index 1fd58b071bb90a49996e..1bccdb2c03d7846e7bfb 100644
--- a/meson.build
+++ b/meson.build
@@ -207,8 +207,8 @@  foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Werror=undef',
              '-Werror-implicit-function-declaration', '-Wpointer-arith',
              '-Wwrite-strings', '-Wstrict-prototypes', '-Wmissing-prototypes',
              '-Wmissing-declarations', '-Wnested-externs', '-Wpacked',
-             '-Wswitch-enum', '-Wmissing-format-attribute', 
-             '-Wstrict-aliasing=2', '-Winit-self', '-Winline', '-Wshadow', 
+             '-Wswitch-enum', '-Wmissing-format-attribute',
+             '-Wstrict-aliasing=2', '-Winit-self', '-Winline', '-Wshadow',
              '-Wdeclaration-after-statement', '-Wold-style-definition']
   if cc.has_argument(a)
     warn_c_args += a
@@ -216,7 +216,7 @@  foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Werror=undef',
 endforeach
 # GCC will never error for -Wno-*, so check for -W* then add -Wno-* to the list
 # of options
-foreach a : ['unused-parameter', 'attributes', 'long-long', 
+foreach a : ['unused-parameter', 'attributes', 'long-long',
              'missing-field-initializers']
   if cc.has_argument('-W@0@'.format(a))
     warn_c_args += '-Wno-@0@'.format(a)
@@ -326,7 +326,7 @@  pkg.generate(
   version : meson.project_version(),
   description : 'Userspace interface to kernel DRM services',
 )
- 
+
 if with_libkms
   subdir('libkms')
 endif