| Message ID | 20180201202012.36524-4-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu, Feb 1, 2018 at 9:20 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Do the renaming to be consistent with its sibling, i.e. > of_device_get_match_data(). > > No functional change. > > Fixes: 80212a162329 ("ACPI / bus: Introduce acpi_get_match_data() function") > Fixes: 146b4dbb0eef ("ACPI: properties: Implement get_match_data() callback") Why are you adding the Fixes: tags to a patch that doesn't make any functional changes? What are they useful for? -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 2018-02-04 at 08:23 +0100, Rafael J. Wysocki wrote: > On Thu, Feb 1, 2018 at 9:20 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > Do the renaming to be consistent with its sibling, i.e. > > of_device_get_match_data(). > > > > No functional change. > > > > Fixes: 80212a162329 ("ACPI / bus: Introduce acpi_get_match_data() > > function") > > Fixes: 146b4dbb0eef ("ACPI: properties: Implement get_match_data() > > callback") > > Why are you adding the Fixes: tags to a patch that doesn't make any > functional changes? > > What are they useful for? Because next patch depends on this one and fixes API. So, here the Fixes tags to be sure that next will apply cleanly.
On Monday, February 5, 2018 5:12:02 PM CET Andy Shevchenko wrote: > On Sun, 2018-02-04 at 08:23 +0100, Rafael J. Wysocki wrote: > > On Thu, Feb 1, 2018 at 9:20 PM, Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > Do the renaming to be consistent with its sibling, i.e. > > > of_device_get_match_data(). > > > > > > No functional change. > > > > > > Fixes: 80212a162329 ("ACPI / bus: Introduce acpi_get_match_data() > > > function") > > > Fixes: 146b4dbb0eef ("ACPI: properties: Implement get_match_data() > > > callback") > > > > Why are you adding the Fixes: tags to a patch that doesn't make any > > functional changes? > > > > What are they useful for? > > Because next patch depends on this one and fixes API. > So, here the Fixes tags to be sure that next will apply cleanly. They may mislead people to belive that the patch needs to be backported, so I'd rather not add them. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 413e4b1cb1be..0f3f38a4e0c5 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -787,7 +787,7 @@ const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids, } EXPORT_SYMBOL_GPL(acpi_match_device); -void *acpi_get_match_data(const struct device *dev) +void *acpi_device_get_match_data(const struct device *dev) { const struct acpi_device_id *match; @@ -797,7 +797,7 @@ void *acpi_get_match_data(const struct device *dev) return (void *)match->driver_data; } -EXPORT_SYMBOL_GPL(acpi_get_match_data); +EXPORT_SYMBOL_GPL(acpi_device_get_match_data); int acpi_match_device_ids(struct acpi_device *device, const struct acpi_device_id *ids) diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c index 466d1503aba0..f9b5fa230a86 100644 --- a/drivers/acpi/property.c +++ b/drivers/acpi/property.c @@ -1275,7 +1275,7 @@ static void * acpi_fwnode_device_get_match_data(const struct fwnode_handle *fwnode, const struct device *dev) { - return acpi_get_match_data(dev); + return acpi_device_get_match_data(dev); } #define DECLARE_ACPI_FWNODE_OPS(ops) \ diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 246845da3f84..d0cbbbd88e0e 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -587,7 +587,7 @@ extern int acpi_nvs_for_each_region(int (*func)(__u64, __u64, void *), const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids, const struct device *dev); -void *acpi_get_match_data(const struct device *dev); +void *acpi_device_get_match_data(const struct device *dev); extern bool acpi_driver_match_device(struct device *dev, const struct device_driver *drv); int acpi_device_uevent_modalias(struct device *, struct kobj_uevent_env *); @@ -766,7 +766,7 @@ static inline const struct acpi_device_id *acpi_match_device( return NULL; } -static inline void *acpi_get_match_data(const struct device *dev) +static inline void *acpi_device_get_match_data(const struct device *dev) { return NULL; }
Do the renaming to be consistent with its sibling, i.e. of_device_get_match_data(). No functional change. Fixes: 80212a162329 ("ACPI / bus: Introduce acpi_get_match_data() function") Fixes: 146b4dbb0eef ("ACPI: properties: Implement get_match_data() callback") Cc: Sinan Kaya <okaya@codeaurora.org> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Vinod Koul <vinod.koul@intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/acpi/bus.c | 4 ++-- drivers/acpi/property.c | 2 +- include/linux/acpi.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)