| Message ID | 1517231574-92777-2-git-send-email-preid@electromag.com.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 29 Jan 2018 21:12:53 +0800 Phil Reid <preid@electromag.com.au> wrote: > Add binding documentation for Analog Devices AD5272 and AD5274 digital > potentiometer devices. > > Signed-off-by: Phil Reid <preid@electromag.com.au> This is simply enough that I doubt Rob or Mark is that bothered about reviewing it. Obviously any reviews are still welcome though as it will be in a rebaseable tree probably until after the merge window closes. Applied to the togreg branch of iio.git and pushed out as testing. Thanks, Jonathan > --- > .../bindings/iio/potentiometer/ad5272.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > > diff --git a/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > new file mode 100644 > index 0000000..11e804c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > @@ -0,0 +1,27 @@ > +* Analog Devices AD5272 digital potentiometer driver > + > +The node for this driver must be a child node of a I2C controller, hence > +all mandatory properties for your controller must be specified. See directory: > + > + Documentation/devicetree/bindings/i2c > + > +for more details. > + > +Required properties: > + - compatible: Must be one of the following, depending on the model: > + adi,ad5272-020 > + adi,ad5272-050 > + adi,ad5272-100 > + adi,ad5274-020 > + adi,ad5274-100 > + > +Optional properties: > + - reset-gpios: GPIO specification for the RESET input. This is an > + active low signal to the PCA953x. > + > +Example: > +ad5272: ad5272@2f { > + reg = <0x2F>; > + compatible = "adi,ad5272-020"; > + reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>; > +}; -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 29, 2018 at 09:12:53PM +0800, Phil Reid wrote: > Add binding documentation for Analog Devices AD5272 and AD5274 digital > potentiometer devices. > > Signed-off-by: Phil Reid <preid@electromag.com.au> > --- > .../bindings/iio/potentiometer/ad5272.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > > diff --git a/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > new file mode 100644 > index 0000000..11e804c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > @@ -0,0 +1,27 @@ > +* Analog Devices AD5272 digital potentiometer driver Bindings describe h/w not drivers. > + > +The node for this driver must be a child node of a I2C controller, hence > +all mandatory properties for your controller must be specified. See directory: > + > + Documentation/devicetree/bindings/i2c > + > +for more details. > + > +Required properties: > + - compatible: Must be one of the following, depending on the model: > + adi,ad5272-020 > + adi,ad5272-050 > + adi,ad5272-100 > + adi,ad5274-020 > + adi,ad5274-100 > + > +Optional properties: > + - reset-gpios: GPIO specification for the RESET input. This is an > + active low signal to the PCA953x. > + > +Example: > +ad5272: ad5272@2f { potentiometer@2f Probably a node name we need to add to the spec. > + reg = <0x2F>; > + compatible = "adi,ad5272-020"; > + reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>; > +}; > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5/02/2018 14:07, Rob Herring wrote: > On Mon, Jan 29, 2018 at 09:12:53PM +0800, Phil Reid wrote: >> Add binding documentation for Analog Devices AD5272 and AD5274 digital >> potentiometer devices. >> >> Signed-off-by: Phil Reid <preid@electromag.com.au> >> --- >> .../bindings/iio/potentiometer/ad5272.txt | 27 ++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt >> new file mode 100644 >> index 0000000..11e804c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt >> @@ -0,0 +1,27 @@ >> +* Analog Devices AD5272 digital potentiometer driver > > Bindings describe h/w not drivers. ok > >> + >> +The node for this driver must be a child node of a I2C controller, hence >> +all mandatory properties for your controller must be specified. See directory: >> + >> + Documentation/devicetree/bindings/i2c >> + >> +for more details. >> + >> +Required properties: >> + - compatible: Must be one of the following, depending on the model: >> + adi,ad5272-020 >> + adi,ad5272-050 >> + adi,ad5272-100 >> + adi,ad5274-020 >> + adi,ad5274-100 >> + >> +Optional properties: >> + - reset-gpios: GPIO specification for the RESET input. This is an >> + active low signal to the PCA953x. >> + >> +Example: >> +ad5272: ad5272@2f { > > potentiometer@2f ok > > Probably a node name we need to add to the spec. > >> + reg = <0x2F>; >> + compatible = "adi,ad5272-020"; >> + reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>; >> +}; >> -- >> 1.8.3.1 >> > > Jonathan, How would you like me to fix this as you've applied it to togreg already? A patch on top of this or a v5.
On Mon, 5 Feb 2018 15:25:59 +0800 Phil Reid <preid@electromag.com.au> wrote: > On 5/02/2018 14:07, Rob Herring wrote: > > On Mon, Jan 29, 2018 at 09:12:53PM +0800, Phil Reid wrote: > >> Add binding documentation for Analog Devices AD5272 and AD5274 digital > >> potentiometer devices. > >> > >> Signed-off-by: Phil Reid <preid@electromag.com.au> > >> --- > >> .../bindings/iio/potentiometer/ad5272.txt | 27 ++++++++++++++++++++++ > >> 1 file changed, 27 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > >> > >> diff --git a/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > >> new file mode 100644 > >> index 0000000..11e804c > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt > >> @@ -0,0 +1,27 @@ > >> +* Analog Devices AD5272 digital potentiometer driver > > > > Bindings describe h/w not drivers. > ok > > > > >> + > >> +The node for this driver must be a child node of a I2C controller, hence > >> +all mandatory properties for your controller must be specified. See directory: > >> + > >> + Documentation/devicetree/bindings/i2c > >> + > >> +for more details. > >> + > >> +Required properties: > >> + - compatible: Must be one of the following, depending on the model: > >> + adi,ad5272-020 > >> + adi,ad5272-050 > >> + adi,ad5272-100 > >> + adi,ad5274-020 > >> + adi,ad5274-100 > >> + > >> +Optional properties: > >> + - reset-gpios: GPIO specification for the RESET input. This is an > >> + active low signal to the PCA953x. > >> + > >> +Example: > >> +ad5272: ad5272@2f { > > > > potentiometer@2f > ok > > > > > Probably a node name we need to add to the spec. > > > >> + reg = <0x2F>; > >> + compatible = "adi,ad5272-020"; > >> + reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>; > >> +}; > >> -- > >> 1.8.3.1 > >> > > > > > Jonathan, > > How would you like me to fix this as you've applied it to togreg already? > A patch on top of this or a v5. > Do a v5, I'll drop v4 and pick it up if Rob is happy. Jonathan > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt new file mode 100644 index 0000000..11e804c --- /dev/null +++ b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt @@ -0,0 +1,27 @@ +* Analog Devices AD5272 digital potentiometer driver + +The node for this driver must be a child node of a I2C controller, hence +all mandatory properties for your controller must be specified. See directory: + + Documentation/devicetree/bindings/i2c + +for more details. + +Required properties: + - compatible: Must be one of the following, depending on the model: + adi,ad5272-020 + adi,ad5272-050 + adi,ad5272-100 + adi,ad5274-020 + adi,ad5274-100 + +Optional properties: + - reset-gpios: GPIO specification for the RESET input. This is an + active low signal to the PCA953x. + +Example: +ad5272: ad5272@2f { + reg = <0x2F>; + compatible = "adi,ad5272-020"; + reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>; +};
Add binding documentation for Analog Devices AD5272 and AD5274 digital potentiometer devices. Signed-off-by: Phil Reid <preid@electromag.com.au> --- .../bindings/iio/potentiometer/ad5272.txt | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt