| Message ID | 20180207014117.62611-4-dbasehore@chromium.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 07/02/18 01:41, Derek Basehore wrote: > This adds documentation for the new reset-on-suspend property. This > property enables saving and restoring the ITS for when it loses state > in system suspend. > > Signed-off-by: Derek Basehore <dbasehore@chromium.org> > --- > Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt > index 0a57f2f4167d..a470147d4f14 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt > @@ -78,6 +78,9 @@ These nodes must have the following properties: > Optional: > - socionext,synquacer-pre-its: (u32, u32) tuple describing the untranslated > address and size of the pre-ITS window. > +- reset-on-suspend: Boolean property. Indicates that the ITS state is > + reset on suspend. The state is then saved on suspend and restored on > + resume. By whom? It is important to be clear about the respective responsibilities, as this forms a binding contract between firmware and OS. Mark: Can you have a look at how to formulate this? I'm not sure we have other instances of a non-architected behaviour involving FW participation, aside from PSCI. > > The main GIC node must contain the appropriate #address-cells, > #size-cells and ranges properties for the reg property of all ITS > Thanks, M.
On Wed, Feb 7, 2018 at 1:21 AM, Marc Zyngier <marc.zyngier@arm.com> wrote: > On 07/02/18 01:41, Derek Basehore wrote: >> This adds documentation for the new reset-on-suspend property. This >> property enables saving and restoring the ITS for when it loses state >> in system suspend. >> >> Signed-off-by: Derek Basehore <dbasehore@chromium.org> >> --- >> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> index 0a57f2f4167d..a470147d4f14 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt >> @@ -78,6 +78,9 @@ These nodes must have the following properties: >> Optional: >> - socionext,synquacer-pre-its: (u32, u32) tuple describing the untranslated >> address and size of the pre-ITS window. >> +- reset-on-suspend: Boolean property. Indicates that the ITS state is >> + reset on suspend. The state is then saved on suspend and restored on >> + resume. > > By whom? It is important to be clear about the respective > responsibilities, as this forms a binding contract between firmware and OS. > > Mark: Can you have a look at how to formulate this? I'm not sure we have > other instances of a non-architected behaviour involving FW > participation, aside from PSCI. I'll wait for Mark's reply to reword this. > >> >> The main GIC node must contain the appropriate #address-cells, >> #size-cells and ranges properties for the reg property of all ITS >> > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny...
diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt index 0a57f2f4167d..a470147d4f14 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt @@ -78,6 +78,9 @@ These nodes must have the following properties: Optional: - socionext,synquacer-pre-its: (u32, u32) tuple describing the untranslated address and size of the pre-ITS window. +- reset-on-suspend: Boolean property. Indicates that the ITS state is + reset on suspend. The state is then saved on suspend and restored on + resume. The main GIC node must contain the appropriate #address-cells, #size-cells and ranges properties for the reg property of all ITS
This adds documentation for the new reset-on-suspend property. This property enables saving and restoring the ITS for when it loses state in system suspend. Signed-off-by: Derek Basehore <dbasehore@chromium.org> --- Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 3 +++ 1 file changed, 3 insertions(+)